Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 3, 2026

No description provided.

@augmentcode
Copy link

augmentcode bot commented Jan 3, 2026

🤖 Augment PR Summary

Summary: This PR expands UIKit hosting support by refactoring and extending _UIHostingView.

Changes:

  • Moves several protocol conformances for _UIHostingView into a new UIHostingView+Extension.swift file (e.g. ViewRendererHost, TestHost, HostingViewProtocol).
  • Adds a ViewGraphRenderObserver.didRender() hook that forwards to UIHostingController.didRender().
  • Introduces background-color management changes, including an overridden backgroundColor setter and container-background fallback properties.
  • Adds UIHostingViewDelegate (package) for hosting view lifecycle/environment/preference callbacks.
  • Moves/renames UIViewControllerProvider into the UIKit Controller area and narrows it to package visibility.
  • Implements UIHostingViewBase.updateSize() to set the proposed size from the underlying UIKit view.
  • Adjusts visibility for some integration types (e.g. PlatformItemList, RootTransformProvider) to package.

Technical Notes: Several sections remain marked WIP/unimplemented; the refactor appears to prepare for a more complete UIKit update/render cycle implementation.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.28%. Comparing base (f04794e) to head (18237c0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
- Coverage   14.30%   14.28%   -0.02%     
==========================================
  Files         563      563              
  Lines       33190    33190              
==========================================
- Hits         4747     4742       -5     
- Misses      28443    28448       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye force-pushed the feature/ui_hostingview branch from 980df35 to f25f154 Compare January 3, 2026 12:03
@Kyle-Ye Kyle-Ye force-pushed the feature/ui_hostingview branch from f25f154 to 18237c0 Compare January 3, 2026 13:06
@Kyle-Ye Kyle-Ye merged commit ab517e3 into main Jan 3, 2026
7 of 9 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/ui_hostingview branch January 3, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants