Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Dec 20, 2025

No description provided.

@augmentcode
Copy link

augmentcode bot commented Dec 20, 2025

🤖 Augment PR Summary

Summary: This PR implements CoreGraphics-path-related C APIs in OpenSwiftUI_SPI and wires them into Path string parsing.

Changes:

  • Replaces the previous stubbed __CGPathParseString with a real implementation and exposes it (renamed) as _CGPathParseString.
  • Adds _CGPathCopyDescription to serialize a CGPath into the project’s command-string format (with optional coordinate rounding).
  • Adds _CGPathCreateRoundedRect to construct rounded-rect paths with radius clamping behavior.
  • Updates Sources/OpenSwiftUICore/Shape/Path.swift to call _CGPathParseString for LosslessStringConvertible parsing.
  • Updates Package.swift so OPENRENDERBOX_RENDERBOX is defined consistently for Swift, C, and C++ compilation settings.
  • Removes the old __CGPathParseString header/implementation files.
  • Adds a dedicated SPI test suite covering parsing, description generation, and rounded-rect edge cases.

Technical Notes: The new API lives under the OpenSwiftUI_SPI CoreGraphics overlay (modulemap umbrella) and is guarded for Darwin/CoreGraphics availability.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 3 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Dec 20, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 28.39%. Comparing base (7b4928d) to head (5c9ff28).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
Sources/OpenSwiftUICore/Shape/Path.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #676       +/-   ##
===========================================
+ Coverage   13.81%   28.39%   +14.57%     
===========================================
  Files         559      584       +25     
  Lines       32555    35186     +2631     
===========================================
+ Hits         4499     9992     +5493     
+ Misses      28056    25194     -2862     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit 5f393c5 into main Dec 21, 2025
7 of 9 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/cgpath branch December 21, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants