Skip to content

Commit 9b84df3

Browse files
committed
Fix missing Signpost API call
1 parent 8f81542 commit 9b84df3

File tree

2 files changed

+23
-6
lines changed

2 files changed

+23
-6
lines changed

Sources/OpenSwiftUICore/Data/Environment/EnvironmentalView.swift

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// OpenSwiftUICore
44
//
55
// Audited for iOS 18.0
6-
// Status: Blocked by Tracing
6+
// Status: Complete
77

88
import OpenGraphShims
99

@@ -55,8 +55,9 @@ struct EnvironmentalViewChild<V>: StatefulRule, AsyncAttribute, CustomStringConv
5555
guard shouldReset else { return }
5656
tracker.reset()
5757
tracker.initializeValues(from: env.plist)
58-
// TODO: Tracing
59-
value = view.body(environment: env)
58+
value = traceBody(V.self) {
59+
view.body(environment: env)
60+
}
6061
}
6162

6263
var description: String {

Sources/OpenSwiftUICore/Data/Update.swift

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// OpenSwiftUI
44
//
55
// Audited for iOS 18.0
6-
// Status: Blocked by Signpost
6+
// Status: Complete
77
// ID: EA173074DA35FA471DC70643259B7E74 (SwiftUI)
88
// ID: 61534957AEEC2EDC447ABDC13B4D426F (SwiftUICore)
99

@@ -68,14 +68,30 @@ package enum Update {
6868
lock()
6969
depth += 1
7070
if depth == 1 {
71-
// TODO: Signpost.renderUpdate.trace + trackHost
71+
Signpost.viewHost.traceEvent(
72+
type: .begin,
73+
object: trackHost,
74+
"", // TODO: For os_log use
75+
[
76+
0,
77+
UInt(bitPattern: Unmanaged.passUnretained(trackHost).toOpaque()),
78+
]
79+
)
7280
}
7381
}
7482

7583
package static func end() {
7684
if depth == 1 {
7785
dispatchActions()
78-
// TODO: Signpost.renderUpdate.trace + trackHost
86+
Signpost.viewHost.traceEvent(
87+
type: .end,
88+
object: trackHost,
89+
"", // TODO: For os_log use
90+
[
91+
0,
92+
UInt(bitPattern: Unmanaged.passUnretained(trackHost).toOpaque()),
93+
]
94+
)
7995
}
8096
depth -= 1
8197
unlock()

0 commit comments

Comments
 (0)