- <%== t(".slug_help", url: decidim_form_slug_url(:processes, form.object.slug)) %> -
+<%== t(".announcement_help") %>
-- <%== t(".scope_type_max_depth_help") %> -
", "
") { generate_localized_title } } organization hero_image { Decidim::Dev.test_file("city.jpeg", "image/jpeg") } # Keep after organization - banner_image { Decidim::Dev.test_file("city2.jpeg", "image/jpeg") } # Keep after organization + # banner_image { Decidim::Dev.test_file("city2.jpeg", "image/jpeg") } # Keep after organization published_at { Time.current } meta_scope { Decidim::Faker::Localized.word } developer_group { generate_localized_title } @@ -65,7 +65,7 @@ create(:participatory_process_step, active: true, end_date: evaluator.current_step_ends, - participatory_process: participatory_process) + participatory_process:) participatory_process.reload participatory_process.steps.reload end @@ -88,7 +88,7 @@ trait :with_scope do scopes_enabled { true } - scope { create :scope, organization: organization } + scope { create :scope, organization: } end end end diff --git a/lib/decidim/emitter/version.rb b/lib/decidim/emitter/version.rb index 8777336..442864c 100644 --- a/lib/decidim/emitter/version.rb +++ b/lib/decidim/emitter/version.rb @@ -3,7 +3,7 @@ module Decidim # This holds the decidim-meetings version. module Emitter - VERSION = "0.1.0" - DECIDIM_VERSION = "0.27.0" + VERSION = "1.0.0" + DECIDIM_VERSION = "~> 0.29.0" end end diff --git a/spec/cells/decidim/card_g_cell_spec.rb b/spec/cells/decidim/card_g_cell_spec.rb new file mode 100644 index 0000000..e57abbb --- /dev/null +++ b/spec/cells/decidim/card_g_cell_spec.rb @@ -0,0 +1,19 @@ +# frozen_string_literal: true + +require "spec_helper" + +describe Decidim::CardGCell, type: :cell do + subject { cell_html } + + controller Decidim::PagesController + + let!(:model) { create(:dummy_resource) } + let(:my_cell) { cell("decidim/card_g", model) } + let(:cell_html) { my_cell.call } + + before do + allow(model).to receive(:description).and_return(model.body) + end + + it_behaves_like "m-cell", :model +end diff --git a/spec/cells/decidim/participatory_processes/content_blocks/highlighted_processes_cell_spec.rb b/spec/cells/decidim/participatory_processes/content_blocks/highlighted_processes_cell_spec.rb deleted file mode 100644 index 468916d..0000000 --- a/spec/cells/decidim/participatory_processes/content_blocks/highlighted_processes_cell_spec.rb +++ /dev/null @@ -1,38 +0,0 @@ -# frozen_string_literal: true - -require "spec_helper" - -describe Decidim::ParticipatoryProcesses::ContentBlocks::HighlightedProcessesCell, type: :cell do - subject { cell(content_block.cell, content_block).call } - - let(:organization) { create(:organization) } - let(:content_block) { create :content_block, organization: organization, manifest_name: :highlighted_processes, scope_name: :homepage, settings: settings } - let!(:processes) { create_list :participatory_process, 5, organization: organization } - let(:settings) { {} } - - let(:highlighted_processes) { subject.find("#highlighted-processes") } - - controller Decidim::PagesController - - before do - allow(controller).to receive(:current_organization).and_return(organization) - end - - context "when the content block has no settings" do - it "shows 4 processes" do - expect(highlighted_processes).to have_selector("a.card--process", count: 4) - end - end - - context "when the content block has customized the welcome text setting value" do - let(:settings) do - { - "max_results" => "8" - } - end - - it "shows up to 8 processes" do - expect(highlighted_processes).to have_selector("a.card--process", count: 5) - end - end -end diff --git a/spec/commands/copy_participatory_process_spec.rb b/spec/commands/copy_participatory_process_spec.rb index 93b1c7e..0187e7e 100644 --- a/spec/commands/copy_participatory_process_spec.rb +++ b/spec/commands/copy_participatory_process_spec.rb @@ -4,15 +4,15 @@ module Decidim::ParticipatoryProcesses describe Admin::CopyParticipatoryProcess do - subject { described_class.new(form, participatory_process, user) } + subject { described_class.new(form, participatory_process) } - let(:organization) { create :organization } - let(:user) { create :user, organization: organization } - let(:participatory_process_group) { create :participatory_process_group, organization: organization } - let(:scope) { create :scope, organization: organization } + let(:organization) { create(:organization) } + let(:current_user) { create(:user, organization:) } + let(:participatory_process_group) { create(:participatory_process_group, organization:) } + let(:scope) { create(:scope, organization:) } let(:errors) { double.as_null_object } - let!(:participatory_process) { create :participatory_process, :with_steps } - let!(:component) { create :component, manifest_name: :dummy, participatory_space: participatory_process } + let!(:participatory_process) { create(:participatory_process, :with_steps) } + let!(:component) { create(:component, manifest_name: :dummy, participatory_space: participatory_process) } let(:form) do instance_double( Admin::ParticipatoryProcessCopyForm, @@ -21,7 +21,8 @@ module Decidim::ParticipatoryProcesses slug: "copied-slug", copy_steps?: copy_steps, copy_categories?: copy_categories, - copy_components?: copy_components + copy_components?: copy_components, + current_user: ) end let!(:category) do @@ -75,10 +76,10 @@ module Decidim::ParticipatoryProcesses expect { subject.call }.to broadcast(:ok) end - it "traces the action", versioning: true do + it "traces the action", :versioning do expect(Decidim.traceability) .to receive(:perform_action!) - .with("duplicate", Decidim::ParticipatoryProcess, user) + .with("duplicate", Decidim::ParticipatoryProcess, current_user) .and_call_original expect { subject.call }.to change(Decidim::ActionLog, :count) @@ -144,7 +145,7 @@ module Decidim::ParticipatoryProcesses expect { subject.call }.to change(Decidim::Component, :count).by(1) last_participatory_process = Decidim::ParticipatoryProcess.last - last_component = Decidim::Component.all.reorder(:id).last + last_component = Decidim::Component.reorder(:id).last expect(last_component.participatory_space).to eq(last_participatory_process) expect(last_component.name).to eq(component.name) diff --git a/spec/commands/create_participatory_process_spec.rb b/spec/commands/create_participatory_process_spec.rb index 1d58afc..0177912 100644 --- a/spec/commands/create_participatory_process_spec.rb +++ b/spec/commands/create_participatory_process_spec.rb @@ -3,32 +3,32 @@ require "spec_helper" module Decidim::ParticipatoryProcesses - describe Admin::CreateParticipatoryProcess, versioning: true do + describe Admin::CreateParticipatoryProcess, :versioning do subject { described_class.new(form) } - let(:organization) { create :organization } - let(:participatory_process_group) { create :participatory_process_group, organization: organization } - let(:participatory_process_type) { create :participatory_process_type, organization: organization } - let(:scope) { create :scope, organization: organization } - let(:area) { create :area, organization: organization } - let(:current_user) { create :user, :admin, organization: organization } + let(:organization) { create(:organization) } + let(:participatory_process_group) { create(:participatory_process_group, organization:) } + let(:participatory_process_type) { create(:participatory_process_type, organization:) } + let(:scope) { create(:scope, organization:) } + let(:area) { create(:area, organization:) } + let(:current_user) { create(:user, :admin, organization:) } let(:errors) { double.as_null_object } let(:related_process_ids) { [] } + let(:weight) { 1 } + let(:hero_image) { nil } let(:emitter) { upload_test_file(Decidim::Dev.test_file("city.jpeg", "image/jpeg")) } let(:emitter_name) { "Berlin" } - let(:weight) { 1 } let(:form) do instance_double( Admin::ParticipatoryProcessForm, invalid?: invalid, title: { en: "title" }, subtitle: { en: "subtitle" }, - weight: weight, + weight:, slug: "slug", hashtag: "hashtag", meta_scope: { en: "meta scope" }, - hero_image: nil, - banner_image: nil, + hero_image:, promoted: nil, developer_group: { en: "developer group" }, local_area: { en: "local" }, @@ -39,22 +39,21 @@ module Decidim::ParticipatoryProcesses end_date: nil, description: { en: "description" }, short_description: { en: "short_description" }, - current_user: current_user, + current_user:, current_organization: organization, + organization:, scopes_enabled: true, private_space: false, - scope: scope, + scope:, scope_type_max_depth: nil, - area: area, - errors: errors, - related_process_ids: related_process_ids, - participatory_process_group: participatory_process_group, - participatory_process_type: participatory_process_type, - show_statistics: false, - show_metrics: false, + area:, + errors:, + related_process_ids:, + participatory_process_group:, + participatory_process_type:, announcement: { en: "message" }, - emitter: emitter, - emitter_name: emitter_name + emitter:, + emitter_name: ) end let(:invalid) { false } @@ -68,20 +67,16 @@ module Decidim::ParticipatoryProcesses end context "when the process is not persisted" do - let(:invalid_process) do - instance_double( - Decidim::ParticipatoryProcess, - persisted?: false, - valid?: false, - errors: { - hero_image: "File resolution is too large", - banner_image: "File resolution is too large" - } - ).as_null_object + let(:hero_image) do + ActiveStorage::Blob.create_and_upload!( + io: File.open(Decidim::Dev.asset("invalid.jpeg")), + filename: "avatar.jpeg", + content_type: "image/jpeg" + ) end before do - allow(Decidim::ParticipatoryProcess).to receive(:new).and_return(invalid_process) + allow(Decidim::ActionLogger).to receive(:log).and_return(true) end it "broadcasts invalid" do @@ -90,7 +85,6 @@ module Decidim::ParticipatoryProcesses it "adds errors to the form" do expect(errors).to receive(:add).with(:hero_image, "File resolution is too large") - expect(errors).to receive(:add).with(:banner_image, "File resolution is too large") subject.call end end @@ -102,17 +96,15 @@ module Decidim::ParticipatoryProcesses expect { subject.call }.to change(Decidim::ParticipatoryProcess, :count).by(1) end - it "traces the creation", versioning: true do - expect(Decidim::ActionLogger) - .to receive(:log) - .with("create", current_user, a_kind_of(Decidim::ParticipatoryProcess), a_kind_of(Integer)) + it "traces the action", :versioning do + expect(Decidim.traceability) + .to receive(:create) + .with(Decidim::ParticipatoryProcess, current_user, kind_of(Hash)) .and_call_original expect { subject.call }.to change(Decidim::ActionLog, :count) - action_log = Decidim::ActionLog.last expect(action_log.version).to be_present - expect(action_log.version.event).to eq "create" end it "broadcasts ok" do @@ -125,31 +117,25 @@ module Decidim::ParticipatoryProcesses expect(process.steps.first).to be_active end - it "doesn't enable by default stats and metrics" do - subject.call - expect(process.show_statistics).to be(false) - expect(process.show_metrics).to be(false) - end - it "adds the admins as followers" do subject.call expect(current_user.follows?(process)).to be true end context "with related processes" do - let!(:another_process) { create :participatory_process, organization: organization } + let!(:another_process) { create(:participatory_process, organization:) } let(:related_process_ids) { [another_process.id] } it "links related processes" do subject.call linked_processes = process.linked_participatory_space_resources(:participatory_process, "related_processes") - expect(linked_processes).to match_array([another_process]) + expect(linked_processes).to contain_exactly(another_process) end context "when sorting by weight" do - let!(:process_one) { create :participatory_process, organization: organization, weight: 2 } - let!(:process_two) { create :participatory_process, organization: organization, weight: 1 } + let!(:process_one) { create(:participatory_process, organization:, weight: 2) } + let!(:process_two) { create(:participatory_process, organization:, weight: 1) } let(:related_process_ids) { [process_one.id, process_two.id] } it "links processes in right way" do diff --git a/spec/commands/update_participatory_process_spec.rb b/spec/commands/update_participatory_process_spec.rb index f321102..776c2e3 100644 --- a/spec/commands/update_participatory_process_spec.rb +++ b/spec/commands/update_participatory_process_spec.rb @@ -33,8 +33,6 @@ module Decidim::ParticipatoryProcesses area: my_process.area, errors: my_process.errors, participatory_process_group: my_process.participatory_process_group, - show_metrics: my_process.show_metrics, - show_statistics: my_process.show_statistics, private_space: my_process.private_space, emitter_name: my_process.emitter_name }.merge(attachment_params) @@ -43,8 +41,7 @@ module Decidim::ParticipatoryProcesses let(:attachment_params) do { hero_image: my_process.hero_image.blob, - banner_image: my_process.banner_image.blob, - emitter: my_process.banner_image.blob + emitter: my_process.hero_image.blob } end let(:user) { create :user, :admin, :confirmed, organization: my_process.organization } @@ -58,7 +55,7 @@ module Decidim::ParticipatoryProcesses let(:form) do Admin::ParticipatoryProcessForm.from_params(params).with_context(context) end - let(:command) { described_class.new(my_process, form) } + let(:command) { described_class.new(form, my_process) } describe "when the form is not valid" do before do @@ -82,7 +79,6 @@ module Decidim::ParticipatoryProcesses allow(form).to receive(:invalid?).and_return(false) expect(my_process).to receive(:valid?).at_least(:once).and_return(false) my_process.errors.add(:hero_image, "File resolution is too large") - my_process.errors.add(:banner_image, "File resolution is too large") end it "broadcasts invalid" do @@ -93,7 +89,6 @@ module Decidim::ParticipatoryProcesses command.call expect(form.errors[:hero_image]).not_to be_empty - expect(form.errors[:banner_image]).not_to be_empty end end @@ -109,10 +104,10 @@ module Decidim::ParticipatoryProcesses expect(my_process.title["en"]).to eq("Foo title") end - it "tracks the action", versioning: true do + it "tracks the action", :versioning do expect(Decidim.traceability) .to receive(:perform_action!) - .with(:update, my_process, user) + .with(:update, my_process, user, {}) .and_call_original expect { command.call }.to change(Decidim::ActionLog, :count) @@ -129,41 +124,7 @@ module Decidim::ParticipatoryProcesses command.call linked_processes = my_process.linked_participatory_space_resources(:participatory_process, "related_processes") - expect(linked_processes).to match_array([another_process]) - end - end - - context "when no homepage image is set" do - let(:attachment_params) do - { - banner_image: my_process.banner_image.blob - } - end - - it "does not replace the homepage image" do - expect(my_process).not_to receive(:hero_image=) - - command.call - my_process.reload - - expect(my_process.hero_image.attached?).to be true - end - end - - context "when no banner image is set" do - let(:attachment_params) do - { - hero_image: my_process.hero_image.blob - } - end - - it "does not replace the banner image" do - expect(my_process).not_to receive(:banner_image=) - - command.call - my_process.reload - - expect(my_process.banner_image.attached?).to be true + expect(linked_processes).to contain_exactly(another_process) end end end diff --git a/spec/forms/participatory_process_form_spec.rb b/spec/forms/participatory_process_form_spec.rb index 7304811..22c5627 100644 --- a/spec/forms/participatory_process_form_spec.rb +++ b/spec/forms/participatory_process_form_spec.rb @@ -41,8 +41,6 @@ module Admin let(:slug) { "slug" } let(:attachment) { upload_test_file(Decidim::Dev.test_file("city.jpeg", "image/jpeg")) } let(:emitter_name) { "city" } - let(:show_metrics) { true } - let(:show_statistics) { true } let(:attributes) do { "participatory_process" => { @@ -60,12 +58,9 @@ module Admin "short_description_es" => short_description[:es], "short_description_ca" => short_description[:ca], "hero_image" => attachment, - "banner_image" => attachment, - "emitter" => attachment, - "emitter_name" => emitter_name, "slug" => slug, - "show_metrics" => show_metrics, - "show_statistics" => show_statistics + "emitter" => attachment, + "emitter_name" => emitter_name } } end @@ -74,7 +69,7 @@ module Admin it { is_expected.to be_valid } end - context "when banner_image is too big" do + context "when hero_image is too big" do before do organization.settings.tap do |settings| settings.upload.maximum_file_size.default = 5 @@ -146,7 +141,7 @@ module Admin context "when slug is not unique" do context "and process in the same organization" do before do - create(:participatory_process, slug: slug, organization: organization) + create(:participatory_process, slug:, organization:) end it "is not valid" do @@ -157,7 +152,7 @@ module Admin context "and process in another organization" do before do - create(:participatory_process, slug: slug) + create(:participatory_process, slug:) end it "is valid" do diff --git a/spec/helpers/decidim/emitter/emitter_helper_spec.rb b/spec/helpers/decidim/emitter/emitter_helper_spec.rb index 7e51bf6..515be6d 100644 --- a/spec/helpers/decidim/emitter/emitter_helper_spec.rb +++ b/spec/helpers/decidim/emitter/emitter_helper_spec.rb @@ -9,11 +9,11 @@ module Emitter let(:organization) { create(:organization) } let(:emitter_names) { %w(Abidjan London Tokyo) } let(:emitter) { upload_test_file(Decidim::Dev.test_file("city.jpeg", "image/jpeg")) } - let!(:participatory_process) { create(:participatory_process, emitter_name: "Berlin", emitter: emitter, organization: organization) } + let!(:participatory_process) { create(:participatory_process, emitter_name: "Berlin", emitter:, organization:) } before do emitter_names.each do |emitter_name| - create(:participatory_process, emitter_name: emitter_name, emitter: emitter, organization: organization) + create(:participatory_process, emitter_name:, emitter:, organization:) end allow_any_instance_of(ActionView::Base).to receive(:current_organization).and_return(organization) end diff --git a/spec/lib/decidim/emitter/version_spec.rb b/spec/lib/decidim/emitter/version_spec.rb index ab08706..ba28bd0 100644 --- a/spec/lib/decidim/emitter/version_spec.rb +++ b/spec/lib/decidim/emitter/version_spec.rb @@ -7,7 +7,7 @@ module Decidim subject { described_class } it "has version" do - expect(Decidim::Emitter::VERSION).to eq("0.1.0") + expect(Decidim::Emitter::VERSION).to eq("1.0.0") end end end diff --git a/spec/models/decidim/participatory_process_spec.rb b/spec/models/decidim/participatory_process_spec.rb index e0a260a..40d35f8 100644 --- a/spec/models/decidim/participatory_process_spec.rb +++ b/spec/models/decidim/participatory_process_spec.rb @@ -20,7 +20,7 @@ module Decidim .to eq Decidim::ParticipatoryProcesses::AdminLog::ParticipatoryProcessPresenter end - context "when there's a process with the same slug in the same organization" do + context "when there is a process with the same slug in the same organization" do let!(:external_process) { create :participatory_process, organization: participatory_process.organization, slug: "my-slug" } it "is not valid" do @@ -29,16 +29,16 @@ module Decidim end end - context "when there's a process with the same slug in another organization" do + context "when there is a process with the same slug in another organization" do let!(:external_process) { create :participatory_process, slug: "my-slug" } it { is_expected.to be_valid } end context "when a process is attached to a scope type" do - let!(:participatory_process) { create(:participatory_process, :with_scope, slug: "my-slug", scope_type_max_depth: scope_type, organization: organization) } + let!(:participatory_process) { create(:participatory_process, :with_scope, slug: "my-slug", scope_type_max_depth: scope_type, organization:) } let(:organization) { create(:organization) } - let(:scope_type) { create(:scope_type, organization: organization) } + let(:scope_type) { create(:scope_type, organization:) } it "allows destroying the scope type" do scope_type.destroy! @@ -124,7 +124,7 @@ module Decidim describe "active_spaces" do it "returns the currently active ones" do - expect(described_class.active_spaces).to match_array [active, ends_today] + expect(described_class.active_spaces).to contain_exactly(active, ends_today) expect(described_class.active_spaces).not_to include past expect(described_class.active_spaces).not_to include upcoming end diff --git a/spec/permissions/admin/permissions_spec.rb b/spec/permissions/admin/permissions_spec.rb index d4fc73c..678906f 100644 --- a/spec/permissions/admin/permissions_spec.rb +++ b/spec/permissions/admin/permissions_spec.rb @@ -18,7 +18,7 @@ module Decidim::Emitter::Admin let(:permission_action) { Decidim::PermissionAction.new(**action) } context "when user is admin" do - let(:user) { create :user, :admin, organization: organization } + let(:user) { create :user, :admin, organization: } it { is_expected.to be_truthy } @@ -32,7 +32,7 @@ module Decidim::Emitter::Admin end context "when user is not admin" do - let(:user) { create :user, organization: organization } + let(:user) { create :user, organization: } it_behaves_like "permission is not set" end diff --git a/spec/shared/manage_processes_examples.rb b/spec/shared/manage_processes_examples.rb index b72c16f..98e52bd 100644 --- a/spec/shared/manage_processes_examples.rb +++ b/spec/shared/manage_processes_examples.rb @@ -2,25 +2,24 @@ shared_examples "manage processes examples" do context "when viewing the processes list" do - let!(:process_group) { create(:participatory_process_group, organization: organization) } - let!(:process_with_group) { create(:participatory_process, organization: organization, participatory_process_group: process_group) } - let!(:process_without_group) { create(:participatory_process, organization: organization) } + let!(:process_group) { create(:participatory_process_group, organization:) } + let!(:process_with_group) { create(:participatory_process, organization:, participatory_process_group: process_group) } + let!(:process_without_group) { create(:participatory_process, organization:) } let(:model_name) { participatory_process.class.model_name } let(:resource_controller) { Decidim::ParticipatoryProcesses::Admin::ParticipatoryProcessesController } + include_context "with filterable context" + def filter_by_group(group_title) visit current_path - within(".card-title") do - click_button("Process Groups") - click_link(group_title) - end + apply_filter("By process group", group_title) end it "allows the user to filter processes by process_group" do filter_by_group(translated(process_group.title)) expect(page).to have_content(translated(process_with_group.title)) - expect(page).not_to have_content(translated(process_without_group.title)) + expect(page).to have_no_content(translated(process_without_group.title)) end describe "listing processes" do @@ -31,21 +30,15 @@ def filter_by_group(group_title) context "when processes are filtered by process_group" do before { filter_by_group(translated(process_group.title)) } - it "allows the user to edit the process_group" do - click_link translated(process_group.title) - - expect(page).to have_content("Edit process group") - end - describe "listing processes filtered by group" do it_behaves_like "filtering collection by published/unpublished" do let!(:published_space) { process_with_group } - let!(:unpublished_space) { create(:participatory_process, :unpublished, organization: organization, participatory_process_group: process_group) } + let!(:unpublished_space) { create(:participatory_process, :unpublished, organization:, participatory_process_group: process_group) } end it_behaves_like "filtering collection by private/public" do let!(:public_space) { process_with_group } - let!(:private_space) { create(:participatory_process, :private, organization: organization, participatory_process_group: process_group) } + let!(:private_space) { create(:participatory_process, :private, organization:, participatory_process_group: process_group) } end end end @@ -53,28 +46,32 @@ def filter_by_group(group_title) context "when previewing processes" do context "when the process is unpublished" do - let!(:participatory_process) { create(:participatory_process, :unpublished, organization: organization) } + let!(:participatory_process) { create(:participatory_process, :unpublished, organization:) } it "allows the user to preview the unpublished process" do - within find("tr", text: translated(participatory_process.title)) do - click_link "Preview" - end + new_window = window_opened_by { page.find("tr", text: translated(participatory_process.title)).click_on("Preview") } - expect(page).to have_css(".process-header") - expect(page).to have_content(translated(participatory_process.title)) + page.within_window(new_window) do + expect(page).to have_css(".participatory-space__container") + expect(page).to have_content(translated(participatory_process.title)) + end end end context "when the process is published" do - let!(:participatory_process) { create(:participatory_process, organization: organization) } + let!(:participatory_process) { create(:participatory_process, organization:) } it "allows the user to preview the published process" do - within find("tr", text: translated(participatory_process.title)) do - click_link "Preview" + within "tr", text: translated(participatory_process.title) do + click_on "Preview" end - expect(page).to have_current_path decidim_participatory_processes.participatory_process_path(participatory_process) - expect(page).to have_content(translated(participatory_process.title)) + new_window = window_opened_by { page.find("tr", text: translated(participatory_process.title)).click_on("Preview") } + + page.within_window(new_window) do + expect(page).to have_current_path decidim_participatory_processes.participatory_process_path(participatory_process) + expect(page).to have_content(translated(participatory_process.title)) + end end end end @@ -88,23 +85,34 @@ def filter_by_group(group_title) context "when updating a participatory process" do let(:image3_filename) { "city3.jpeg" } let(:image3_path) { Decidim::Dev.asset(image3_filename) } + let(:attributes) { attributes_for(:participatory_process, organization:) } before do - click_link translated(participatory_process.title) + within "tr", text: translated(participatory_process.title) do + click_on translated(participatory_process.title) + end + + within_admin_sidebar_menu do + click_on "About this process" + end end it "updates a participatory_process" do - fill_in_i18n( - :participatory_process_title, - "#participatory_process-title-tabs", - en: "My new title", - es: "Mi nuevo título", - ca: "El meu nou títol" - ) - dynamically_attach_file(:participatory_process_banner_image, image3_path, remove_before: true) - - page.execute_script("$('#participatory_process_end_date').focus()") - page.find(".datepicker-dropdown .day", text: "22").click + fill_in_i18n(:participatory_process_title, "#participatory_process-title-tabs", **attributes[:title].except("machine_translations")) + fill_in_i18n(:participatory_process_subtitle, "#participatory_process-subtitle-tabs", **attributes[:subtitle].except("machine_translations")) + fill_in_i18n_editor(:participatory_process_short_description, "#participatory_process-short_description-tabs", **attributes[:short_description].except("machine_translations")) + fill_in_i18n_editor(:participatory_process_description, "#participatory_process-description-tabs", **attributes[:description].except("machine_translations")) + fill_in_i18n_editor(:participatory_process_announcement, "#participatory_process-announcement-tabs", **attributes[:announcement].except("machine_translations")) + fill_in_i18n(:participatory_process_developer_group, "#participatory_process-developer_group-tabs", **attributes[:developer_group].except("machine_translations")) + fill_in_i18n(:participatory_process_local_area, "#participatory_process-local_area-tabs", **attributes[:local_area].except("machine_translations")) + fill_in_i18n(:participatory_process_meta_scope, "#participatory_process-meta_scope-tabs", **attributes[:meta_scope].except("machine_translations")) + fill_in_i18n(:participatory_process_target, "#participatory_process-target-tabs", **attributes[:target].except("machine_translations")) + fill_in_i18n(:participatory_process_participatory_scope, "#participatory_process-participatory_scope-tabs", **attributes[:participatory_scope].except("machine_translations")) + fill_in_i18n(:participatory_process_participatory_structure, "#participatory_process-participatory_structure-tabs", **attributes[:participatory_structure].except("machine_translations")) + + dynamically_attach_file(:participatory_process_hero_image, image3_path, remove_before: true) + + fill_in_datepicker :participatory_process_end_date_date, with: Time.new.utc.strftime("%d/%m/%Y") within ".edit_participatory_process" do find("*[type=submit]").click @@ -112,22 +120,31 @@ def filter_by_group(group_title) expect(page).to have_admin_callout("successfully") - within ".container" do - expect(page).to have_selector("input[value='My new title']") + within "[data-content]" do + expect(page).to have_css("input[value='#{translated(attributes[:title])}']") expect(page).to have_css("img[src*='#{image3_filename}']") end + + visit decidim_admin.root_path + expect(page).to have_content("updated the #{translated(attributes[:title])} participatory process") end end context "when publishing a process" do - let!(:participatory_process) { create(:participatory_process, :unpublished, organization: organization) } + let!(:participatory_process) { create(:participatory_process, :unpublished, organization:) } before do - click_link translated(participatory_process.title) + within "tr", text: translated(participatory_process.title) do + click_on translated(participatory_process.title) + end + + within_admin_sidebar_menu do + click_on "About this process" + end end it "publishes the process" do - click_link "Publish" + click_on "Publish" expect(page).to have_content("successfully published") expect(page).to have_content("Unpublish") expect(page).to have_current_path decidim_admin_participatory_processes.edit_participatory_process_path(participatory_process) @@ -138,14 +155,20 @@ def filter_by_group(group_title) end context "when unpublishing a process" do - let!(:participatory_process) { create(:participatory_process, organization: organization) } + let!(:participatory_process) { create(:participatory_process, organization:) } before do - click_link translated(participatory_process.title) + within "tr", text: translated(participatory_process.title) do + click_on translated(participatory_process.title) + end + + within_admin_sidebar_menu do + click_on "About this process" + end end it "unpublishes the process" do - click_link "Unpublish" + click_on "Unpublish" expect(page).to have_content("successfully unpublished") expect(page).to have_content("Publish") expect(page).to have_current_path decidim_admin_participatory_processes.edit_participatory_process_path(participatory_process) @@ -162,7 +185,7 @@ def filter_by_group(group_title) visit decidim_admin_participatory_processes.participatory_processes_path end - it "doesn't let the admin manage processes form other organizations" do + it "does not let the admin manage processes form other organizations" do within "table" do expect(page).to have_no_content(external_participatory_process.title["en"]) end @@ -170,19 +193,24 @@ def filter_by_group(group_title) end context "when the process has a scope" do - let(:scope) { create(:scope, organization: organization) } + let(:scope) { create(:scope, organization:) } before do - participatory_process.update!(scopes_enabled: true, scope: scope) + participatory_process.update!(scopes_enabled: true, scope:) end it "disables the scope for a participatory process" do - click_link translated(participatory_process.title) + within "tr", text: translated(participatory_process.title) do + click_on translated(participatory_process.title) + end + + within_admin_sidebar_menu do + click_on "About this process" + end uncheck :participatory_process_scopes_enabled - expect(page).to have_selector("#participatory_process_scope_id.disabled") - expect(page).to have_selector("#participatory_process_scope_id .picker-values div input[disabled]", visible: :all) + expect(page).to have_css("#participatory_process_scope_id[disabled]") within ".edit_participatory_process" do find("*[type=submit]").click diff --git a/spec/shared/participatory_process_administration_by_admin_shared_context.rb b/spec/shared/participatory_process_administration_by_admin_shared_context.rb index e0b64e8..1cc359c 100644 --- a/spec/shared/participatory_process_administration_by_admin_shared_context.rb +++ b/spec/shared/participatory_process_administration_by_admin_shared_context.rb @@ -2,7 +2,7 @@ shared_context "when admin administrating a participatory process" do let!(:user) do - create(:user, :admin, :confirmed, organization: organization) + create(:user, :admin, :confirmed, organization:) end include_context "when administrating a participatory process" diff --git a/spec/shared/participatory_process_administration_shared_context.rb b/spec/shared/participatory_process_administration_shared_context.rb index 22e5bef..3839d1b 100644 --- a/spec/shared/participatory_process_administration_shared_context.rb +++ b/spec/shared/participatory_process_administration_shared_context.rb @@ -3,5 +3,5 @@ shared_context "when administrating a participatory process" do let(:organization) { create(:organization) } - let!(:participatory_process) { create(:participatory_process, organization: organization) } + let!(:participatory_process) { create(:participatory_process, organization:) } end diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 66d395a..8e5b69d 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -9,7 +9,7 @@ require "decidim/dev/test/base_spec_helper" Capybara.register_driver :headless_chrome do |app| - options = ::Selenium::WebDriver::Chrome::Options.new + options = Selenium::WebDriver::Chrome::Options.new options.args << "--headless=new" options.args << "--no-sandbox" options.args << if ENV["BIG_SCREEN_SIZE"].present? @@ -21,6 +21,6 @@ Capybara::Selenium::Driver.new( app, browser: :chrome, - capabilities: [options] + options: ) end diff --git a/spec/system/admin/admin_import_participatory_process_spec.rb b/spec/system/admin/admin_import_participatory_process_spec.rb index efca96f..e8d125c 100644 --- a/spec/system/admin/admin_import_participatory_process_spec.rb +++ b/spec/system/admin/admin_import_participatory_process_spec.rb @@ -2,9 +2,8 @@ require "spec_helper" -describe "Admin imports participatory process", type: :system do +describe "Admin imports participatory process" do # rubocop:disable RSpec/DescribeClass include_context "when admin administrating a participatory process" - let!(:user) { create(:user, :admin, :confirmed, organization: organization) } before do switch_to_host(organization.host) @@ -14,7 +13,9 @@ context "with context" do before "Imports the process with the basic fields" do - click_link "Import", match: :first + within_admin_menu do + click_on "Import" + end within ".import_participatory_process" do fill_in_i18n( @@ -28,32 +29,42 @@ end stub_get_request_with_format("http://localhost:3000/uploads/decidim/participatory_process/hero_image/1/city.jpeg", "image/jpeg") - stub_get_request_with_format("http://localhost:3000/uploads/decidim/participatory_process/banner_image/1/city2.jpeg", "image/jpeg") dynamically_attach_file(:participatory_process_document, Decidim::Dev.asset("participatory_processes.json")) - click_button "Import" + click_on "Import" end it "imports the json document" do expect(page).to have_content("successfully") expect(page).to have_content("Import participatory process") - expect(page).to have_content("Not published") + expect(page).to have_content("Unpublished") - click_link "Import participatory process" + within "tr", text: "Import participatory process" do + click_on "Import participatory process" + end + + within_admin_sidebar_menu do + click_on "Phases" + end - click_link "Phases" within ".table-list" do expect(page).to have_content(translated("Magni.")) end - click_link "Categories" + within_admin_sidebar_menu do + click_on "Categories" + end + within ".table-list" do expect(page).to have_content(translated("Illum nesciunt praesentium explicabo qui.")) expect(page).to have_content(translated("Expedita sint earum rerum consequatur.")) end - click_link "Components" + within_admin_sidebar_menu do + click_on "Components" + end + expect(Decidim::ParticipatoryProcess.last.components.size).to eq(3) within ".table-list" do Decidim::ParticipatoryProcess.last.components.each do |component| @@ -61,7 +72,10 @@ end end - click_link "Files" + within_admin_sidebar_menu do + click_on "Attachments" + end + if Decidim::ParticipatoryProcess.last.attachments.any? within ".table-list" do Decidim::ParticipatoryProcess.last.attachments.each do |attachment| diff --git a/spec/system/admin/admin_manages_participatory_processes_spec.rb b/spec/system/admin/admin_manages_participatory_processes_spec.rb index 2f30644..9b3a0c3 100644 --- a/spec/system/admin/admin_manages_participatory_processes_spec.rb +++ b/spec/system/admin/admin_manages_participatory_processes_spec.rb @@ -2,11 +2,11 @@ require "spec_helper" -describe "Admin manages participatory processes", versioning: true, type: :system do +describe "Admin manages participatory processes", :versioning do # rubocop:disable RSpec/DescribeClass include_context "when admin administrating a participatory process" let!(:participatory_process_groups) do - create_list(:participatory_process_group, 3, organization: organization) + create_list(:participatory_process_group, 3, organization:) end before do @@ -15,6 +15,37 @@ visit decidim_admin_participatory_processes.participatory_processes_path end + context "when conditionally displaying private user menu entry" do + let!(:my_space) { create(:participatory_process, organization:, private_space:) } + + before do + switch_to_host(organization.host) + login_as user, scope: :user + visit decidim_admin_participatory_processes.participatory_processes_path + click_on translated(my_space.title) + end + + context "when the participatory process is private" do + let(:private_space) { true } + + it "hides the private user menu entry" do + within_admin_sidebar_menu do + expect(page).to have_content("Private participants") + end + end + end + + context "when the participatory process is public" do + let(:private_space) { false } + + it "shows the private user menu entry" do + within_admin_sidebar_menu do + expect(page).to have_no_content("Private participants") + end + end + end + end + it_behaves_like "manage processes examples" it_behaves_like "manage processes announcements" @@ -24,9 +55,10 @@ let(:image2_filename) { "city2.jpeg" } let(:image2_path) { Decidim::Dev.asset(image2_filename) } + let(:attributes) { attributes_for(:participatory_process, organization:) } before do - click_link "New process" + click_on "New process" end %w(short_description description announcement).each do |field| @@ -35,34 +67,18 @@ it "creates a new participatory process" do within ".new_participatory_process" do - fill_in_i18n( - :participatory_process_title, - "#participatory_process-title-tabs", - en: "My participatory process", - es: "Mi proceso participativo", - ca: "El meu procés participatiu" - ) - fill_in_i18n( - :participatory_process_subtitle, - "#participatory_process-subtitle-tabs", - en: "Subtitle", - es: "Subtítulo", - ca: "Subtítol" - ) - fill_in_i18n_editor( - :participatory_process_short_description, - "#participatory_process-short_description-tabs", - en: "Short description", - es: "Descripción corta", - ca: "Descripció curta" - ) - fill_in_i18n_editor( - :participatory_process_description, - "#participatory_process-description-tabs", - en: "A longer description", - es: "Descripción más larga", - ca: "Descripció més llarga" - ) + fill_in_i18n(:participatory_process_title, "#participatory_process-title-tabs", **attributes[:title].except("machine_translations")) + fill_in_i18n(:participatory_process_subtitle, "#participatory_process-subtitle-tabs", **attributes[:subtitle].except("machine_translations")) + fill_in_i18n_editor(:participatory_process_short_description, "#participatory_process-short_description-tabs", **attributes[:short_description].except("machine_translations")) + fill_in_i18n_editor(:participatory_process_description, "#participatory_process-description-tabs", **attributes[:description].except("machine_translations")) + fill_in_i18n_editor(:participatory_process_announcement, "#participatory_process-announcement-tabs", **attributes[:announcement].except("machine_translations")) + + fill_in_i18n(:participatory_process_developer_group, "#participatory_process-developer_group-tabs", **attributes[:developer_group].except("machine_translations")) + fill_in_i18n(:participatory_process_local_area, "#participatory_process-local_area-tabs", **attributes[:local_area].except("machine_translations")) + fill_in_i18n(:participatory_process_meta_scope, "#participatory_process-meta_scope-tabs", **attributes[:meta_scope].except("machine_translations")) + fill_in_i18n(:participatory_process_target, "#participatory_process-target-tabs", **attributes[:target].except("machine_translations")) + fill_in_i18n(:participatory_process_participatory_scope, "#participatory_process-participatory_scope-tabs", **attributes[:participatory_scope].except("machine_translations")) + fill_in_i18n(:participatory_process_participatory_structure, "#participatory_process-participatory_structure-tabs", **attributes[:participatory_structure].except("machine_translations")) group_title = participatory_process_groups.first.title["en"] select group_title, from: :participatory_process_participatory_process_group_id @@ -73,7 +89,6 @@ end dynamically_attach_file(:participatory_process_hero_image, image1_path) - dynamically_attach_file(:participatory_process_banner_image, image2_path) within ".new_participatory_process" do find("*[type=submit]").click @@ -81,122 +96,42 @@ expect(page).to have_admin_callout("successfully") - within ".container" do + within "[data-content]" do expect(page).to have_current_path decidim_admin_participatory_processes.participatory_process_steps_path(Decidim::ParticipatoryProcess.last) expect(page).to have_content("Phases") expect(page).to have_content("Introduction") end - end - context "with emitter fields" do - it "creates a new participatory process" do - within ".new_participatory_process" do - fill_in_i18n( - :participatory_process_title, - "#participatory_process-title-tabs", - en: "My participatory process", - es: "Mi proceso participativo", - ca: "El meu procés participatiu" - ) - fill_in_i18n( - :participatory_process_subtitle, - "#participatory_process-subtitle-tabs", - en: "Subtitle", - es: "Subtítulo", - ca: "Subtítol" - ) - fill_in_i18n_editor( - :participatory_process_short_description, - "#participatory_process-short_description-tabs", - en: "Short description", - es: "Descripción corta", - ca: "Descripció curta" - ) - fill_in_i18n_editor( - :participatory_process_description, - "#participatory_process-description-tabs", - en: "A longer description", - es: "Descripción más larga", - ca: "Descripció més llarga" - ) - - group_title = participatory_process_groups.first.title["en"] - select group_title, from: :participatory_process_participatory_process_group_id - - fill_in :participatory_process_slug, with: "slug" - fill_in :participatory_process_hashtag, with: "#hashtag" - fill_in :participatory_process_weight, with: 1 - end - - dynamically_attach_file :participatory_process_emitter_image, image1_path - fill_in :participatory_process_emitter_name_image, with: "logo" - - dynamically_attach_file(:participatory_process_hero_image, image1_path) - dynamically_attach_file(:participatory_process_banner_image, image2_path) - - within ".new_participatory_process" do - find("*[type=submit]").click - end - - expect(page).to have_admin_callout("successfully") - end - - context "when creating a participatory process with emitter select" do - let!(:process1) { create(:participatory_process, :with_emitter, organization: organization) } - - it "creates a new participatory process" do - within ".new_participatory_process" do - fill_in_i18n( - :participatory_process_title, - "#participatory_process-title-tabs", - en: "My participatory process", - ca: "Mi proceso participativo" - ) - fill_in_i18n( - :participatory_process_subtitle, - "#participatory_process-subtitle-tabs", - en: "Subtitle", - ca: "Subtítulo" - ) - fill_in_i18n_editor( - :participatory_process_short_description, - "#participatory_process-short_description-tabs", - en: "Short description", - ca: "Descripción corta" - ) - fill_in_i18n_editor( - :participatory_process_description, - "#participatory_process-description-tabs", - en: "A longer description", - ca: "Descripción más larga" - ) - fill_in :participatory_process_slug, with: "slug" - fill_in :participatory_process_weight, with: 1 - end - select process1.emitter_name, from: "Select an emitter" - find("*[type=submit]").click - - expect(page).to have_admin_callout("successfully") - end - end + visit decidim_admin.root_path + expect(page).to have_content("created the #{translated(attributes[:title])} participatory process") end end context "when updating a participatory process" do - let!(:participatory_process3) { create(:participatory_process, organization: organization) } + let!(:participatory_process3) { create(:participatory_process, organization:) } before do visit decidim_admin_participatory_processes.participatory_processes_path end it "update a participatory process without images does not delete them" do - click_link translated(participatory_process3.title) - click_submenu_link "Info" - click_button "Update" + within "tr", text: translated(participatory_process3.title) do + click_on translated(participatory_process3.title) + end + + within_admin_sidebar_menu do + click_on "About this process" + end + + click_on "Update" expect(page).to have_admin_callout("successfully") - expect(page).to have_css("img[src*='#{participatory_process3.attached_uploader(:hero_image).path}']") - expect(page).to have_css("img[src*='#{participatory_process3.attached_uploader(:banner_image).path}']") + + hero_blob = participatory_process3.hero_image.blob + within %([data-active-uploads] [data-filename="#{hero_blob.filename}"]) do + src = page.find("img")["src"] + expect(src).to be_blob_url(hero_blob) + end end end end diff --git a/spec/system/participatory_processes_spec.rb b/spec/system/participatory_processes_spec.rb index 877499b..32149e0 100644 --- a/spec/system/participatory_processes_spec.rb +++ b/spec/system/participatory_processes_spec.rb @@ -3,22 +3,19 @@ require "spec_helper" require "decidim/core/test/shared_examples/has_contextual_help" -describe "Participatory Processes", type: :system do +describe "Participatory Processes" do # rubocop:disable RSpec/DescribeClass let(:organization) { create(:organization) } - let(:show_metrics) { true } - let(:show_statistics) { true } let(:hashtag) { true } let(:base_description) { { en: "Description", ca: "Descripció", es: "Descripción" } } let(:short_description) { { en: "Short description", ca: "Descripció curta", es: "Descripción corta" } } + let(:base_process) do create( :participatory_process, :active, - organization: organization, + organization:, description: base_description, - short_description: short_description, - show_metrics: show_metrics, - show_statistics: show_statistics + short_description: ) end @@ -33,10 +30,12 @@ end context "when there are no processes and accessing from the homepage" do + let!(:menu_content_block) { create(:content_block, organization:, manifest_name: :global_menu, scope_name: :homepage) } + it "does not show the menu link" do visit decidim.root_path - within ".main-nav" do + within "#home__menu" do expect(page).to have_no_content("Processes") end end @@ -50,7 +49,7 @@ context "when there are some processes and all are unpublished" do before do - create(:participatory_process, :unpublished, organization: organization) + create(:participatory_process, :unpublished, organization:) create(:participatory_process, :published) end @@ -61,10 +60,12 @@ end context "and accessing from the homepage" do + let!(:menu_content_block) { create(:content_block, organization:, manifest_name: :global_menu, scope_name: :homepage) } + it "the menu link is not shown" do visit decidim.root_path - within ".main-nav" do + within "#home__menu" do expect(page).to have_no_content("Processes") end end @@ -73,12 +74,12 @@ context "when there are some published processes" do let!(:participatory_process) { base_process } - let!(:promoted_process) { create(:participatory_process, :promoted, organization: organization) } - let!(:unpublished_process) { create(:participatory_process, :unpublished, organization: organization) } - let!(:past_process) { create :participatory_process, :past, organization: organization } - let!(:upcoming_process) { create :participatory_process, :upcoming, organization: organization } - let!(:grouped_process) { create :participatory_process, organization: organization } - let!(:group) { create :participatory_process_group, participatory_processes: [grouped_process], organization: organization } + let!(:promoted_process) { create(:participatory_process, :promoted, organization:) } + let!(:unpublished_process) { create(:participatory_process, :unpublished, organization:) } + let!(:past_process) { create(:participatory_process, :past, organization:) } + let!(:upcoming_process) { create(:participatory_process, :upcoming, organization:) } + let!(:grouped_process) { create(:participatory_process, organization:) } + let!(:group) { create(:participatory_process_group, participatory_processes: [grouped_process], organization:) } it_behaves_like "shows contextual help" do let(:index_path) { decidim_participatory_processes.participatory_processes_path } @@ -100,7 +101,7 @@ context "when no emitter" do it "doesn't displays logo or text" do within "#participatory_process_#{promoted_process.id}" do - expect(page).not_to have_css(".emitter-header") + expect(page).not_to have_css(".emitter") end end end @@ -111,18 +112,16 @@ :participatory_process, :active, :with_emitter, - organization: organization, + organization:, description: { en: "Description", ca: "Descripció", es: "Descripción" }, short_description: { en: "Short description", ca: "Descripció curta", es: "Descripción corta" }, - show_metrics: show_metrics, - show_statistics: show_statistics, developer_group: { en: "Developer group" } ) end it "displays logo and text" do within "#participatory_process_#{base_process.id}" do - within ".emitter-header" do + within ".card-data-header" do expect(page).to have_css("img", count: 1) expect(page).to have_content("Consultation published by Developer group") end @@ -132,12 +131,13 @@ end context "and accessing from the homepage" do + let!(:menu_content_block) { create(:content_block, organization:, manifest_name: :global_menu, scope_name: :homepage) } + it "the menu link is not shown" do visit decidim.root_path - within ".main-nav" do - expect(page).to have_content("Processes") - click_link "Processes" + within "#home__menu" do + click_on "Processes" end expect(page).to have_current_path decidim_participatory_processes.participatory_processes_path @@ -157,7 +157,7 @@ context "when no emitter" do it "doesn't displays logo or text" do within "#participatory_process_#{promoted_process.id}" do - expect(page).not_to have_css(".emitter-header") + expect(page).not_to have_css(".emitter") end end end @@ -168,229 +168,152 @@ :participatory_process, :active, :with_emitter, - organization: organization, + organization:, description: { en: "Description", ca: "Descripció", es: "Descripción" }, short_description: { en: "Short description", ca: "Descripció curta", es: "Descripción corta" }, - show_metrics: show_metrics, - show_statistics: show_statistics, developer_group: { en: "Developer group" } ) end it "displays logo and text" do within "#participatory_process_#{base_process.id}" do - within ".emitter-header" do + within ".card-data-header" do expect(page).to have_css("img", count: 1) expect(page).to have_content("Consultation published by Developer group") end end end end - - it "lists all the highlighted processes" do - within "#highlighted-processes" do - expect(page).to have_content(translated(promoted_process.title, locale: :en)) - expect(page).to have_selector(".card--full", count: 1) - end - end end - it "lists the active processes" do - within "#processes-grid" do - within "#processes-grid h3" do - expect(page).to have_content("3 ACTIVE PROCESSES") - end - - expect(page).to have_content(translated(participatory_process.title, locale: :en)) + it "lists all the highlighted processes" do + within "#highlighted-processes" do expect(page).to have_content(translated(promoted_process.title, locale: :en)) - expect(page).to have_content(translated(group.title, locale: :en)) - expect(page).to have_selector(".card", count: 3) - - expect(page).to have_no_content(translated(unpublished_process.title, locale: :en)) - expect(page).to have_no_content(translated(past_process.title, locale: :en)) - expect(page).to have_no_content(translated(upcoming_process.title, locale: :en)) - expect(page).to have_no_content(translated(grouped_process.title, locale: :en)) + expect(page).to have_css("[id^='participatory_process_highlight']", count: 1) end end + end - it "links to the individual process page" do - first(".card__link", text: translated(participatory_process.title, locale: :en)).click - - expect(page).to have_current_path decidim_participatory_processes.participatory_process_path(participatory_process) - end - - context "with active steps" do - let!(:step) { create(:participatory_process_step, participatory_process: participatory_process) } - let!(:active_step) do - create(:participatory_process_step, - :active, - participatory_process: participatory_process, - title: { en: "Active step", ca: "Fase activa", es: "Fase activa" }) + it "lists the active processes" do + within "#processes-grid" do + within "#processes-grid h2" do + expect(page).to have_content("3 active processes") end - it "links to the active step" do - visit decidim_participatory_processes.participatory_processes_path + expect(page).to have_content(translated(participatory_process.title, locale: :en)) + expect(page).to have_content(translated(promoted_process.title, locale: :en)) + expect(page).to have_content(translated(group.title, locale: :en)) + expect(page).to have_css("a.card__grid", count: 3) - within find("#processes-grid .column", text: translated(participatory_process.title)) do - within ".card__footer" do - expect(page).to have_content("Current phase:\nActive step") - end - end - end - - context "when the active step has CTA text and url set" do - let(:cta_path) { "my_path" } - let(:cta_text) { { en: "Take action!", ca: "Take action!", es: "Take action!" } } - - before do - active_step.update!(cta_path: cta_path, cta_text: cta_text) - end - - it "shows a CTA button" do - visit decidim_participatory_processes.participatory_processes_path - - within "#participatory_process_#{participatory_process.id}" do - expect(page).to have_link("Take action!") - end - end - - context "when cta_text is empty in current locale" do - let(:cta_text) { { en: "", ca: "Take action!", es: "Take action!" } } - - it "displays the regular cta button" do - visit decidim_participatory_processes.participatory_processes_path + expect(page).to have_no_content(translated(unpublished_process.title, locale: :en)) + expect(page).to have_no_content(translated(past_process.title, locale: :en)) + expect(page).to have_no_content(translated(upcoming_process.title, locale: :en)) + expect(page).to have_no_content(translated(grouped_process.title, locale: :en)) + end + end - within "#participatory_process_#{participatory_process.id}" do - expect(page).not_to have_link("Take action!") - expect(page).to have_link("More info") - end - end - end + it "links to the individual process page" do + first(".card__grid h3", text: translated(participatory_process.title, locale: :en)).click - context "when process is promoted" do - let(:cta_text) { { en: "Take promoted action!", ca: "Take promoted action!", es: "Take promoted action!" } } - let!(:active_step) do - create(:participatory_process_step, - :active, - participatory_process: promoted_process, - title: { en: "Active step", ca: "Fase activa", es: "Fase activa" }) - end - - it "shows a CTA button" do - visit decidim_participatory_processes.participatory_processes_path + expect(page).to have_current_path decidim_participatory_processes.participatory_process_path(participatory_process) + end - within "#highlighted-processes" do - expect(page).to have_link("Take promoted action!") - end - end - end + context "with active steps" do + let!(:step) { create(:participatory_process_step, participatory_process:) } + let!(:active_step) do + create(:participatory_process_step, + :active, + participatory_process:, + title: { en: "Active step", ca: "Fase activa", es: "Fase activa" }) + end - context "when user switch locale" do - before do - visit decidim_participatory_processes.participatory_processes_path - within_language_menu do - click_link "Català" - end - end + it "links to the active step" do + visit decidim_participatory_processes.participatory_processes_path - it "displays the regular cta button" do - within "#participatory_process_#{participatory_process.id}" do - expect(page).to have_link("Take action!", href: "/processes/#{participatory_process.slug}/my_path") - end - end + within "#processes-grid .card__grid", text: translated(participatory_process.title) do + within ".card__grid-metadata" do + expect(page).to have_content("Active step") end end end + end - context "when there are promoted participatory process groups" do - let!(:promoted_group) { create(:participatory_process_group, :promoted, :with_participatory_processes, organization: organization) } - let(:promoted_items_titles) { page.all("#highlighted-processes .card__title").map(&:text) } + context "when there are promoted participatory process groups" do + let!(:promoted_group) { create(:participatory_process_group, :promoted, :with_participatory_processes, organization:) } + let(:promoted_items_titles) { page.all("#highlighted-processes .h3").map(&:text) } - before do - promoted_group.title["en"] = "D'Artagnan #{promoted_group.title["en"]}" - promoted_group.save! - visit decidim_participatory_processes.participatory_processes_path - end + before do + promoted_group.title["en"] = "D'Artagnan #{promoted_group.title["en"]}" + promoted_group.save! + visit decidim_participatory_processes.participatory_processes_path + end - it "shows a highligted processes section" do - expect(page).to have_content("HIGHLIGHTED PROCESSES") - end + it "shows a highlighted processes section" do + expect(page).to have_content("Highlighted processes") + end - it "lists only promoted groups" do - expect(promoted_items_titles).to include(translated(promoted_group.title, locale: :en)) - expect(promoted_items_titles).not_to include(translated(group.title, locale: :en)) - end + it "lists only promoted groups" do + expect(promoted_items_titles).to include(translated(promoted_group.title, locale: :en)) + expect(promoted_items_titles).not_to include(translated(group.title, locale: :en)) + end - it "lists all the highlighted process groups" do - within "#highlighted-processes" do - expect(page).to have_content(translated(promoted_group.title, locale: :en)) - expect(page).to have_selector(".card--full", count: 2) - end + it "lists all the highlighted process groups" do + within "#highlighted-processes" do + expect(page).to have_content(translated(promoted_group.title, locale: :en)) + expect(page).to have_css("[id^='participatory_process_highlight']", count: 1) + expect(page).to have_css("[id^='participatory_process_group_highlight']", count: 1) end + end + end + end + end - context "and promoted group has defined a CTA content block" do - let(:cta_settings) do - { - button_url: "https://example.org/action", - button_text_en: "cta text", - description_en: "cta description" - } - end + it_behaves_like "followable content for users" do + let!(:participatory_process) { base_process } + let!(:user) { create(:user, :confirmed, organization:) } + let(:followable) { participatory_process } + let(:followable_path) { decidim_participatory_processes.participatory_process_path(participatory_process) } + end - before do - create( - :content_block, - organization: organization, - scope_name: :participatory_process_group_homepage, - scoped_resource_id: promoted_group.id, - manifest_name: :cta, - settings: cta_settings - ) - visit decidim_participatory_processes.participatory_processes_path - end + context "when going to the participatory process page" do + let!(:participatory_process) { base_process } + let!(:proposals_component) { create(:component, :published, participatory_space: participatory_process, manifest_name: :proposals) } + let!(:meetings_component) { create(:component, :unpublished, participatory_space: participatory_process, manifest_name: :meetings) } - it "shows a CTA button inside group card" do - within("#highlighted-processes") do - expect(page).to have_link(cta_settings[:button_text_en], href: cta_settings[:button_url]) - end - end + before do + create_list(:proposal, 3, component: proposals_component) + allow(Decidim).to receive(:component_manifests).and_return([proposals_component.manifest, meetings_component.manifest]) + end - context "and promoted group belongs to another organization" do - let!(:promoted_group) { create(:participatory_process_group, :promoted, :with_participatory_processes) } + describe "page title" do + it "has the participatory process title in the show page" do + visit decidim_participatory_processes.participatory_process_path(participatory_process) - it "shows a CTA button inside group card" do - within("#highlighted-processes") do - expect(page).not_to have_link(cta_settings[:button_text_en], href: cta_settings[:button_url]) - end - end - end - end - end + expect(page).to have_title("#{translated(participatory_process.title)} - #{translated(organization.name)}") end end - context "when going to the participatory process page" do - let!(:participatory_process) { base_process } - let!(:proposals_component) { create(:component, :published, participatory_space: participatory_process, manifest_name: :proposals) } - let!(:meetings_component) { create(:component, :unpublished, participatory_space: participatory_process, manifest_name: :meetings) } + it_behaves_like "editable content for admins" do + let(:target_path) { decidim_participatory_processes.participatory_process_path(participatory_process) } + end + + context "when requesting the participatory process path" do + let(:blocks_manifests) { [] } before do - create_list(:proposal, 3, component: proposals_component) - allow(Decidim).to receive(:component_manifests).and_return([proposals_component.manifest, meetings_component.manifest]) + blocks_manifests.each do |manifest_name| + create(:content_block, organization:, scope_name: :participatory_process_homepage, manifest_name:, scoped_resource_id: participatory_process.id) + end + visit decidim_participatory_processes.participatory_process_path(participatory_process) end - it_behaves_like "editable content for admins" do - let(:target_path) { decidim_participatory_processes.participatory_process_path(participatory_process) } - end + context "when requesting the process path" do + context "when hero, main_data and phase and duration blocks are enabled" do + let(:blocks_manifests) { [:hero, :main_data, :extra_data, :metadata] } - context "when requesting the participatory process path" do - before do - visit decidim_participatory_processes.participatory_process_path(participatory_process) - end - - context "when requesting the process path" do it "shows the details of the given process" do - within "main" do + within "[data-content]" do + expect(page).to have_content("About this process") expect(page).to have_content(translated(participatory_process.title, locale: :en)) expect(page).to have_content(translated(participatory_process.subtitle, locale: :en)) expect(page).to have_content(translated(participatory_process.description, locale: :en)) @@ -401,12 +324,20 @@ expect(page).to have_content(translated(participatory_process.target, locale: :en)) expect(page).to have_content(translated(participatory_process.participatory_scope, locale: :en)) expect(page).to have_content(translated(participatory_process.participatory_structure, locale: :en)) - expect(page).to have_content(I18n.l(participatory_process.end_date, format: :long)) + expect(page).to have_content(I18n.l(participatory_process.start_date, format: :decidim_short_with_month_name_short)) + expect(page).to have_content(I18n.l(participatory_process.end_date, format: :decidim_short_with_month_name_short)) expect(page).to have_content(participatory_process.hashtag) end end - it_behaves_like "has attachments" do + it_behaves_like "has embedded video in description", :base_description + it_behaves_like "has embedded video in description", :short_description + end + + context "when attachments blocks enabled" do + let(:blocks_manifests) { [:related_documents, :related_images] } + + it_behaves_like "has attachments content blocks" do let(:attached_to) { participatory_process } end @@ -414,148 +345,143 @@ let(:attached_to) { participatory_process } let(:collection_for) { participatory_process } end + end - context "and it belongs to a group" do - let!(:group) { create :participatory_process_group, participatory_processes: [participatory_process], organization: organization } + context "and it belongs to a group" do + let!(:group) { create(:participatory_process_group, participatory_processes: [participatory_process], organization:) } + let(:blocks_manifests) { [:extra_data] } - it "has a link to the group the process belongs to" do - visit decidim_participatory_processes.participatory_process_path(participatory_process) + it "has a link to the group the process belongs to" do + visit decidim_participatory_processes.participatory_process_path(participatory_process) - expect(page).to have_link(translated(group.title, locale: :en), href: decidim_participatory_processes.participatory_process_group_path(group)) - end + expect(page).to have_link(translated(group.title, locale: :en), href: decidim_participatory_processes.participatory_process_group_path(group)) end + end - context "when it has some linked processes" do - let(:published_process) { create :participatory_process, :published, organization: organization } - let(:unpublished_process) { create :participatory_process, :unpublished, organization: organization } - - it "only shows the published linked processes" do - participatory_process - .link_participatory_space_resources( - [published_process, unpublished_process], - "related_processes" - ) - visit decidim_participatory_processes.participatory_process_path(participatory_process) - expect(page).to have_content(translated(published_process.title)) - expect(page).to have_no_content(translated(unpublished_process.title)) - end + context "when it has some linked processes" do + let(:published_process) { create(:participatory_process, :published, organization:) } + let(:unpublished_process) { create(:participatory_process, :unpublished, organization:) } + let(:blocks_manifests) { [:related_processes] } + + it "only shows the published linked processes" do + participatory_process + .link_participatory_space_resources( + [published_process, unpublished_process], + "related_processes" + ) + visit decidim_participatory_processes.participatory_process_path(participatory_process) + expect(page).to have_content(translated(published_process.title)) + expect(page).to have_no_content(translated(unpublished_process.title)) end + end - context "and the process has some components" do - it "shows the components" do - within ".process-nav" do - expect(page).to have_content(translated(proposals_component.name, locale: :en).upcase) - expect(page).to have_no_content(translated(meetings_component.name, locale: :en).upcase) - end - end + context "and the process has some components" do + let(:blocks_manifests) { [:main_data] } - context "and the process metrics are enabled" do - let(:organization) { create(:organization) } - let(:metrics) do - Decidim.metrics_registry.filtered(highlight: true, scope: "participatory_process").each do |metric_registry| - create(:metric, metric_type: metric_registry.metric_name, day: Time.zone.today - 1.week, organization: organization, participatory_space_type: Decidim::ParticipatoryProcess.name, participatory_space_id: participatory_process.id, cumulative: 5, quantity: 2) - end - end + it "shows the components" do + within ".participatory-space__nav-container" do + expect(page).to have_content(translated(proposals_component.name, locale: :en)) + expect(page).to have_no_content(translated(meetings_component.name, locale: :en)) + end + end - before do - metrics - visit current_path + context "and the process metrics are enabled" do + let(:organization) { create(:organization) } + let(:metrics) do + Decidim.metrics_registry.filtered(highlight: true, scope: "participatory_process").each do |metric_registry| + create(:metric, metric_type: metric_registry.metric_name, day: Time.zone.today - 1.week, organization:, participatory_space_type: Decidim::ParticipatoryProcess.name, participatory_space_id: participatory_process.id, cumulative: 5, quantity: 2) end + end + let(:blocks_manifests) { [:metrics] } - it "shows the metrics charts" do - expect(page).to have_css("h3.section-heading", text: "METRICS") + before do + metrics + visit current_path + end - within "#metrics" do - expect(page).to have_css("input#metrics-space_type[value='Decidim::ParticipatoryProcess']", visible: :hidden) - expect(page).to have_css("input#metrics-space_id[value='#{participatory_process.id}']", visible: :hidden) - Decidim.metrics_registry.filtered(highlight: true, scope: "participatory_process").each do |metric_registry| - expect(page).to have_css(%(##{metric_registry.metric_name}_chart)) - end - end - end + it "shows the metrics charts" do + expect(page).to have_css("h2.h2", text: "Metrics") - it "renders a link to all metrics" do - within "#metrics" do - expect(page).to have_link("Show all metrics") + within "[data-metrics]" do + Decidim.metrics_registry.filtered(highlight: true, scope: "participatory_process").each do |metric_registry| + expect(page).to have_css(%(##{metric_registry.metric_name}_chart)) end end + end - it "click link" do - click_link("Show all metrics") - have_current_path(decidim_participatory_processes.all_metrics_participatory_process_path(participatory_process)) + it "renders a link to all metrics" do + within "[data-metrics]" do + expect(page).to have_link("Show all") end end - context "and the process statistics are enabled" do - let(:show_statistics) { true } - - it "the stats for those components are visible" do - within ".section-statistics" do - expect(page).to have_css("h3.section-heading", text: "STATISTICS") - expect(page).to have_css(".statistic__title", text: "PROPOSALS") - expect(page).to have_css(".statistic__number", text: "3") - expect(page).to have_no_css(".statistic__title", text: "MEETINGS") - expect(page).to have_no_css(".statistic__number", text: "0") - end - end + it "click link" do # rubocop:disable RSpec/NoExpectationExample + click_on("Show all") + have_current_path(decidim_participatory_processes.all_metrics_participatory_process_path(participatory_process)) end + end - context "and the process statistics are not enabled" do - let(:show_statistics) { false } + context "and the process statistics are enabled" do + let(:blocks_manifests) { [:hero, :stats] } - it "the stats for those components are not visible" do - expect(page).to have_no_css("h3.section-heading", text: "STATISTICS") - expect(page).to have_no_css(".statistic__title", text: "PROPOSALS") - expect(page).to have_no_css(".statistic__number", text: "3") - end + it "the stats for those components are visible" do + expect(page).to have_css("[data-statistic]", count: 3) end - context "and the process metrics are not enabled" do - let(:show_metrics) { false } + it_behaves_like "accessible page" + end - it "the metrics for the participatory processes are not rendered" do - expect(page).to have_no_css("h4.section-heading", text: "METRICS") - end + context "and the process statistics are not enabled" do + let(:blocks_manifests) { [] } - it "has no link to all metrics" do - expect(page).to have_no_link("Show all metrics") - end + it "the stats for those components are not visible" do + expect(page).to have_no_css("[data-statistics]", count: 3) + expect(page).to have_no_css(".statistic__title", text: "Proposals") + expect(page).to have_no_css(".statistic__number", text: "3") end + end - context "and the process doesn't have hashtag" do - let(:hashtag) { false } + context "and the process metrics are not enabled" do + it "the metrics for the participatory processes are not rendered" do + expect(page).to have_no_css("h4", text: "METRICS") + end - it "the hashtags for those components are not visible" do - expect(page).to have_no_content("#") - end + it "has no link to all metrics" do + expect(page).to have_no_link("Show all metrics") end end - context "when assemblies are linked to participatory process" do - let!(:published_assembly) { create(:assembly, :published, organization: organization) } - let!(:unpublished_assembly) { create(:assembly, :unpublished, organization: organization) } - let!(:private_assembly) { create(:assembly, :published, :private, :opaque, organization: organization) } - let!(:transparent_assembly) { create(:assembly, :published, :private, :transparent, organization: organization) } + context "and the process does not have hashtag" do + let(:hashtag) { false } - before do - published_assembly.link_participatory_space_resources(participatory_process, "included_participatory_processes") - unpublished_assembly.link_participatory_space_resources(participatory_process, "included_participatory_processes") - private_assembly.link_participatory_space_resources(participatory_process, "included_participatory_processes") - transparent_assembly.link_participatory_space_resources(participatory_process, "included_participatory_processes") - visit decidim_participatory_processes.participatory_process_path(participatory_process) + it "the hashtags for those components are not visible" do + expect(page).to have_no_content("#") end + end + end - it "display related assemblies" do - expect(page).to have_content("RELATED ASSEMBLIES") - expect(page).to have_content(translated(published_assembly.title)) - expect(page).to have_content(translated(transparent_assembly.title)) - expect(page).to have_no_content(translated(unpublished_assembly.title)) - expect(page).to have_no_content(translated(private_assembly.title)) - end + context "when assemblies are linked to participatory process" do + let!(:published_assembly) { create(:assembly, :published, organization:) } + let!(:unpublished_assembly) { create(:assembly, :unpublished, organization:) } + let!(:private_assembly) { create(:assembly, :published, :private, :opaque, organization:) } + let!(:transparent_assembly) { create(:assembly, :published, :private, :transparent, organization:) } + let(:blocks_manifests) { [:related_assemblies] } + + before do + published_assembly.link_participatory_space_resources(participatory_process, "included_participatory_processes") + unpublished_assembly.link_participatory_space_resources(participatory_process, "included_participatory_processes") + private_assembly.link_participatory_space_resources(participatory_process, "included_participatory_processes") + transparent_assembly.link_participatory_space_resources(participatory_process, "included_participatory_processes") + visit decidim_participatory_processes.participatory_process_path(participatory_process) end - it_behaves_like "has embedded video in description", :base_description - it_behaves_like "has embedded video in description", :short_description + it "display related assemblies" do + expect(page).to have_content("Related assemblies") + expect(page).to have_content(translated(published_assembly.title)) + expect(page).to have_content(translated(transparent_assembly.title)) + expect(page).to have_no_content(translated(unpublished_assembly.title)) + expect(page).to have_no_content(translated(private_assembly.title)) + end end end end