Files with spaces in names from Biomodels repos get copied into workspace with + instead of space

[pgleeson]

e.g. try https://v2.opensourcebrain.org/repositories/3325

Files look fine in repo view:

but when copied into workspace:

[pgleeson]

This doesn't seem to be an issue with GitHub based repos, i.e. spaces in filenames are preserved fine.

@sanjayankur31 do you know where in the code the file copy happens?

[sanjayankur31]

It's done here:

OSBv2/applications/workspaces/tasks/biomodels-copy/run.sh

Line 28 in 45825f4

for path in $paths; do

I don't see us doing any replacements in the script there ourselves, so it's possible that the biomodels API perhaps returns the modified file names. I'll check tomorrow.

[sanjayankur31]

This is something server side. For example, if one tries this URL to download a file:

https://www.ebi.ac.uk/biomodels/model/download/BIOMD0000001031?filename=Al-Tuwairqi2020 - Phase I virotherapy.xml

you'll get the file with the spaces replaced by "+". Since this is how biomodels wants to do it, we should probably leave it as is.