Make sure thumbnails can never block the rendering of the whole grid #99
Comments
|
Duplicate of #96 |
|
Seems to happen on Wikimedia PAWS too. For some users. Not for me, it works fine when I try |
This will let the next cell renderers attempt to render the cell instead of aborting the rendering of the entire grid. For OpenRefine/CommonsExtension#99.
|
This issue would still be worth solving in the Commons extension but to mitigate the problem, I am proposing a change in OpenRefine to avoid the problem from blocking the rendering of the whole grid (which I should have thought about when I introduced the extension point…) Hopefully we can include this in 3.8, meaning that people would be able to use the existing Commons extension with 3.8 and it wouldn't crash like that (instead, certain cells wouldn't be rendered as thumbnails but OpenRefine would still remain usable). |
This will let the next cell renderers attempt to render the cell instead of aborting the rendering of the entire grid. For OpenRefine/CommonsExtension#99.
This will let the next cell renderers attempt to render the cell instead of aborting the rendering of the entire grid. For OpenRefine/CommonsExtension#99.
Shouldn't either issue be closed in that case? Not sure which one since this one is referenced in other places, but the other has more discussion. |
In some circumstances the code that renders thumbnails into cells can fail and that will abort the rendering of the entire grid.
See this forum post for instance: https://forum.openrefine.org/t/openrefine-3-7-9-released/1259/9?u=antonin_d
We should make sure that any exception thrown in our cell renderer is caught appropriately and a fallback is used, so that the rest of the grid is still rendered.
This safety mechanism should also be implemented on OpenRefine's side of the extension point.
The text was updated successfully, but these errors were encountered: