Draft: Migrate Gameplay Tags from INI Files into Native Gameplay Tags #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
This organizes all the OpenPF2-related tags under "PF2" tag categories so that they don't clash with anything in a game that's using OpenPF2. This change also adds descriptions to all tag categories.
This was identical to `FGameplayTag::RequestGameplayTag()` in the `FName` case, and not that much extra effort to invoke `FName()` ourselves in the `FString` case, so it doesn't make sense for this to exist.
...as `ContainerHasTag()`. This makes more sense with the other tag-related utility methods in the library. We're also able to expose it to Blueprint, as long as we take in a const reference instead of a pointer.
This makes assembling a gameplay tag from a root tag and suffix name more efficient by using a `NameBuilder` for this instead of concatenation.
Previously, if a damage type passed in was not a recognized damage type, the damage callout would report `-999` as the damage. Now, it merely renders the proper damage amount in black text.
GuyPaddock
force-pushed
the
feature/issue-60--migrate-tags-to-cpp
branch
from
b9c834d to
7adc4e1
Compare
This makes the code less fragile if tags get renamed in the future, since the tag names no longer appear in the code as strings. If the variable name is wrong, it will fail to build, rather than it being a run-time error.
GuyPaddock
force-pushed
the
feature/issue-60--migrate-tags-to-cpp
branch
from
7adc4e1 to
9d9db8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.