Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add initial GUI test #94

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

test: add initial GUI test #94

wants to merge 14 commits into from

Conversation

jcharkow
Copy link

@jcharkow jcharkow commented Nov 13, 2024 •
edited
Loading

Add GUI tests - See notes below

@jcharkow
test: add initial GUI test
a47e05e 
just test for launching each page and ensuring there is not an
exception. Currenly having trouble with quickstart.

Also add documentation specific tests
@jcharkow
add test_file_upload
97a4126
@jcharkow
add vim tmp files to .gitignore
a188904
@jcharkow
progress add view tests
87e82c5
@jcharkow
Merge branch 'main' into add_tests
b035ac1
@jcharkow
add more specific tests for run_workflow
99c30a6 
fix tests for view_ms_raw_data and file_upload
@jcharkow
add ci test with gh actions
e1cc1db
@jcharkow
fix ci file
31f9a55
@jcharkow
add pytest to ci file
bfaa0d4
@jcharkow
Copy link
Author

This is now ready for review. It seems that the ci.yml test is only shown on my personal branch but all the tests seem to pass. It is not extensive testing as extensive testing with a GUI is difficult but it is something.

@jcharkow jcharkow marked this pull request as ready for review December 11, 2024 13:34
@jcharkow
Copy link
Author

TODO: Extend tests to TOPP tools

@jcharkow
test: update run workflow test
dfdd384
@jcharkow
test: add comment to spectrum visualization
db3be5b 
note currently spectrum visualization is not tested because cannot find
a way to select a spectrum to be displayed.
@jcharkow
test: try to add spectrum plot test
86f01df
@jcharkow
Merge branch 'main' into add_tests
57a4343
@jcharkow
Copy link
Author

Notes:

  1. Double check I did not mess up captcha with merge conflicts
  2. Testing framework is only limited to the pyopenms table for now. Plan to add TOPP tests in the future
  3. Testing framework in streamlit is not as extensive as main streamlit app. Difficult to test everything programmatically.

@jcharkow
test: fix bugs
fc80ccd 
bugs in testing framework caused tests to fail, fix this
@jcharkow
Copy link
Author

note there is also a test.py file with tests Axel added.

@jcharkow jcharkow requested a review from t0mdavid-m January 22, 2025 23:23
@jcharkow jcharkow linked an issue Jan 22, 2025 that may be closed by this pull request
WebApps: CI Testing #88
Open
@jcharkow
Copy link
Author

Move test.py and test_gui.py to same folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0mdavid-m t0mdavid-m Awaiting requested review from t0mdavid-m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebApps: CI Testing
1 participant
@jcharkow