feat(drivers): add Xiaomi Cloud Dirve #1391

antecanis8 · 2025-09-29T18:31:35Z

还没写完

已经实现:
list
link
put
mkdir

目前存在的问题:
大文件获取到的下载链接过长无法下载
从api获取到的分块下载地址是否能用
部分api还是旧版是否需要都更换为v2
获取存储详情和移动文件还未实现
目前只做了302代理的下载本机代理未实现
新增的依赖是否可以精简

Description / 描述

小米云盘驱动😎

Motivation and Context / 背景

为什么一直没人做🧐
api参考 github.com/wangbjun/go-micloud

How Has This Been Tested? / 测试

Checklist / 检查清单

I have read the CONTRIBUTING document.
我已阅读 CONTRIBUTING 文档。
I have formatted my code with go fmt or prettier.
我已使用 go fmt 或 prettier 格式化提交的代码。
I have added appropriate labels to this PR (or mentioned needed labels in the description if lacking permissions).
我已为此 PR 添加了适当的标签（如无权限或需要的标签不存在，请在描述中说明，管理员将后续处理）。
I have requested review from relevant code authors using the "Request review" feature when applicable.
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
I have updated the repository accordingly (If it’s needed).
我已相应更新了相关仓库（若适用）。
- OpenList-Frontend #XXXX
- OpenList-Docs #XXXX

目前存在的问题: 大文件获取到的下载链接过长无法下载从api获取到的分块下载地址是否能用部分api还是旧版是否需要都更换为v2 获取存储详情和移动文件还未实现目前只做了302代理的下载本机代理未实现新增的依赖是否可以精简

Copilot

Pull Request Overview

This PR implements a new Xiaomi Cloud Drive driver for the OpenList project. The implementation supports file listing, downloading, uploading, and folder management through Xiaomi Cloud's API.

Adds complete MiCloud driver with authentication, file operations, and upload/download functionality
Implements automatic token renewal to maintain session validity
Provides file streaming, folder creation, and deletion capabilities

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
go.mod	Adds gjson library dependencies for JSON parsing
drivers/micloud/util.go	Core API client implementation with HTTP operations and file management
drivers/micloud/types.go	Data structures and API endpoints for MiCloud integration
drivers/micloud/meta.go	Driver configuration and registration setup
drivers/micloud/driver.go	Main driver interface implementation with OpenList integration
drivers/all.go	Registers the new MiCloud driver in the system

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-30T04:51:36Z

drivers/micloud/util.go

+				}
+				// 若服务端下发新 cookie，则更新
+				c.updateCookiesFromResponse(resp)
+				io.Copy(io.Discard, resp.Body)


The error from io.Copy is ignored, which could mask potential issues. Consider logging or handling the error appropriately.

Copilot · 2025-09-30T04:51:36Z

drivers/micloud/util.go

+		return nil, 0, err
+	}
+	buf = buf[:n]
+	req, _ := http.NewRequest("POST", uploadURL, strings.NewReader(string(buf)))


Error from http.NewRequest is ignored using blank identifier. This could cause unexpected behavior if the request creation fails.

Suggested change

req, _ := http.NewRequest("POST", uploadURL, strings.NewReader(string(buf)))

req, err := http.NewRequest("POST", uploadURL, strings.NewReader(string(buf)))

if err != nil {

return nil, 0, err

}

Copilot · 2025-09-30T04:51:36Z

drivers/micloud/util.go

+		return nil, 0, err
+	}
+	defer resp.Body.Close()
+	body, _ := io.ReadAll(resp.Body)


Error from io.ReadAll is ignored using blank identifier. This could lead to incomplete data being processed without notification.

Suggested change

body, _ := io.ReadAll(resp.Body)

body, err := io.ReadAll(resp.Body)

if err != nil {

return nil, 0, fmt.Errorf("failed to read response body: %w", err)

}

Copilot · 2025-09-30T04:51:37Z

drivers/micloud/types.go

+// 由于json包在类型定义中没有直接使用，但可能在方法中需要，我们保留它
+// 实际上json包在MiCloudClient的实现中使用了，所以保留


These comments are outdated and confusing since no json package is imported in this file. The comments should be removed or clarified.

Suggested change

// 由于json包在类型定义中没有直接使用，但可能在方法中需要，我们保留它

// 实际上json包在MiCloudClient的实现中使用了，所以保留

Copilot · 2025-09-30T04:51:37Z

drivers/micloud/util.go

+// 直链下载已使用 v2 接口实现，去除 JSONP 下载方式
+
+// GetFileDownLoadUrl 获取文件下载URL


This comment appears to be a placeholder or outdated note that doesn't describe the following function. It should be removed or updated to properly document the GetFileDownLoadUrl function.

Suggested change

// 直链下载已使用 v2 接口实现，去除 JSONP 下载方式

// GetFileDownLoadUrl 获取文件下载URL

// GetFileDownLoadUrl 获取指定文件的直链下载URL。

//

// 参数 fileId 为文件的唯一标识符。该方法使用 v2 接口获取文件的直链下载地址，

// 并已去除旧的 JSONP 下载方式。返回下载URL字符串和可能的错误信息。

Copilot · 2025-09-30T04:51:37Z

drivers/micloud/util.go

+	return dl, nil
+}
+
+// JSONP 下载信息方法已废弃


This standalone comment doesn't provide context and appears to be leftover from code refactoring. It should be removed.

Suggested change

// JSONP 下载信息方法已废弃

Copilot · 2025-09-30T04:51:37Z

drivers/micloud/util.go

+}
+
+// 上传小文件（小于4MB）
+// uploadSmallFile/uploadLargeFile paths were deprecated and removed. The unified Upload handles both cases.


These orphaned comments don't document any actual code and appear to be leftover from refactoring. They should be removed.

Suggested change

// uploadSmallFile/uploadLargeFile paths were deprecated and removed. The unified Upload handles both cases.

PIKACHUIM · 2025-10-14T06:10:58Z

什么？小米有云盘？

ljcbaby · 2025-10-14T08:08:57Z

什么？小米有云盘？

有，云服务里的，纯云盘，没有分享之类的能力

antecanis8 · 2025-10-15T23:02:28Z

目前小米云盘的网页使用jsonp方式跨域获取下载地址电脑客户端直接获取直链下载地址和分块下载地址 4MB一个块

下载地址需要接受一个meta作为校验当要下载的文件较小时 meta可以作为get请求的参数当要下载的文件很大时 meta会超出 get请求的 URL 长度限制必须作为post请求的表单

对于795MB的文件 meta有34.8KB
对于113KB的文件 meta有267字节
对于22MB的文件 meta有1.13KB

总结：小文件才能使用302下载大文件必须代理

ljcbaby · 2025-10-16T00:03:10Z

那就直接全部使用代理吧，这样可以保证功能一致性

ILoveScratch2 requested a review from Copilot September 30, 2025 04:50

Copilot AI reviewed Sep 30, 2025

View reviewed changes

-	body, _ := io.ReadAll(resp.Body)
+	body, err := io.ReadAll(resp.Body)
+	if err != nil {
+		return nil, 0, fmt.Errorf("failed to read response body: %w", err)
+	}

		// 由于json包在类型定义中没有直接使用，但可能在方法中需要，我们保留它
		// 实际上json包在MiCloudClient的实现中使用了，所以保留

		// 直链下载已使用 v2 接口实现，去除 JSONP 下载方式

		// GetFileDownLoadUrl 获取文件下载URL

-// 直链下载已使用 v2 接口实现，去除 JSONP 下载方式
-// GetFileDownLoadUrl 获取文件下载URL
+// GetFileDownLoadUrl 获取指定文件的直链下载URL。
+//
+// 参数 fileId 为文件的唯一标识符。该方法使用 v2 接口获取文件的直链下载地址，
+// 并已去除旧的 JSONP 下载方式。返回下载URL字符串和可能的错误信息。

Uh oh!

feat(drivers): add Xiaomi Cloud Dirve #1391

Are you sure you want to change the base?

feat(drivers): add Xiaomi Cloud Dirve #1391

Uh oh!

Conversation

antecanis8 commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description / 描述

Motivation and Context / 背景

How Has This Been Tested? / 测试

Checklist / 检查清单

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

PIKACHUIM commented Oct 14, 2025

Uh oh!

ljcbaby commented Oct 14, 2025

Uh oh!

antecanis8 commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ljcbaby commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

antecanis8 commented Sep 29, 2025 •

edited

Loading

antecanis8 commented Oct 15, 2025 •

edited

Loading