Skip to content
This repository has been archived by the owner on Mar 7, 2020. It is now read-only.

Encoder Support #9

Open
kdavisk6 opened this issue Aug 16, 2018 · 3 comments
Open

Encoder Support #9

kdavisk6 opened this issue Aug 16, 2018 · 3 comments
Labels
API

Comments

@kdavisk6
Copy link
Member

Add support for Encoders during the request phase.
@kptfh
Copy link
Collaborator

kptfh commented Aug 17, 2018

Do you mean feign.codec.Encoder ?

@kdavisk6
Copy link
Member Author

Yes.

@kptfh
Copy link
Collaborator

kptfh commented Aug 17, 2018

feign.codec.Encoder doesn't meant for reactive encoding.
I suggest that exact implementation of ReactiveHttpClient should implement encoding/decoding.
In case of implementation based on Spring WebClient I don't need encoding/decoding as Spring takes full responsibility.

@velo velo added the API label Aug 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@velo @kdavisk6 @kptfh