Fix phpstan issues

Prior to this change, the latest phpstan made the pipeline red.

This change addresses the issues.

Author: johanib

ci/qa/phpstan-baseline.neon

@@ -24,42 +24,6 @@ parameters:
 			count: 5
 			path: ../../src/DependencyInjection/Configuration.php
 
-		-
-			message: '#^Method Surfnet\\SamlBundle\\DependencyInjection\\Configuration\:\:addHostedSection\(\) has parameter \$node with generic class Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition but does not specify its types\: TParent$#'
-			identifier: missingType.generics
-			count: 1
-			path: ../../src/DependencyInjection/Configuration.php
-
-		-
-			message: '#^Method Surfnet\\SamlBundle\\DependencyInjection\\Configuration\:\:addRemoteIdentityProviderConfiguration\(\) has parameter \$arrayNode with generic class Symfony\\Component\\Config\\Definition\\Builder\\NodeBuilder but does not specify its types\: TParent$#'
-			identifier: missingType.generics
-			count: 1
-			path: ../../src/DependencyInjection/Configuration.php
-
-		-
-			message: '#^Method Surfnet\\SamlBundle\\DependencyInjection\\Configuration\:\:addRemoteIdentityProviderSection\(\) has parameter \$remoteNode with generic class Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition but does not specify its types\: TParent$#'
-			identifier: missingType.generics
-			count: 1
-			path: ../../src/DependencyInjection/Configuration.php
-
-		-
-			message: '#^Method Surfnet\\SamlBundle\\DependencyInjection\\Configuration\:\:addRemoteIdentityProvidersSection\(\) has parameter \$remoteNode with generic class Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition but does not specify its types\: TParent$#'
-			identifier: missingType.generics
-			count: 1
-			path: ../../src/DependencyInjection/Configuration.php
-
-		-
-			message: '#^Method Surfnet\\SamlBundle\\DependencyInjection\\Configuration\:\:addRemoteSection\(\) has parameter \$rootNode with generic class Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition but does not specify its types\: TParent$#'
-			identifier: missingType.generics
-			count: 1
-			path: ../../src/DependencyInjection/Configuration.php
-
-		-
-			message: '#^Method Surfnet\\SamlBundle\\DependencyInjection\\Configuration\:\:addRemoteServiceProvidersSection\(\) has parameter \$remoteNode with generic class Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition but does not specify its types\: TParent$#'
-			identifier: missingType.generics
-			count: 1
-			path: ../../src/DependencyInjection/Configuration.php
-
 		-
 			message: '#^Method Surfnet\\SamlBundle\\DependencyInjection\\SurfnetSamlExtension\:\:parseCertificateData\(\) has parameter \$provider with no value type specified in iterable type array\.$#'
 			identifier: missingType.iterableValue

src/SAML2/Attribute/AttributeDictionary.php

@@ -75,11 +75,15 @@ public function addAttributeDefinition(AttributeDefinition $attributeDefinition)
         $this->attributeDefinitionsByName[$attributeDefinition->getName()] = $attributeDefinition;
 
         if ($attributeDefinition->hasUrnMace()) {
-            $this->attributeDefinitionsByUrn[$attributeDefinition->getUrnMace()] = $attributeDefinition;
+            $urnMace = $attributeDefinition->getUrnMace();
+            assert(is_string($urnMace));
+            $this->attributeDefinitionsByUrn[$urnMace] = $attributeDefinition;
         }
 
         if ($attributeDefinition->hasUrnOid()) {
-            $this->attributeDefinitionsByUrn[$attributeDefinition->getUrnOid()] = $attributeDefinition;
+            $urnOid = $attributeDefinition->getUrnOid();
+            assert(is_string($urnOid));
+            $this->attributeDefinitionsByUrn[$urnOid] = $attributeDefinition;
         }
     }