-
Notifications
You must be signed in to change notification settings - Fork 2
Upgrade to symfony 7.4 #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
25d33b0
e997288
88ec4dd
a15da7b
1b2cb57
788892d
0e8cef3
74e1cf5
0cd1223
e2558f9
7ca65c0
7756b82
29230b6
80fdf17
91037ce
2762ec9
a55f912
94cd381
c9e0563
85958d9
e92e4dd
4505834
dec15de
6bcf540
9e2377c
c8d329f
c31a288
5889f27
1192eea
3e2e1e9
e10d090
cab9488
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| .idea | ||
| .github/*.md | ||
| /web/bundles/ | ||
| /web/app_dev.php | ||
| /web/app_test.php | ||
|
|
||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| use Rector\Config\RectorConfig; | ||
| use Rector\Php74\Rector\Property\RestoreDefaultNullToNullableTypePropertyRector; | ||
| use Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector; | ||
| use Rector\Php81\Rector\Property\ReadOnlyPropertyRector; | ||
| use Rector\Php82\Rector\Class_\ReadOnlyClassRector; | ||
|
|
||
| return RectorConfig::configure() | ||
| ->withPaths([ | ||
| __DIR__ . '/../../config', | ||
| __DIR__ . '/../../src', | ||
| __DIR__ . '/../../tests', | ||
| __DIR__ . '/../../templates', | ||
| ]) | ||
| ->withPhpSets() | ||
| ->withAttributesSets(all: true) | ||
| ->withComposerBased(symfony: true, twig: true, doctrine: true, phpunit: true) | ||
| ->withTypeCoverageLevel(10) | ||
| ->withDeadCodeLevel(10) | ||
| ->withCodeQualityLevel(10) | ||
| ->withSkip([ | ||
| ReadOnlyClassRector::class, | ||
| ReadOnlyPropertyRector::class, | ||
| ClassPropertyAssignToConstructorPromotionRector::class, | ||
| RestoreDefaultNullToNullableTypePropertyRector::class, | ||
| ]); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #!/usr/bin/env sh | ||
|
|
||
| # Ensure we run from project root | ||
| cd "$(dirname "$0")/../../" || exit 1 | ||
| ./vendor/bin/rector --config=ci/qa/rector.php "$@" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| PHP_VERSION=82 | ||
| SYMFONY_VERSION=6 | ||
| SYMFONY_VERSION=7 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we require stepup build changes for |
||
| ENCORE=no | ||
| ASSETIC=no | ||
| NODE_VERSION=20 | ||
|
|
||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't forget to remove the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. think I removed it.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a distinction between the middleware and doctrine migrations. From the top of my head, this had to do with the combined middleware and gateway migrations. At this moment I do not have time to look into this further, but this might be a risky change..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, afaik,
middleware:migrations:migratedoes not exist, so I assumed it should be stepup.. But that may be wrong. I should look into the migrations, as my dev env does not actually run the migrations, but does end up with a working db ..