Upgrade to symfony 7.4 #557

johanib · 2025-11-27T15:46:18Z

No description provided.

In test/development mode, don't flood the console with queries. Update mariaDb version to match production. In the devbox, we want deprecations to fail the pipeline. In Github, we don't want that, as dependabot updates or small package udates should not cause the build to fail. We will handle the deprecations once a developer works on the project. Add a separate deprecation.log in development mode.

Surfnet\StepupMiddleware\CommandHandlingBundle\Root\Command\FooBarCommand::$snakeCase is deprecated

MagicClosureTwigExtensionToNativeMethodsRector + attribute rules.

Prior to this change, organised imports was not enforced, but required by coding guidelines. This would result in PR feedback about unused imports, usage of fqn in code, etc. This change auto fixes & enforces correct import usage via phpcs / phpcbf.

…rTypeDeclarationSQL

…ations to attributes for everything.

…sons. Only except camelcase method names and line lenghts.

RecastingRemovalRector

… is accessible by default now. RemoveReflectionSetAccessibleCallsRector

…nRector, NullToStrictStringFuncCallArgRector, FunctionFirstClassCallableRector

Tests cannot be abstract. So PHPunit does not allow it to end on 'Test' anymore.

Math is no longer needed as an explicit dependency.

xss_protection is deprecated. The recommended unsafe-inline al not allowed.

twigphp/Twig@7c38fc2 Disable doctrine automapping deprecation warning.

GetFiltersToAsTwigFilterAttributeRector InvokableCommandInputAttributeRector

…ds on it. Running `./bin/console` produces an error without it as jms/translation-bundle tries to instatiate it.

…ble in the cli, because they were not autoconfigured. This change ensures they are registered by adding autoconfigure to the console_commands.yml service definition. And adds a test to validate that. And adds autoconfigure to all other service definitions to ensure all attribute services can be picked up.

MKodde

Enjoy some nitpicks, questions and concerns...

ci/qa/phpunit-ci

src/Surfnet/Stepup/Tests/Configuration/Value/AllowedSecondFactorListTest.php

src/Surfnet/StepupMiddleware/ApiBundle/Tests/Identity/Projector/AuditLogProjectorTest.php

...rfnet/StepupMiddleware/MiddlewareBundle/Console/Command/BootstrapGsspSecondFactorCommand.php

src/Surfnet/StepupMiddleware/MiddlewareBundle/Console/Command/MigrateSecondFactorCommand.php

MKodde · 2025-12-01T11:16:10Z

config/services.yaml

+#    resource: '../src/Surfnet/'
+#    exclude:
+#      - '../src/Surfnet/DataFixtures/'
+#      - '../src/Surfnet/Migrations/'


I think the migrations should not be autoloaded, and be excluded explicitly. Maybe some of the other utility classes should not be either?

Good question, lets discuss. I removed this code, because it was not needed. I was confusing it with commands.yaml.

MKodde · 2025-12-01T11:17:49Z

README.md


 Clone the repository or download the archive to a directory. Install the dependencies by running `composer install` and fill out the database credentials et cetera.

-Make sure to run database migrations using `bin/console middleware:migrations:migrate`.


There was a distinction between the middleware and doctrine migrations. From the top of my head, this had to do with the combined middleware and gateway migrations. At this moment I do not have time to look into this further, but this might be a risky change..

ah, afaik, middleware:migrations:migrate does not exist, so I assumed it should be stepup.. But that may be wrong. I should look into the migrations, as my dev env does not actually run the migrations, but does end up with a working db ..

README.md

MKodde · 2025-12-01T11:23:28Z

component_info

@@ -1,5 +1,5 @@
 PHP_VERSION=82
-SYMFONY_VERSION=6
+SYMFONY_VERSION=7


Do we require stepup build changes for SYMFONY_VERSION=7?

MKodde · 2025-12-01T11:24:22Z

composer.json

Don't forget to remove the @TODO when upgraded to SF7.4 comment I saw in a previous commit :)

think I removed it..

… doctrine bundle. Instead, set the commented via the custom type. doctrine/DoctrineBundle#977

Relying on the default column size for varchar fields is deprecated. This change configures all varchar custom types to rely on the previous default value of 255, if not overridden. See \Doctrine\DBAL\Platforms\AbstractPlatform::getVarcharDefaultLength See doctrine/dbal#3263

Prior to this change, deprecation warnings about safepoints were thrown. This change enables safepoints for all connections. Safepoints are not supported by myisam tables or drivers like sqlite. doctrine/dbal#6272

$request->get is deprecated. $request->query->get for URL parameters or $request->request->get for POST should be used instead. See https://symfony.com/blog/new-in-symfony-7-4-request-class-improvements Phpstan: Fix get parameter types Prior to this change, \Surfnet\StepupMiddleware\ApiBundle\Controller\RaCandidateController::search could receive `secondFactorTypes`, which could never be an array, yet the query expects an array. This change ensures the query parameters for this property are read sa an array read.

… UpdateIdentityCommand Prior to this change, `Deprecated: Creation of dynamic property` was logged when running the behat tests in devconf. This can be caused when properties are set in old events, that are later removed from the class. We could check in the CommandValueResolver whether a field exists before setting it, but that carries more risk, in case the properties might be still read dynamically somewhere.

johanib added 24 commits November 20, 2025 11:42

PHPStan fixes

e997288

phpstan update & phpstan fixes

88ec4dd

Allow dynamic properties on FooBarCommand

a15da7b

Surfnet\StepupMiddleware\CommandHandlingBundle\Root\Command\FooBarCommand::$snakeCase is deprecated

Add rector & apply basic rules

1b2cb57

MagicClosureTwigExtensionToNativeMethodsRector + attribute rules.

Clean & enforce clean imports

788892d

Prior to this change, organised imports was not enforced, but required by coding guidelines. This would result in PR feedback about unused imports, usage of fqn in code, etc. This change auto fixes & enforces correct import usage via phpcs / phpcbf.

Fix deprecation: use getStringTypeDeclarationSQL instead of getVarcha…

0e8cef3

…rTypeDeclarationSQL

Upgrade to PHPUnit 10 (for attribute support) & transition from annot…

74e1cf5

…ations to attributes for everything.

Also apply the phpcs rules to tests, mainly for import management rea…

0cd1223

…sons. Only except camelcase method names and line lenghts.

Don't recast variables that are already in the correc type.

e2558f9

RecastingRemovalRector

Remove deprecated setAccessible. This is no longer needed, everything…

7ca65c0

… is accessible by default now. RemoveReflectionSetAccessibleCallsRector

Rector: FunctionLikeToFirstClassCallableRector, ClosureToArrowFunctio…

7756b82

…nRector, NullToStrictStringFuncCallArgRector, FunctionFirstClassCallableRector

Remove doctrine/annotations

29230b6

Fix Abstract test

80fdf17

Tests cannot be abstract. So PHPunit does not allow it to end on 'Test' anymore.

Update dev packages

91037ce

Math is no longer needed as an explicit dependency.

Handle framework deprecations.

2762ec9

xss_protection is deprecated. The recommended unsafe-inline al not allowed.

Handle twig sandbox deprecation

a55f912

twigphp/Twig@7c38fc2 Disable doctrine automapping deprecation warning.

Disable code coverage to prevent warnings.

94cd381

Upgrade Symfony 6.4 > 7.3

c9e0563

Commands & twig functions now use attributes.

85958d9

GetFiltersToAsTwigFilterAttributeRector InvokableCommandInputAttributeRector

Require doctrine/annotations because jms/translation-bundle depen…

e92e4dd

…ds on it. Running `./bin/console` produces an error without it as jms/translation-bundle tries to instatiate it.

Use attributes for more complicated commands

dec15de

Update readme & metadata

6bcf540

MKodde reviewed Dec 1, 2025

View reviewed changes

johanib force-pushed the feature/updates-nov25 branch 2 times, most recently from 77a29d3 to 9e949fa Compare December 2, 2025 12:20

johanib marked this pull request as ready for review December 2, 2025 12:37

johanib added 2 commits December 2, 2025 15:51

Upgrade Symfony 7.3 > 7.4

9e2377c

Doctrine: No longer rely on the deprecated commented setting in the…

c8d329f

… doctrine bundle. Instead, set the commented via the custom type. doctrine/DoctrineBundle#977

johanib added 5 commits December 2, 2025 15:51

Fix deprecation: Doctrine safepoints

5889f27

Prior to this change, deprecation warnings about safepoints were thrown. This change enables safepoints for all connections. Safepoints are not supported by myisam tables or drivers like sqlite. doctrine/dbal#6272

Add changelog

e10d090

johanib force-pushed the feature/updates-nov25 branch from fe4cee2 to a862c16 Compare December 2, 2025 14:51

johanib changed the title ~~WIP: Upgrade to symfony 7.4~~ Upgrade to symfony 7.4 Dec 2, 2025

rework

cab9488

johanib force-pushed the feature/updates-nov25 branch from a862c16 to cab9488 Compare December 2, 2025 15:08

johanib requested a review from MKodde December 2, 2025 15:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade to symfony 7.4 #557

Upgrade to symfony 7.4 #557

johanib commented Nov 27, 2025

Uh oh!

MKodde left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MKodde Dec 1, 2025

Uh oh!

johanib Dec 2, 2025

Uh oh!

MKodde Dec 1, 2025

Uh oh!

johanib Dec 2, 2025

Uh oh!

Uh oh!

MKodde Dec 1, 2025

Uh oh!

MKodde Dec 1, 2025

Uh oh!

johanib Dec 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		Clone the repository or download the archive to a directory. Install the dependencies by running `composer install` and fill out the database credentials et cetera.

		Make sure to run database migrations using `bin/console middleware:migrations:migrate`.

Upgrade to symfony 7.4 #557

Are you sure you want to change the base?

Upgrade to symfony 7.4 #557

Conversation

johanib commented Nov 27, 2025

Uh oh!

MKodde left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MKodde Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

johanib Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

MKodde Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

johanib Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MKodde Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

MKodde Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

johanib Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants