rework

Author: johanib

README.md

@@ -32,7 +32,7 @@ Some of the configuration of the components is static (i.e. stored in parametere
 ## Development Notes
 
 ### Technical debt
- * https://github.com/broadway/event-store-dbal is blocks upgrade to `doctrine/dbal:^4.0`
+ * https://github.com/broadway/event-store-dbal blocks upgrade to `doctrine/dbal:^4.0`
 
 ### Adding new events
 

ci/qa/phpunit-ci

@@ -102,14 +102,7 @@ public function an_allowed_second_factor_list_contains_the_given_second_factors(
             new SecondFactorType('yubikey'),
         ];
 
-        $allowedSecondFactorList = AllowedSecondFactorList::ofTypes($secondFactorTypes);
-
-        $builtList = [];
-        foreach ($allowedSecondFactorList as $item) {
-            $builtList[] = $item;
-        }
-
-        foreach ($builtList as $index => $actualSecondFactorType) {
+        foreach (iterator_to_array(AllowedSecondFactorList::ofTypes($secondFactorTypes)) as $index => $actualSecondFactorType) {
             $this->assertTrue($secondFactorTypes[$index]->equals($actualSecondFactorType));
         }
     }

src/Surfnet/Stepup/Tests/Configuration/Value/AllowedSecondFactorListTest.php

@@ -31,8 +31,7 @@
 #[AsCommand(
     name: 'middleware:bootstrap:gssp',
     description: 'Creates a Generic SAML Second Factor (GSSF) second factor for a specified user'
-)
-]
+)]
 final class BootstrapGsspSecondFactorCommand
 {
     public function __construct(private readonly BootstrapCommandService $bootstrapService, private readonly TransactionHelper $transactionHelper)

src/Surfnet/StepupMiddleware/MiddlewareBundle/Console/Command/BootstrapGsspSecondFactorCommand.php

@@ -33,8 +33,7 @@
 #[AsCommand(
     name: 'middleware:migrate:vetted-tokens',
     description: 'Migrates the tokens of an identity to a new institution while preserving the old tokens'
-)
-]
+)]
 final class MigrateSecondFactorCommand
 {
     public function __construct(private readonly BootstrapCommandService $bootstrapService, private readonly TransactionHelper $transactionHelper)