Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG Change the name in Plugin Manager to Crowdsource. #1

Open
rgleason opened this issue Feb 7, 2025 · 13 comments · Fixed by OpenCPN/plugins#1246
Open

BUG Change the name in Plugin Manager to Crowdsource. #1

rgleason opened this issue Feb 7, 2025 · 13 comments · Fixed by OpenCPN/plugins#1246

Comments

@rgleason
Copy link
Collaborator

rgleason commented Feb 7, 2025

You should not be using Kahu Radar as the name, this is terrribly confusing to users.

It starts as Crowdsource and will be known as crowdsource. People with search for crowdsource too.

Image

@redhog
Copy link
Member

redhog commented Feb 7, 2025

Ah, this was a discussion on renaming things in one of all these tickets, and I agreed that "crowdsource" maybe wasn't the best name, so changed it to the same as our crowdsourcing site, but didn't want to change the filename because it's already everywhere.

I'm happy for it to be either really, whatever you think is most obvious / easy for users...

@rgleason
Copy link
Collaborator Author

rgleason commented Feb 7, 2025

You decided too late. Look I am tired of redoing cloudsmith, and don't really want to setup a new repository for Kahu-radar-hub or whatever, right now and you will have to redo your circleci project too, and then we will need to change the crowdsource name in github to be Kahu-radar-hub or whatever too (that can be done and is relatively easy, but forked repositories will have the crowdsmith name, which is ok because only jon has a fork.

I agree that is more descriptive, but the name itself is hyphenated and a bit long. If we pause here for a moment and think about this and get it right now. I will agree to add a new repository and remove crowdsource, but just get it right this time please.
Let me know. You will need to change your cmakelists.txt accordingly too.

What is the name you really want. Keep it short and with only on hyphen, or cap/lowercase radarHub, radarhub, KAHUradar, Kradar, kahuHUB , whatever. I think you want radar in there.

@redhog
Copy link
Member

redhog commented Feb 8, 2025

Ok, I didn't know the filename and display name had to be the same, but fair enough.

What do you think @walzetta , do we just make it be Crowdsource for both filename and display name, or do we change it and give @rgleason a bunch of extra work?

@rgleason
Copy link
Collaborator Author

rgleason commented Feb 10, 2025

Elig, what are we going to do here?

Do you want me to make 3 new repos called what? kahuradar?

@redhog
Copy link
Member

redhog commented Feb 10, 2025

What about:

set(VERBOSE_NAME "KAHU Radar Hub")
set(COMMON_NAME "KAHU Radar Hub")
set(TITLE_NAME "radarhub")
set(PACKAGE "radarhub")

filename: radarhub_pi

Does that work for you?

@rgleason
Copy link
Collaborator Author

Yes, something like that. Some examples

SET(VERBOSE_NAME "Squiddio")
set(COMMON_NAME "squiddio")
set(TITLE_NAME "squiddio")
set(PACKAGE_CONTACT "Mauro Calvi")
SET(PACKAGE "squiddio") ---- > Cloudsmith is squiddio-prod

set(VERBOSE_NAME "AISradar")
set(COMMON_NAME "AIS Radar view")
set(TITLE_NAME "AISradar")
set(PACKAGE_CONTACT "Johan Sman")
set(PACKAGE "aisradar") ----> Cloudsmith is aisradar-prod

So I guess

set(VERBOSE_NAME "KAHU Radar Hub")
set(COMMON_NAME "KAHU Radar Hub")
set(TITLE_NAME "radarhub")
set(PACKAGE "radarhub") -----> Cloudsmith is radarhub-prod

I hope that will not necessitate any other changes.

So should I make
radarhub-prod
radarhub-beta
radarhub-alpha ?

@redhog
Copy link
Member

redhog commented Feb 11, 2025

Yep, that would be perfect. But then I assume you want the VERBOSE_NAME to just be "Radar Hub", not "KAHU Radar Hub"?

Thank you so much. And sorry for the extra work - I just forgot this in the midst of the giant macos/windows cmake debugging...

@rgleason
Copy link
Collaborator Author

I think KAHU Radar Hub" would be fine. I had not thought of that way of doing it. You've kept the part that we will use for every plugin update short, for ease of use.

I''ll do this today.

@redhog
Copy link
Member

redhog commented Feb 11, 2025

Thanks, ping me when repos are made and I'll change the circleci setup and cmakelists.txt. And again thanks for dealing with this stuff!

@rgleason
Copy link
Collaborator Author

rgleason commented Feb 11, 2025

Elig, You should probably change the name crowdsource_pi too. I have done this several times and it isn't hard. It just is bad to do if you have a lot of people who have forked your repo, and Jon is the only one right now, and he said he just did it to help out.

Are you going to rename the repo to radarhub_pi or KAHUradarhub_pi?

Copilot says..

Changing the name of a GitHub repository is quite straightforward. Here are the steps:

  1. Navigate to your repository: Go to the main page of the repository you want to rename.
  2. Access Settings: Under your repository name, click on Settings.
  3. Rename the Repository: In the Repository Name field, type the new name for your repository.
  4. Save Changes: Click Rename to save the new name.

Keep in mind that renaming a repository will automatically redirect most existing information, such as issues, wikis, stars, and followers, to the new name. However, it's a good idea to update any local clones to point to the new repository URL using the command:

git remote set-url origin NEW_URL

@rgleason
Copy link
Collaborator Author

Ok, I think I've got it set up for you now.
https://cloudsmith.io/~opencpn/repos/radarhub-prod/upload/
https://cloudsmith.io/~opencpn/repos/radarhub-beta/upload/
https://cloudsmith.io/~opencpn/repos/radarhub-prod/upload/

You will need to enable Circleci for this new project and provide your auth key and add your Cloudsmith Key environmental etc.
for this new project radarhub so that the entire CI chain works.

@redhog
Copy link
Member

redhog commented Feb 11, 2025

Tahnks! Will do!

@rgleason
Copy link
Collaborator Author

Let me know if you have any trouble with the 3 radarhub repos. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants