Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datasetmanager tests race condition #559

Open
rettigl opened this issue Feb 7, 2025 · 0 comments · May be fixed by #562
Open

Datasetmanager tests race condition #559

rettigl opened this issue Feb 7, 2025 · 0 comments · May be fixed by #562
Assignees
@zain-sohail

Comments

@rettigl
Copy link
Member

rettigl commented Feb 7, 2025

DatasetManager tests fail some times if executed concurrently. This is because all tests access the same global dataset configuration. Also, running the tests leaves a "test" folder behind. This should be avoided by properly mocking paths, and using tmp_path.
@zain-sohail zain-sohail linked a pull request Feb 27, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zain-sohail zain-sohail

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dataset tests OpenCOMPES/sed
2 participants
@zain-sohail @rettigl