-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WiP - first pass at rewrite for custom backend #47
base: main
Are you sure you want to change the base?
Conversation
…inance/openbb-docs into new-custom-backend-docs
There were a couple of closing divs lost. Will push fix in a second |
disregard previous comments. i've checked out a wrong branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a bunch of suggestions
Hope this helps
Non-blocking
- Can be used to display markdown, txt, and docx files. | ||
- [Learn more about Markdown Widgets](Widgets/markdown.md) | ||
|
||
<img className="pro-border-gradient" width="600" alt="markdown" src="https://openbb-assets.s3.us-east-1.amazonaws.com/docs/pro/markdown-widget.png" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion to use a screenshot where the image is not that big.
from fastapi import FastAPI | ||
from fastapi.middleware.cors import CORSMiddleware | ||
from fastapi.responses import JSONResponse | ||
import pandas as pd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to reduce the LoC of the example let us remove the imports that are not used. For example requests, pandas and plotly are not used in this boilerplate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya I wasn't sure here, they will be used later though in the examples - so I'm hesitant - as i'd expect people to copy this then start.
But I don't have a strong opinion either way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we start using the new Product name here already - so we don't need to do it one more time
No description provided.