Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiP - first pass at rewrite for custom backend #47

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

andrewkenreich
Copy link
Contributor

No description provided.

@piiq
Copy link
Collaborator

piiq commented Dec 12, 2024

It's not launching locally. Am I'm missing anything?
image
I've did npm i

@piiq
Copy link
Collaborator

piiq commented Dec 12, 2024

There were a couple of closing divs lost. Will push fix in a second

@piiq
Copy link
Collaborator

piiq commented Dec 12, 2024

disregard previous comments. i've checked out a wrong branch

Copy link
Collaborator

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a bunch of suggestions

Hope this helps

Non-blocking

content/terminal/custom-backend/custom-backend.md Outdated Show resolved Hide resolved
content/terminal/custom-backend/custom-backend.md Outdated Show resolved Hide resolved
- Can be used to display markdown, txt, and docx files.
- [Learn more about Markdown Widgets](Widgets/markdown.md)

<img className="pro-border-gradient" width="600" alt="markdown" src="https://openbb-assets.s3.us-east-1.amazonaws.com/docs/pro/markdown-widget.png" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to use a screenshot where the image is not that big.

content/terminal/custom-backend/custom-backend.md Outdated Show resolved Hide resolved
from fastapi import FastAPI
from fastapi.middleware.cors import CORSMiddleware
from fastapi.responses import JSONResponse
import pandas as pd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to reduce the LoC of the example let us remove the imports that are not used. For example requests, pandas and plotly are not used in this boilerplate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya I wasn't sure here, they will be used later though in the examples - so I'm hesitant - as i'd expect people to copy this then start.

But I don't have a strong opinion either way

content/terminal/custom-backend/Widgets/chart/plotly.md Outdated Show resolved Hide resolved
content/terminal/custom-backend/Widgets/table/table.md Outdated Show resolved Hide resolved
content/terminal/custom-backend/Widgets/table/table.md Outdated Show resolved Hide resolved
content/terminal/custom-backend/Widgets/table/table.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start using the new Product name here already - so we don't need to do it one more time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants