fix: validate lab result calendar dates

Reject impossible and non-canonical assay dates while preserving structured invalid-file provenance.

Author: streamentry

AGENTS.md

@@ -100,6 +100,10 @@ If these docs conflict, safety and claim discipline win.
   relative `raw_data_file` field. Missing files, path escape, or mismatches are
   structured verification blockers; matching bytes do not validate assay
   contents, reviewer identity, biology, or release readiness.
+- Lab-result `assay_date` values are checked as real, canonical `YYYY-MM-DD`
+  calendar dates after schema validation. Impossible or non-canonical dates are
+  retained as structured invalid-file errors and cannot enter reports or
+  metrics; this is temporal input integrity, not assay validation.
 - The Phase R scientific-review readiness gate is available through
   `scientific-review-readiness-check` and
   `make scientific-review-readiness-check`; only a

SKILL.md

@@ -155,6 +155,10 @@ When a caller supplies `--raw-data-dir`, records with `raw_data_file` can be
 independently checked against their declared SHA-256. Missing files, path
 escape, and mismatches block clean calibration intake; matching bytes prove
 file identity only, not assay validity or biology.
+Lab-result `assay_date` values are additionally checked as real, canonical
+`YYYY-MM-DD` calendar dates because JSON Schema's date format annotation is not
+enforced by the generic validator. Impossible or non-canonical dates are
+retained as structured invalid-file errors and cannot enter reports or metrics.
 
 - `make bench-easy-baseline`: trivial length/charge baselines.
 - `make bench-charge-matched`: adversarial check that removes charge-density

docs/engineering/AGENTS.md

@@ -20,6 +20,9 @@ turning artifact presence into scientific validation.
 - `ARCHITECTURE.md` also records the Phase Z ZAG- CLI/Make surface; all four
   per-family accountability artifacts are required, but presence is not
   benchmark validation.
+- `ARCHITECTURE.md` records that lab-result `assay_date` values undergo
+  canonical calendar validation before they can enter sorted reports or
+  calibration metrics.
 
 ## Diagrams (Mermaid)
 

docs/engineering/ARCHITECTURE.md

@@ -117,6 +117,10 @@ missing. An optional `raw_data_file` reference can be verified by supplying
 `--raw-data-dir`; the verifier hashes files independently, rejects path escape,
 and blocks clean calibration intake on missing or mismatched files. This binds
 the declaration to file bytes only and does not validate assay contents.
+The loader also validates `assay_date` as a real, canonical `YYYY-MM-DD`
+calendar date because the generic JSON Schema helper does not enforce format
+annotations. Invalid dates remain structured file errors and cannot enter
+sorted reports or calibration metrics.
 Results whose candidate IDs are absent from the submitted calibration panel are
 retained as orphan provenance but block clean intake because they cannot be
 joined to prior predictions. This prevents a broader result directory from

docs/evidence/AGENTS.md

@@ -22,6 +22,9 @@ Gate workflows are structural review controls, never biological proof.
 - The Phase R SRG- workflow exposes scientific-review readiness through the CLI
   and Make surface; conditional, incomplete, safety-blocked, or malformed
   records must fail closed.
+- Impossible or non-canonical lab-result `assay_date` values remain structured
+  invalid-file evidence and cannot support downstream metrics; this is temporal
+  input integrity, not assay validation.
 
 ## Diagrams (Mermaid)
 

docs/evidence/METRICS_CURRENT.md

@@ -5,7 +5,7 @@ Machine-readable snapshot: `outputs/metrics_snapshot.json` regenerated with `mak
 > **Purpose:** One authoritative table of current pipeline metrics. If any doc disagrees
 > with this file, this file wins. Updated whenever benchmark/benchmark config changes.
 >
-> **Last updated:** 2026-07-24 (frozen external-review package identity check; benchmark values unchanged)
+> **Last updated:** 2026-07-25 (lab-result assay-date integrity check; benchmark values unchanged)
 
 > **Current verification note (2026-07-24):** Phase AA AA6 exposes the AARG-
 > reproducibility aggregate through a repeatable CLI/make workflow, while Phase
@@ -161,6 +161,14 @@ Machine-readable snapshot: `outputs/metrics_snapshot.json` regenerated with `mak
   compatible. File identity is not assay validation, reviewer authentication,
   biological proof, or release authorization.
 
+### External-result intake integrity — reject impossible assay dates
+- Lab-result loading now validates `assay_date` as a real, canonical
+  `YYYY-MM-DD` calendar date after schema validation.
+- Impossible or non-canonical dates are retained as structured invalid-file
+  errors and cannot enter sorted reports or calibration metrics.
+- This closes a temporal input-integrity gap; it does not validate assay
+  contents, reviewer identity, biological activity, or release readiness.
+
 
 ### External-result intake integrity — reject invalid result paths
 - Lab-result directory loading now fails closed when the input path is missing

docs/research/AGENTS.md

@@ -23,6 +23,9 @@ work and preserve the external-truth bottleneck.
   records that provide the relative `raw_data_file` field. Missing files, path
   escape, and mismatches block clean calibration intake; matching file bytes do
   not validate assay contents or biology.
+- Lab-result loading also rejects impossible or non-canonical `assay_date`
+  values as structured invalid-file errors before they reach reports or
+  calibration metrics.
 - The next executable review boundary is the Phase R SRG- workflow. Its default
   example is intentionally blocked because qualified wet-lab evidence is not
   present; do not treat the gate as validation.

docs/research/ROADMAP.md

@@ -1,6 +1,6 @@
 # Roadmap
 
-## Current state — 2026-07-24
+## Current state — 2026-07-25
 
 Phase Z is complete as of 2026-07-23. Z5 exposes the existing FBH-, BXR-,
 ARG-, and CBF- per-family accountability artifacts through a ZAG- aggregate,
@@ -107,6 +107,13 @@ records. This binds a review record to package bytes, but does not authenticate
 the reviewer, establish independence, validate the science, or create
 biological evidence.
 
+On 2026-07-25, lab-result loading also began checking `assay_date` as a real,
+canonical `YYYY-MM-DD` calendar date. JSON Schema's date format annotation is
+not enforced by the generic validator, so impossible or non-canonical dates
+are now retained as structured invalid-file errors and cannot enter sorted
+reports or calibration metrics. This is temporal input integrity, not assay
+validation or biological evidence.
+
 This file is the current milestone authority. The older
 [`50_LOOP_PLAN.md`](50_LOOP_PLAN.md) is a historical execution record, not a
 live status page. Select the next bottleneck from

src/openamp_foundry/data/AGENTS.md

@@ -7,15 +7,17 @@ descriptive evidence plumbing, not biological validation.
 
 ## Key Components
 
-- `lab_results.py`: input-path validation, schema validation, structured
-  invalid-file provenance, and candidate-level summaries. Rollups expose raw
+- `lab_results.py`: input-path validation, schema and canonical calendar-date
+  validation, structured invalid-file provenance, and candidate-level summaries.
+  Rollups expose raw
   observations separately from control-passing outcome flags and counts;
   batch-level qualitative summaries follow the same raw-versus-usable split.
   Calibration intake may additionally verify an optional frozen `panel_id`.
   Reports expose declared `raw_data_sha256` coverage separately from verified
   evidence; a declared hash is never presented as independently checked unless
   the caller opts into `verify_raw_data_provenance()` with a raw-data directory
-  and `raw_data_file` references.
+  and `raw_data_file` references. Invalid or non-canonical `assay_date` values
+  remain structured file errors and cannot enter sorted reports or metrics.
 - `__init__.py`: stable public loader exports.
 
 ## Diagrams (Mermaid)

src/openamp_foundry/data/lab_results.py

@@ -12,6 +12,7 @@
 
 import hashlib
 import json
+from datetime import date
 from pathlib import Path
 from typing import Any
 
@@ -29,6 +30,18 @@ def load_lab_result(path: str | Path) -> dict[str, Any]:
     with p.open("r", encoding="utf-8") as f:
         result = json.load(f)
     validate_json_schema(result, LAB_RESULT_SCHEMA)
+    assay_date = result["assay_date"]
+    try:
+        parsed_assay_date = date.fromisoformat(assay_date)
+    except (TypeError, ValueError) as exc:
+        raise ValueError(
+            "assay_date must be a valid ISO 8601 calendar date (YYYY-MM-DD)"
+        ) from exc
+    if parsed_assay_date.isoformat() != assay_date:
+        raise ValueError(
+            "assay_date must use the canonical ISO 8601 calendar date form "
+            "(YYYY-MM-DD)"
+        )
     return result