Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify contact form #356

Closed

Conversation

mwango-phoenix
Copy link
Contributor

@mwango-phoenix mwango-phoenix commented Oct 28, 2024

Title and Issue number

Title : Contact form UI Modifications

Issue No. : 318

Close #318

Image

image

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md if its a new page/tech stack
  • I have gone through the contributing.md file before contributing

Are you contributing under any Open-source programme?

  • I'm a GSSOC-EXT contributor
  • I'm a HACKTOBERFEST contributor

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for befiteveryday failed.

Name Link
🔨 Latest commit 18235e8
🔍 Latest deploy log https://app.netlify.com/sites/befiteveryday/deploys/6721b8ae6c68e8000897e38b

@jeevan10017 jeevan10017 added the invalid This doesn't seem right label Oct 31, 2024
Copy link
Collaborator

@jeevan10017 jeevan10017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the design

@mwango-phoenix
Copy link
Contributor Author

Change the design

in what way

@jeevan10017
Copy link
Collaborator

@mwango-phoenix, you changed from gradient colouring to normal, which does not look as good as before.

@mwango-phoenix
Copy link
Contributor Author

@mwango-phoenix, you changed from gradient colouring to normal, which does not look as good as before.

There was no gradient before as seen in the issue #318 . I checked the background multiple times and it was #121212, not sure what the linear gradient line was doing.
I changed it since it hid the github logo

@@ -23,7 +23,7 @@ const ContactForm = styled(Paper)(({ theme }) => ({
padding: theme.spacing(4),
maxWidth: "600px",
margin: "auto",
backgroundColor: "linear-gradient(135deg, #1F1C2C 10%, #232526 100%)",
backgroundColor: "rgba(20, 20, 20, 0.8)",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what that looked like. since what I got was the screenshot in #318 which had no gradient

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwango-phoenix, if you want to change the design further, you can. but the present is not looking good.

@jeevan10017 jeevan10017 closed this Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Fix for Contact Us block
2 participants