Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csolution] Rename *.cbuild-run.yml #1923

Open
ReinhardKeil opened this issue Jan 18, 2025 · 2 comments
Open

[csolution] Rename *.cbuild-run.yml #1923

ReinhardKeil opened this issue Jan 18, 2025 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@ReinhardKeil
Copy link
Collaborator

The Problem To Be Solved

As it is possible to have more than 1 solution in a directory structure, it is required to include the solution name in the cbuild-run.yml filename. Currently the filename is <target-name>.cbuild-run.yml.

Suggest A Solution

It should be named <solution-name>+<target-name>.cbuild-run.yml.

The documentation is also inconsistent here.

https://open-cmsis-pack.github.io/cmsis-toolbox/Experimental-Features/#run-and-debug-management

@ReinhardKeil ReinhardKeil added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 18, 2025
@brondani brondani moved this to Todo in CMSIS-Toolbox 2.8.0 Jan 20, 2025
@thorstendb-ARM
Copy link
Collaborator

Please activate code: src/solutions/hardware/debug-hardware-commands.ts

    private getCbuildRunPath() {
        const csolution = this.solutionManager.getCsolution();
        //const cbuildRunFile = csolution?.getActiveTargetType + '.cbuild-run.yml';
        // TODO: https://github.com/Open-CMSIS-Pack/devtools/issues/1923
        const solutionName = this.solutionManager.getSolutionModel()?.solutionName ?? '';
        const cbuildRunFile = solutionName + '+' + csolution?.getActiveTargetType + '.cbuild-run.yml';
        return path.join(csolution?.solutionDir ?? './', cbuildRunFile);
    }

Or assign this issue to me :)

@thorstendb-ARM thorstendb-ARM self-assigned this Jan 22, 2025
@jkrech jkrech changed the title Rename *.cbuild-run.yml [csolution] Rename *.cbuild-run.yml Feb 4, 2025
@brondani brondani moved this from Todo to Done in CMSIS-Toolbox 2.8.0 Feb 6, 2025
@brondani brondani closed this as completed by moving to Done in CMSIS-Toolbox 2.8.0 Feb 6, 2025
@brondani brondani moved this from Done to In Progress in CMSIS-Toolbox 2.8.0 Feb 6, 2025
@brondani brondani moved this from In Progress to Done in CMSIS-Toolbox 2.8.0 Feb 7, 2025
@thorstendb-ARM
Copy link
Collaborator

Activated code:
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants