Skip to content

Commit cfe5d54

Browse files
authored
Merge pull request #1335 from OneSignal/fix/getTriggerValueForKey_android_inconsistency
Make Android `getTriggerValueForKey` consistent with iOS
2 parents 9f9582d + 166a630 commit cfe5d54

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

android/src/main/java/com/geektime/rnonesignalandroid/RNOneSignal.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -594,7 +594,13 @@ public void removeTriggersForKeys(ReadableArray keys) {
594594

595595
@ReactMethod
596596
public void getTriggerValueForKey(String key, Promise promise) {
597-
promise.resolve(OneSignal.getTriggerValueForKey(key));
597+
Object val = OneSignal.getTriggerValueForKey(key);
598+
if (val == null) {
599+
Log.e("OneSignal", "getTriggerValueForKey: There was no value for the key: " + key);
600+
promise.reject("No Value", "There was no value for the key: " + key);
601+
return;
602+
}
603+
promise.resolve(val);
598604
}
599605

600606
/* in app message click */

0 commit comments

Comments
 (0)