Skip to content

Commit 64883d2

Browse files
authored
Merge pull request #1017 from OneSignal/fix/notification_click_listener_cold_start
Fix: Notification click listener fires on cold start
2 parents 1e2f9e7 + dd3f899 commit 64883d2

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

src/android/com/onesignal/cordova/OneSignalPush.java

+10-3
Original file line numberDiff line numberDiff line change
@@ -236,9 +236,17 @@ private boolean preventDefault(JSONArray data) {
236236
* N O T I F I C A T I O N C L I C K L I S T E N E R
237237
*/
238238

239+
private boolean hasAddedNotificationClickListener = false;
240+
239241
public boolean addNotificationClickListener(CallbackContext callbackContext) {
240-
jsNotificationClickedCallback = callbackContext;
241-
return true;
242+
if (this.hasAddedNotificationClickListener) {
243+
return false;
244+
}
245+
246+
OneSignal.getNotifications().addClickListener(this);
247+
jsNotificationClickedCallback = callbackContext;
248+
hasAddedNotificationClickListener = true;
249+
return true;
242250
}
243251

244252
@Override
@@ -361,7 +369,6 @@ public boolean init(CallbackContext callbackContext, JSONArray data) {
361369
OneSignal.getInAppMessages().addLifecycleListener(this);
362370
OneSignal.getInAppMessages().addClickListener(this);
363371
OneSignal.getNotifications().addForegroundLifecycleListener(this);
364-
OneSignal.getNotifications().addClickListener(this);
365372

366373
CallbackHelper.callbackSuccessBoolean(callbackContext, true);
367374
return true;

0 commit comments

Comments
 (0)