Skip to content

Commit 3238d9a

Browse files
committed
Fix bug
1 parent 11d50d0 commit 3238d9a

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/application/MainApplication.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ public void onUserStateChange(@NonNull UserChangedState state) {
131131
OneSignal.addUserJwtInvalidatedListner(new IUserJwtInvalidatedListener() {
132132
@Override
133133
public void onUserJwtInvalidated(@NonNull UserJwtInvalidatedEvent event) {
134-
Log.v(Tag.LOG_TAG, "onUserJwtInvalidated fired with ID:" + event.getExternal_id());
134+
Log.v(Tag.LOG_TAG, "onUserJwtInvalidated fired with ID:" + event.getExternalId());
135135
}
136136
});
137137

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/UserJwtInvalidatedEvent.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ package com.onesignal
66
*
77
*/
88
class UserJwtInvalidatedEvent(
9-
val external_id: String
9+
val externalId: String
1010
) {
1111

1212
}

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/http/impl/HttpClient.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,8 @@ internal class HttpClient(
135135
con.readTimeout = timeout
136136
con.setRequestProperty("SDK-Version", "onesignal/android/" + OneSignalUtils.SDK_VERSION)
137137

138-
if (jwt != null) {
139-
con.setRequestProperty("Authentication", jwt)
138+
if (!jwt.isNullOrEmpty()) {
139+
con.setRequestProperty("Authentication", "Bearer $jwt")
140140
}
141141

142142
if (OneSignalWrapper.sdkType != null && OneSignalWrapper.sdkVersion != null) {

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OneSignalImp.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -429,6 +429,7 @@ internal class OneSignalImp : IOneSignal, IServiceProvider {
429429
return
430430
}
431431

432+
// calling createAndSwitchToNewUser() replaces model with a default empty jwt
432433
createAndSwitchToNewUser()
433434
operationRepo!!.enqueue(
434435
LoginUserOperation(
@@ -437,9 +438,6 @@ internal class OneSignalImp : IOneSignal, IServiceProvider {
437438
identityModelStore!!.model.externalId,
438439
),
439440
)
440-
441-
// TODO: remove JWT Token for all future requests.
442-
// calling createAndSwitchToNewUser() replaces model with a default null jwt
443441
}
444442
}
445443

@@ -448,7 +446,6 @@ internal class OneSignalImp : IOneSignal, IServiceProvider {
448446
return
449447

450448
identityModelStore!!.model.jwtToken = token
451-
// TODO: update OperationRepo with new JWT
452449
}
453450

454451
override fun addUserJwtInvalidatedListner(listener: IUserJwtInvalidatedListener) {

0 commit comments

Comments
 (0)