Skip to content

Commit b3bd0b5

Browse files
authored
Merge pull request #30 from OneNoteDev/query-params
Properly support specifying query parameters in all requests
2 parents 431c010 + a62f02c commit b3bd0b5

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "2.0.12",
2+
"version": "2.0.14",
33
"name": "onenoteapi",
44
"description": "JavaScript library to make calling the OneNote API easier.",
55
"main": "dist/OneNoteApi.js",

src/scripts/oneNoteApiBase.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ export class OneNoteApiBase {
3939
fullUrl = this.generateFullUrl(url, urlContainsVersion);
4040
}
4141

42+
// Append specified query params
43+
fullUrl = this.appendQueryParams(fullUrl);
44+
4245
if (!contentType) {
4346
contentType = "application/json";
4447
}
@@ -92,10 +95,6 @@ export class OneNoteApiBase {
9295
return this.generateUrlUntilVersion(urlContainsVersion) + partialUrl;
9396
}
9497

95-
public generateFullMeNotesUrl(partialUrl: string, urlContainsVersion?: boolean): string {
96-
return this.generateUrlUntilVersion(urlContainsVersion) + "/me/notes" + partialUrl;
97-
}
98-
9998
private makeRequest(url: string, data?: XHRData, contentType?: string, httpMethod?: string): Promise<ResponsePackage<any>> {
10099
return new Promise((resolve: (responsePackage: ResponsePackage<any>) => void, reject: (error: RequestError) => void) => {
101100
let request = new XMLHttpRequest();

0 commit comments

Comments
 (0)