Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: conditionally render schedule link in StopPane component #195

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: conditionally render schedule link in StopPane component #195

wants to merge 2 commits into from

Conversation

iqbalcodes6602
Copy link

added a check on view schedule button to contionally render it only when the tripselected variable is there

fixes: #192

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

aaronbrethorst
aaronbrethorst approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

aaronbrethorst
aaronbrethorst requested changes Mar 6, 2025
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! except that listing failed. please go back and run the linter.

@coveralls
Copy link

Coverage Status

coverage: 15.812% (-0.7%) from 16.487%
when pulling 5c413c4 on iqbalcodes6602:Don't-Show-View-Schedule
into 4220475 on OneBusAway:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst Awaiting requested review from aaronbrethorst

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't Show "View Schedule" on the standalone Arrivals and Departures page
4 participants
@iqbalcodes6602 @CLAassistant @coveralls @aaronbrethorst