Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update omnisharp-node-client for using the latest omnisharp-roslyn binary #435

Open
AndrienkoAleksandr opened this issue Jul 12, 2017 · 5 comments

Comments

@AndrienkoAleksandr
Copy link
Contributor

Inside Eclipse CHE we are using omnisharp-node-client language server. I see that the latest release works with dotnet 1.0.4 projects, but it doesn't work with dotnet 2.0. Can you update this omnisharp-node-client to the latest omnisharp-roslyn binary, (seems it should resolve this problem)?

@mickaelistria
Copy link

It also seems like the current version in omnisharp-node-client does embed a version of OmniSharp-Roslyn with the following issue: dotnet/vscode-csharp#786 .

@david-driscoll
Copy link
Member

I'll jump on it this weekend!

@mickaelistria
Copy link

Which version/commit of omnisharp-roslyn does bring support for dotnet 2.0?
Omnisharp-node-client currently uses omnisharp-roslym 1.22 which seems to be the latest release. Is the upcoming 1.23 going to provide full support for dotnet 2.0 ? What would be the prerequisites for it to work on Linux?

@david-driscoll
Copy link
Member

1.23.1 should work with the latest dotnet core 2.0. I'll be pushing an update with the related fixes tonight.

@mickaelistria
Copy link

Hurray! I tried the latest release v7.1.2 which uses omnisharp-roslyn 1.23.1 and it worked well on Fedora 26 with a version recent of dotnet-core 2.0 and no dependency on mono!
I believe it's a pretty satisfying result from integrator and user POV, so we can close this issue.
Thanks for your assistance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants