Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP implementation returns void for rename (although backend request works) #278

Open
mickaelistria opened this issue Aug 29, 2016 · 0 comments

Comments

@mickaelistria
Copy link

I'm sending a Language Server Protocol "Rename" request. I can see via telemetry events that this get processed fine (I'm renaming i variable to blah), but the result is empty:

Here is what I receive from OmniSharp-node. The 3rd message shows the the replace works internally, last one shows it's not returned.

jsonrpc":"2.0","method":"telemetry/event","params":{"clientId":"client1","command":"/rename","request":{"FileName":"/home/mistria/git/3dLocalizer/test.cs","Line":9,"Column":8,"RenameTo":"blah"},"silent":false,"sequence":"__request3","time":"2016-08-29T08:50:40.411Z"}}

{"jsonrpc":"2.0","method":"telemetry/event","params":{"Event":"log","Body":{"LogLevel":"INFORMATION","Name":"OmniSharp.Middleware.LoggingMiddleware","Message":"/rename: 200 899ms"},"Seq":21,"Type":"event"}}

{"jsonrpc":"2.0","method":"telemetry/event","params":{"command":"/rename","response":{"Changes":[{"FileName":"/home/mistria/git/3dLocalizer/test.cs","Buffer":"using System;\npublic class HelloWorld\n{\n    public static void Afficher()\n    {\n   \t\tint blah = 0;\n        Console.WriteLine(\"Hello world !\");\n        Console.ReadLine();\n        \n        blah++;\n        int a = blah / 3; \n    }\n}\n","Changes":null}],"ErrorMessage":null},"clientId":"client1","request":{"FileName":"/home/mistria/git/3dLocalizer/test.cs","Line":9,"Column":8,"RenameTo":"blah"},"sequence":"__request3","time":"2016-08-29T08:50:41.313Z","silent":false,"failed":false,"responseTime":902}}

{"jsonrpc":"2.0","id":"1","result":{"changes":{"file:///home/mistria/git/3dLocalizer/test.cs":[]}}}Content-Length: 141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant