Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convertible Deposits #31

Open
0xJem opened this issue Dec 13, 2024 · 4 comments · May be fixed by #29
Open

Convertible Deposits #31

0xJem opened this issue Dec 13, 2024 · 4 comments · May be fixed by #29
Assignees
@0xJem

Comments

@0xJem
Copy link
Collaborator

0xJem commented Dec 13, 2024

No description provided.

@0xJem 0xJem linked a pull request Dec 13, 2024 that will close this issue
Convertible Deposits #29
Draft
@0xJem 0xJem self-assigned this Dec 20, 2024
@0xJem
Copy link
Collaborator Author

0xJem commented Dec 20, 2024

Zeus wrote the original design, and I've been working on improving it plus adding tests.

Progress this week:

  • Finalized design and implementation of the base contracts: CDEPO module (convertible deposit token) and CDPOS module (convertible deposit position as an ERC721). Including tests.
  • Started on tests for the ConvertibleDepositFacility.

I'm confident that I can be done with the tests and any implementation changes in the coming week.

@0xJem
Copy link
Collaborator Author

0xJem commented Dec 27, 2024

Done with CDF tests. Just a little bit to go with CDA and EmissionsManager.

@0xJem
Copy link
Collaborator Author

0xJem commented Jan 17, 2025

Need to update the ERC721 SVG. Then organize audit.

@0xJem
Copy link
Collaborator Author

0xJem commented Feb 7, 2025

Remaining work:

  • Shift to using the PolicyEnabler mix-in
  • Check if we should be using timestamp or epoch for frequency checks
  • Arrange for audit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xJem 0xJem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convertible Deposits OlympusDAO/olympus-v3
1 participant
@0xJem