Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(UI): Better Text for Transition Timelines #94

Open
memarin opened this issue Jan 16, 2025 · 2 comments
Open

(UI): Better Text for Transition Timelines #94

memarin opened this issue Jan 16, 2025 · 2 comments

Comments

@memarin
Copy link
Collaborator

memarin commented Jan 16, 2025

Image

Referencing the last item in this dropdown (”Auction Ends In”)

The current implementation will say:

  • “Auction Starts In …”
  • “Auction Ends In …”
  • “Round Ends In …”
  • “Fossil Ready In …”
  • “Round Ended …”

Depending on the round’s state.

  • If the round is Open, it says “Auction Starts In …”
  • If the round is Auctioning, it says “Auction Ends in …”
  • If the round is Running && now is < settlement_date it shows “Round ends In …”
    • Before the round’s settlement date the user should know “round settles in x minutes”
  • If the round is Running && now is <= settlement date + FOSSIL_DELAY (15 min) it shows “Fossil Ready In …”
    • If the settlement date has been reached but fossil is not ready to be executed, the user should know when fossil will become ready
  • And finally if the round is Running && now > settlement date + FOSSIL_DELAY (or if the round is Settled) it shows “Round Ended …”

This text is confusing to the user, as well as the “…” portion. Currently, a helper function looks at the target date and now, it returns their difference in a DayHourMinute(SometimesSeconds) format, if now is > the target date it returns the same text but with a “-” in front. I.e., Auction Ends In 3H 30M || Auction Ends In -3H 30 M

This is confusing to the user. When the value is negative, it means the state transition could have happened 3 hours and 30 minutes ago, but hasnt yet (intending user action). Instead of this we should adjust the text/number outputs here so that it is intuitive to the user.

💡 “→” represents the tabbing/spacing/different columns on the UI

🏗️ Update the logic while the state is Open

  • If now < auctionStartDate, it should say “Auction Starts In → 3H 30M” (same as before)
  • If now ≥ auctionStartDate, should say “Auction Can Start → Now”

🏗️ Update the logic while the state is Auctioning

  • If now < auctionEndDate, it should say “Auction Ends In → 3H 30M” (same as before)
  • If now ≥ auctionEndDate, should say “Auction Can End → Now”

🏗️ Update the logic while the state is Running

  • If now < optionSettleDate, it should say “Round Ends In → 3H 30M” (same as before)
  • If now < optionSettleDate + FOSSIL_DELAY , it should say “Fossil Ready In → 14M 30S” (same as before)
  • Else (now ≥ optionSettleDate + FOSSIL_DELAY), it should say “Round Can End → Now”

🏗️ Update the logic while the state is Settled

  • Should say “Round Settled → 3h 30M ago”
@memarin
Copy link
Collaborator Author

memarin commented Jan 16, 2025

@eliotstock question on this

  • Alternative to saying “auction can start → now” is “auction could have started → 3H 30M ago”.
    • Unsure if this time is something the user will want at all, and if so maybe it could be behind a tooltip ?

@eliotstock
Copy link

I don't think we should introduce a tool tip just for this one state - too much complexity/inconsistency.

I suggest setting it to “just now” for 1 min after the point in time when the auction could start.

Then to “1 min ago” or whatever from then on. This is a pretty common UI pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants