fix: remove not used beacon address from storage

Author: waelsy123

contracts/tokenbridge/libraries/vault/MasterVaultFactory.sol

@@ -15,14 +15,13 @@ contract MasterVaultFactory is IMasterVaultFactory, OwnableUpgradeable {
     error ZeroAddress();
     error BeaconNotDeployed();
 
-    UpgradeableBeacon public beacon;
     BeaconProxyFactory public beaconProxyFactory;
 
     function initialize(address _owner) public initializer {
         _transferOwnership(_owner);
 
         MasterVault masterVaultImplementation = new MasterVault();
-        beacon = new UpgradeableBeacon(address(masterVaultImplementation));
+        UpgradeableBeacon beacon = new UpgradeableBeacon(address(masterVaultImplementation));
         beaconProxyFactory = new BeaconProxyFactory();
         beaconProxyFactory.initialize(address(beacon));
         beacon.transferOwnership(_owner);

test-foundry/libraries/vault/MasterVaultFactory.t.sol

@@ -72,23 +72,23 @@ contract MasterVaultFactoryTest is Test {
     }
 
     function test_beaconOwnership() public {
-        assertEq(factory.beacon().owner(), owner, "Beacon owner should be the factory owner");
+        assertEq(UpgradeableBeacon(factory.beaconProxyFactory().beacon()).owner(), owner, "Beacon owner should be the factory owner");
     }
 
     function test_ownerCanUpgradeBeacon() public {
         MasterVault newImplementation = new MasterVault();
 
-        UpgradeableBeacon beacon = factory.beacon();
+        UpgradeableBeacon beacon = UpgradeableBeacon(factory.beaconProxyFactory().beacon());
         vm.prank(owner);
         beacon.upgradeTo(address(newImplementation));
 
-        assertEq(factory.beacon().implementation(), address(newImplementation), "Beacon implementation should be updated");
+        assertEq(UpgradeableBeacon(factory.beaconProxyFactory().beacon()).implementation(), address(newImplementation), "Beacon implementation should be updated");
     }
 
     function test_nonOwnerCannotUpgradeBeacon() public {
         MasterVault newImplementation = new MasterVault();
 
-        UpgradeableBeacon beacon = factory.beacon();
+        UpgradeableBeacon beacon = UpgradeableBeacon(factory.beaconProxyFactory().beacon());
         vm.prank(user);
         vm.expectRevert("Ownable: caller is not the owner");
         beacon.upgradeTo(address(newImplementation));
@@ -102,11 +102,11 @@ contract MasterVaultFactoryTest is Test {
 
         MasterVault newImplementation = new MasterVault();
 
-        UpgradeableBeacon beacon = factory.beacon();
+        UpgradeableBeacon beacon = UpgradeableBeacon(factory.beaconProxyFactory().beacon());
         vm.prank(owner);
         beacon.upgradeTo(address(newImplementation));
 
-        assertEq(factory.beacon().implementation(), address(newImplementation), "Beacon should point to new implementation");
+        assertEq(UpgradeableBeacon(factory.beaconProxyFactory().beacon()).implementation(), address(newImplementation), "Beacon should point to new implementation");
 
         MasterVault(vault1).owner();
         MasterVault(vault2).owner();