Make it easier to stay logged in

[precipice]

Once a month I get logged out from DGS (and receive a notification that I've been logged out, which is helpful) and it takes me a day or two to remember to log back in. (I have a longer, random password stored in 1Password.)

I see from http://www.dragongoserver.net/forum/read.php?forum=3&thread=2738 that JUG on DGS wants the password to expire, though I disagree with the reasons given. My preference would be to get the login password once, store it in Keychain, and if the session expires, automatically provide it to DGS to get a new cookie, without the user having to do anything. However, I can see problems with this (I believe push notifications stop when the cookie expires; we could renew it at 25 days or something but that still doesn't cover all cases), and you might be prompting for the password again intentionally to conform to JUG's goals.

Another possibility would be to add support for 1Password to the login screen. AgileBits provides an extension for iOS apps that want to do this: https://github.com/AgileBits/onepassword-app-extension A good number of apps already do: https://blog.agilebits.com/1password-apps/ This would at least solve my problem, though I don't know if you consider it a general enough thing to include in the app.

If you're open to it, I'll integrate the AgileBits extension, add a 1Password icon to the login screen somewhere (hopefully) unobtrusive, and send a pull request. Let me know what you think.

[precipice]

Looks like I can add this so that the button only appears for people who have 1Password installed, which seems pretty good to me. I'm working on a PR.

[justinweiss]

Sorry this took so long to get to — it’s been a loooong few weeks!

I worked on something like this a while back, although I was trying to get it to forcibly refresh the cookie. That didn’t work :-)

This seems more reasonable:

My preference would be to get the login password once, store it in Keychain, and if the session expires, automatically provide it to DGS to get a new cookie, without the user having to do anything.

If it works, I’d be totally OK with it. As long as you’re storing it in secure storage, and it’s not being sent around anywhere, it’s fine with me. I just don’t want to have to worry about it on my server :-)

1password support would be great. It’s been on my list to add, but never near the top!

On May 23, 2016, at 10:11 AM, Marc Hedlund notifications@github.com wrote:

Once a month I get logged out from DGS (and receive a notification that I've been logged out, which is helpful) and it takes me a day or two to remember to log back in. (I have a longer, random password stored in 1Password.)

I see from http://www.dragongoserver.net/forum/read.php?forum=3&thread=2738 http://www.dragongoserver.net/forum/read.php?forum=3&thread=2738 that JUG on DGS wants the password to expire, though I disagree with the reasons given. My preference would be to get the login password once, store it in Keychain, and if the session expires, automatically provide it to DGS to get a new cookie, without the user having to do anything. However, I can see problems with this (I believe push notifications stop when the cookie expires; we could renew it at 25 days or something but that still doesn't cover all cases), and you might be prompting for the password again intentionally to conform to JUG's goals.

Another possibility would be to add support for 1Password to the login screen. AgileBits provides an extension for iOS apps that want to do this: https://github.com/AgileBits/onepassword-app-extension https://github.com/AgileBits/onepassword-app-extension A good number of apps already do: https://blog.agilebits.com/1password-apps/ https://blog.agilebits.com/1password-apps/ This would at least solve my problem, though I don't know if you consider it a general enough thing to include in the app.

If you're open to it, I'll integrate the AgileBits extension, add a 1Password icon to the login screen somewhere (hopefully) unobtrusive, and send a pull request. Let me know what you think.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub https://github.com/justinweiss/dragongoclient/issues/24

[precipice]

No worries! I know that, among other things, you've been busy kicking my butt at Go. 😄

I've started in on 1Password support and have it working pretty well. I'm trying to add it to the login screen without messing up TextCell overly much, but that's taking a bit more work (it took me a while to figure out what was going on with that class). Once I have the 1P icon added in, I'll send a pull request for that as a separate feature.

After that I'll look at the Keychain refresh approach. They don't seem like exclusive additions to me (I'd rather have both 1Password login for people who use it, and Keychain refresh for everyone).

Thanks!

[justinweiss]

Those custom cells are kind of a disaster. I spent about two days trying to get TextCell to work with AutoLayout :-/

Makes sense about trying both — thanks for looking at it!

On Jun 8, 2016, at 11:25 PM, Marc Hedlund notifications@github.com wrote:

No worries! I know that, among other things, you've been busy kicking my butt at Go. 😄

I've started in on 1Password support and have it working pretty well. I'm trying to add it to the login screen without messing up TextCell overly much, but that's taking a bit more work (it took me a while to figure out what was going on with that class). Once I have the 1P icon added in, I'll send a pull request for that as a separate feature.

After that I'll look at the Keychain refresh approach. They don't seem like exclusive additions to me (I'd rather have both 1Password login for people who use it, and Keychain refresh for everyone).

Thanks!

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/justinweiss/dragongoclient/issues/24#issuecomment-224810477, or mute the thread https://github.com/notifications/unsubscribe/AAAD_BvBzOQwb1nthao0gx7dGK_qv1o-ks5qJ7H2gaJpZM4IkrcR.