Restructure PythonBridge runtime

So that there isn't a circular symbolic link and it is possible to
easily copy just the runtime files without copying the entire git
repository.

Issue: feenkcom/gtoolkit#1936

Author: akgrant43

Pipfile renamed to PythonBridgeRuntime/Pipfile

@@ -37,9 +37,9 @@ PBPharoPlatform class >> weakRegistryClass [
 { #category : #private }
 PBPharoPlatform >> copyApplicationTo: appFolder application: application [
 	"Copy the PythonBridge runtime environment to the specified folder"
-	| srcDir cpCommand proc pbSymLink srcFilename dstFilename |
+	| srcDir cpCommand proc srcFilename dstFilename |
 
-	srcDir := FileLocator imageDirectory / 'PythonBridge'.
+	srcDir := FileLocator imageDirectory / 'PythonBridgeRuntime'.
 	(srcDir exists and: [ srcDir ~= appFolder ]) ifFalse: 
 		[ srcDir := self folderForApplication: application ].
 	srcDir exists ifFalse: 
@@ -60,28 +60,9 @@ PBPharoPlatform >> copyApplicationTo: appFolder application: application [
 		runAndWait.
 	proc isSuccess ifFalse:
 		[ self error: 'Unable to install PythonBridge runtime' ].
-	"Remove the existing symlink, which probably points to the source folder.
-	FileReference>>delete doesn't handle symbolic links, so use the lower layer"
-	pbSymLink := (appFolder / 'PythonBridge') resolve.
-	pbSymLink exists ifTrue: 
-		[ pbSymLink isSymlink 
-			ifTrue: [ self removeFile: pbSymLink ]
-			ifFalse: [ self error: 'PythonBridge should be a symbolic link' ] ].
 
 ]
 
-{ #category : #'private - symlinks' }
-PBPharoPlatform >> createSymlinkFor: originalFile on: targetFile [
-	OSSUnixSubprocess new
-				command: '/bin/ln';
-				arguments: (Array 
-									with: '-s' 
-									with: originalFile asFileReference fullName 
-									with: targetFile asFileReference fullName);
-				terminateOnShutdown;
-				runAndWaitOnExitDo: [ :command | ^ self ].
-]
-
 { #category : #'message broker strategy' }
 PBPharoPlatform >> defaultMessageBrokerClass [
 	^ self class socketMessageBrokerClass
@@ -94,7 +75,7 @@ PBPharoPlatform >> ensureApplicationDirectory: application [
 	appFolder := application workingDirectory.
 	(appFolder / 'PythonBridge') exists ifTrue: [ ^ self ].
 	self copyApplicationTo: appFolder application: application.
-	self ensurePBridge: (self folderForApplication: application class baseApplication) symlinkIn: appFolder.
+
 ]
 
 { #category : #private }
@@ -104,30 +85,14 @@ PBPharoPlatform >> ensureEnvironmentForApp: anApplication [
 	self installEnvironmentForApp: anApplication.
 ]
 
-{ #category : #'private - symlinks' }
-PBPharoPlatform >> ensureFolderSymlinkFor: aFolder [
-	| symlinkRef |
-	symlinkRef := aFolder basename asFileReference.
-	symlinkRef exists ifFalse: [ 
-		self createSymlinkFor: aFolder on: symlinkRef ]
-]
-
-{ #category : #'private - symlinks' }
-PBPharoPlatform >> ensurePBridge: pbridgeFolder symlinkIn: aFolder [
-	| symlinkRef |
-	symlinkRef := aFolder / 'PythonBridge'.
-	symlinkRef exists ifFalse: [ 
-		self createSymlinkFor: aFolder on: symlinkRef ].
-]
-
 { #category : #utils }
 PBPharoPlatform >> folderForApplication: application [
 	^ (IceRepository registry 
 			detect: [ :each | each includesPackageNamed: application class package name ] 
 			ifNone: [ 
 				self inform: 'Please add a clone of this project to Iceberg to access to the resources'.
 				"For travis!"
-				^ '.' asFileReference ]) location
+				^ '.' asFileReference ]) location / 'PythonBridgeRuntime'
 ]
 
 { #category : #utils }
@@ -173,20 +138,6 @@ PBPharoPlatform >> pipenvForApplication: application [
 		[ self class pipenvProcessClass pipenvPath ]
 ]
 
-{ #category : #'private - symlinks' }
-PBPharoPlatform >> removeFile: aFileReference [
-	"Use the OS rm command to remove the specified file.
-	Required since the file system primitive doesn't seem to handle symbolic links"
-	| proc |
-
-	proc := OSSUnixSubprocess new
-		command: 'rm';
-		arguments: { aFileReference fullName };
-		runAndWait.
-	proc isSuccess ifFalse: 
-		[ self error: 'Unable to remove: ', aFileReference fullName ]
-]
-
 { #category : #accessing }
 PBPharoPlatform >> runtimeFolder [
 	"Answer the directory where the PythonBridge runtime files are located"

__init__.py renamed to PythonBridgeRuntime/PythonBridge/__init__.py

@@ -84,7 +84,7 @@ PBApplication class >> resetUniqueInstance [
 PBApplication class >> runtimeDirectory [
 	"This is the directory basename where the runtime files are located"
 
-	^ 'PythonBridge'
+	^ 'PythonBridgeRuntime'
 ]
 
 { #category : #instructions }