Test suite can't run on a fresh clone: pytest-mock is used but never declared

[khldLabs]

Description

Following the dev setup in CONTRIBUTING.md on a fresh clone leaves the test suite unable to run one of its tests. CONTRIBUTING.md (lines 137-138) says to run pip install -e . and pip install -r requirements.txt, then (line 164) pytest tests/. Neither install declares pytest-mock, but tests/test_compose_scanner.py::test_compose_orchestrator_offline requests the mocker fixture, so it errors out for every new contributor. CI doesn't catch this because .github/workflows/coverage.yml (line 29) and .github/workflows/python-app.yml (line 57) each pip install pytest pytest-mock inline, so the dependency is satisfied there but declared nowhere.

Repro on a clean checkout:

$ python -m venv .venv && . .venv/bin/activate
$ pip install -e .
$ pip install -r requirements.txt
$ pytest tests/
...
ERROR at setup of test_compose_orchestrator_offline
file tests/test_compose_scanner.py, line 132
  def test_compose_orchestrator_offline(valid_compose_file, mocker):
E       fixture 'mocker' not found
...
179 passed, 1 error

pip install pytest-mock fixes it, and the suite goes fully green (180 passed).

Proposed fix

Declare the test dependencies rather than installing them ad hoc in CI: add an extras_require={"dev": ["pytest", "pytest-cov", "pytest-mock"]} to setup.py, point CONTRIBUTING.md at pip install -e ".[dev]", and let the two workflows install the same extra instead of listing packages inline. That keeps the contributor path and the CI path from drifting apart again. Happy to open a PR for this if it sounds right — it's a small change and I'd rather not guess at the exact extra name you'd prefer (dev vs test).

[rksharma-owg]

I reproduced this locally on a fresh checkout.

Using the current contributor path:

python3 -m venv .venv
. .venv/bin/activate
pip install -e .
pip install -r requirements.txt
pip install pytest
pytest tests/test_compose_scanner.py::test_compose_orchestrator_offline -q

I get the same failure:

E       fixture 'mocker' not found

A couple of repo-specific details from the repro:

• tests/test_compose_scanner.py uses the mocker fixture in test_compose_orchestrator_offline.
• CONTRIBUTING.md currently tells contributors to install pytest pytest-cov black isort flake8 mypy, but not pytest-mock.
• python-app.yml installs pytest pytest-mock inline just before tests.
• coverage.yml installs pytest pytest-cov pytest-mock inline.

So the issue is real, but the drift is slightly wider than just requirements.txt: the test dependency is also missing from the documented dev install path.

My suggestion would be to define test/dev extras in packaging and have both docs and CI use the same source of truth, e.g. something like:

• extras_require={"dev": ["pytest", "pytest-cov", "pytest-mock", "black", "isort", "flake8", "mypy"]} in setup.py
• update CONTRIBUTING.md to use pip install -e ".[dev]"
• update the workflows to install .[dev] instead of listing test packages inline

That keeps contributor setup and CI from drifting again the next time a test plugin gets added.

[ShrijalDubey]

Hi, I'd like to try working on this issue. Can I be assigned?