Question: how to name new firmware in the code

[clanganke]

1st of all: thanx for a great library!

I just buyed a version similar to other RFID boards at

https://www.amazon.de/dp/B0DLGVNX93

however the photo there does not match, so I attach one.

The board works well with the extra SPI mode/timing configuration. as show in the comment of the examples. However, the firmware reports version byte 0x82, and, of course, the firmware program data is different.

Just for info: the cards/chips get reported as
Card SAK: 08
PICC type: MIFARE 1KB

As a temporary patch I added respective symbols and data so that communication and self test works just fine. Certainly I would provide a pull request. However, as the chip has got no type info printed on it, I have got no clue how to name the symbols or provide literals (where I put ???? here in pseudo code):

src\MFRC522Constants.h:

   symbol PCD_Version::Version_????

src\MFRC522Debug.cpp

  MFRC522Debug::PCD_DumpVersionToSerial
    switch(version) 
      case 0x82:
      logPrint.println(F(" = ????"));
      break;

src\MFRC522v2.h

  const byte Private_????_firmware_reference[]

Moreover, the version information v133 on the board may or may not refer to the chip. What would be the best way to name that firmware? Is there any method to safely identify the chip further?

[clanganke]

Just noticed that the default SPI timing works with your library and that above MFRC522 board as well, and that my above statement on the special SPI timing was caused by a misconception on my side.

I just tested that successfully with

• Arduino nano V3
• Wemos D1 mini
• Wemos D1 mini ESP32

with their respective package, within Arduino IDE.