-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] grass.jupyter.TimeSeriesMap incorrect layer rendering #5304
Comments
I am close to solve this , can guide me so I can contribute.. |
Well, you need to understand the code in python/grass/jupyter/baseseriesmap.py and timeseriesmap.py to be able to solve this. I would start with trying to reproduce the problem. But if you are close to solving this, I am not sure what guidance specifically do you need? |
@petrasovaa I only have two questions Should layer removal (to prevent stale layers) happen in TimeSeriesMap._render() or baseseriesmap.py’s _update_figure()? Are there existing functions to track/remove layers by timestep, or do I need to implement new logic. |
I don't know what is the root cause, I didn't investigate. What do you mean with stale layers? I don't see why you need to remove any layers. |
@petrasovaa I think layer cleanup should happen in TimeSeriesMap._render() so we don’t accidentally break other parts of baseseriesmap.py. The goal is to only remove layers added by add_raster_series or add_vector_series (like temporary rainfall maps) while leaving static layers (e.g., a base map) untouched. The bug seems to happen because those temporary layers aren’t fully cleaned up between timesteps, not because of rendering order. Here’s what I’ve tried: Reproduced the issue- When rendering timesteps, old layers stick around and overlap new ones. |
Why don't you make a draft PR and I will look at it, without seeing the code I can't tell. |
@petrasovaa Yes, I'll do it shortly. |
Describe the bug
TimeSeriesMap is not rendering the layers correctly.
To reproduce
In doc/examples/notebooks/temporal.ipynb this example results in incorrect rendering:
Expected behavior
The boundary layer and scalebar should be visible.
System description
This is in main branch only.
Additional context
Probably caused by some changes during last year GSoC. SeriesMap which has the same base class as TimeSeriesMap is working fine.
The text was updated successfully, but these errors were encountered: