Skip to content

Conversation

@LJBabbage
Copy link
Contributor

@LJBabbage LJBabbage commented Nov 27, 2024

What and why?

This PR integrates the new respondent and enrolment endpoints

How to test?

The new respondent and enrolment endpoints are used in 15 places. To cover them all you need to

  1. Login to an account with an enrolment
  2. Go to my account and change your name
  3. Go back to my account and change your email, and accept the change
  4. Share access to a ce to a new respondent, and accept by the respondent
  5. Share access to a ce to respondent that already exists and accept by the respondent
  6. Transfer a survey (i.e I am no longer required to complete any surveys in my accounts) and accept by the respondent
  7. Open an survey for an eQ
  8. Delete your account

Care must be taken when go from one account to another as the session will be wrong, it's best to logout in each instance.

N.B I have checked each scenario, it might be a case of allowing the business testers to do the manual checks and focus on the code

Jira

@SteveScorfield
Copy link
Contributor

/deploy scorfs

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: scorfs

  • tag: pr-1012

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

@anwilkie
Copy link
Contributor

anwilkie commented Dec 2, 2024

/deploy wilkia

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: wilkia

  • tag: pr-1012

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

Copy link
Contributor

@arroyoAle arroyoAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine and works fine, just one comment around a function thats not used anymore

Copy link
Contributor

@SteveScorfield SteveScorfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as agreed with Lewis. Works fine and code looks good. Approved.

@LJBabbage LJBabbage merged commit 50075d6 into main Dec 3, 2024
3 checks passed
@LJBabbage LJBabbage deleted the integrate-new-respondent-enrolment-end-points branch December 3, 2024 10:39
@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: scorfs

  • tag: pr-1012

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: scorfs;

  • tag: pr-1012

  • configBranch: main

  • paramKey: curl

  • paramValue: undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants