Skip to content

DQD sql errors reported as passed #520

@MaximMoinat

Description

@MaximMoinat

Describe the bug
DQD checks that have resulted in an SQL error are reported as passed in the ARES DQD Overview and Results pages.

Expected behavior
A DQD check has three variables describing the status, failed, passed, isError. These are mutually exclusive. A check that resulted in an error will have values `{..., failed=0, passed=0, isError=1}.

Looking at the source code, all checks that have 'failed' = 0 are interpreted as PASS.

for (let i = 0; i < data.length; i++) {
if (data[i].failed == 0) {
data[i].failed = "PASS";
} else {
data[i].failed = "FAIL";
}

This should be

 if (data[i].passed == 1) { 
     data[i].failed = "PASS"; 
   } (data[i].failed == 1) { 
     data[i].failed = "FAIL"; 
   } 

The overview should report the number of errors as well (see screenshots DQD shiny app below).

Screenshots
Below screenshots of same result in Ares and the DQD native Shiny app:

Page Ares DQD Shiny app
Overview Image
4082 passes, 71 fails
Image
4044 passes, 109 fails, 38 errors
Results Image Image

Additional context
First wrongly reported as a DQD issue: OHDSI/DataQualityDashboard#597

Metadata

Metadata

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions