Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Make pot and rebel modules compatility #294

Open
legalsylvain opened this issue Feb 3, 2025 · 0 comments
Open

[RFC] Make pot and rebel modules compatility #294

legalsylvain opened this issue Feb 3, 2025 · 0 comments

Comments

@legalsylvain
Copy link
Contributor

legalsylvain commented Feb 3, 2025

context of the issue :

  • the repo OCA/account-invoicing contains various modules and since the start, two are incompatibles by design (account_invoice_triple_discount and account_invoice_fixed_discount).
  • however that incompatibility is not set in the rebel_module_groups key of the copier answer
  • In a huge refactoring (V16 PR) of the module account_invoice_triple_discount done by @grindtildeath it is now mandatory to set is as rebel to make the tests working.

The CI is green, but when trying to merge, the CI is stuck, because of weird behaviour of make_pot generation.

Image

Image

@pedrobaeza proposed here to make the modules compatible. However it is not possible, by design.

Question

  • Is rebel_module_groups deprecated ?
  • If not, how can we move forward ?

thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant