Migration to version 18.0

[OCA-git-bot]

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

Modules to migrate

• intrastat_base
• intrastat_product - By @alexis-via - [18.0][MIG] intrastat_product #298
• intrastat_product_generic
• intrastat_product_hscodes_import
• product_harmonized_system - By @LucasTran380381 - [18.0][MIG] product_harmonized_system: Migration to 18.0 #288
• product_harmonized_system_delivery - By @LucasTran380381 - [18.0][MIG] product_harmonized_system_delivery: Migration to 18.0 #290
• product_harmonized_system_stock - By @LucasTran380381 - [18.0][MIG] product_harmonized_system_stock: Migration to 18.0 #289

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

[LucasTran380381]

Migration product_harmonized_system #288
Migration product_harmonized_system_delivery #290
Migration product_harmonized_system_stock #289

[alexis-via]

How do we handle the new product type "combo" ?
https://github.com/odoo/odoo/blob/18.0/addons/product/models/product_template.py#L64
How are we supposed to know if it's a product or a service ?
I must say I didn't investigate the real usage a this new type...

[pedrobaeza]

I think that as soon as a product is included in the combo, it should be included in the Intrastat declaration.

[alexis-via]

I studied more in depth the combo type of odoo v18.
First, when you add a product with type = "combo" in sale.order.line, it is replaced by the item lines of the combo. So, in the end, you don't have any product with type="combo" in your sale.order.line/invoice lines.
But, if you create an invoice manually, you can add a product with type="combo" in your invoice lines.
So, it is not common to have a product with type="combo" in the invoice lines, but it's possible.

I propose the following for intrastat:
in intrastat_base, we add a selection computed field "intrastat_type" that has 2 possible values : "product" or "service". The computation method will implement the following:

• if type = "consu" => intrastat_type = "product"
• if type = "service" => intrastat_type = "service"
• if type = "combo" -> loop on product.combo and related product.combo.lines -> if one of the product has type = "consu" then intrastat_type = "product" ; otherwise "service". It means that, to consider a combo product as a service, ALL the combo items of its product.combos must be "service" products.
  If someone wants another behavior, he will be able to inherit the compute method of "intrastat_type". Or we can set the field intrastat_type as readonly=False and display it in the product form view to allow users to configure it manually on products.

[alexis-via]

My proposal above on intrastat_type is now fully implemented in intrastat_base, intrastat_product and l10n_fr_intrastat_product.