-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to version 16.0 #194
Comments
Decided by @luc-demeyer and me: |
Decided by @luc-demeyer and me: The 4 fields intrastat_transaction_out_invoice, intrastat_transaction_out_refund, intrastat_transaction_in_invoice, intrastat_transaction_in_refund on res.company are replaced by 2 fields intrastat_transaction_b2b_id and intrastat_transaction_b2c_id. Field nature of transaction (11, 12, ...) is set on the "code" field of intrastat.transaction. Up until v15, l10n_fr_intrastat_product has "code régime" (11, 21, 25, ...) in the code field on intrastat.transaction and the nature of the transaction (11, 12) in the field "fr_transaction_code" defined in l10n_fr_intrastat_product. In v16, the data must be updated to have the nature of transaction in the "code" field of intrastat.transaction. Do I still need a field for "code régime" ? Maybe it can be deducted from the nature of transaction and the arrival/departure ? Maybe I could set the field "code régime" on the intrastat compute line and not on intrastat.transaction ? |
If it is confirmed that the HS nomenclature is the same between all countries, we should move the HS Code import wizard from l10n_be_intrastat_product to intrastat_product (TODO @luc-demeyer ) |
This PR (for v14) is a sort of "proposal" for v16 #198 I would like it to be the basis for the v16 port. |
In v16, if we move the datas of intrastat.transaction from the localisation modules to intrastat_product, we should remove the company_id field on this object. I really think this object doesn't need a company_id field. |
@alexis-via An overview of intrastat accross the different countries, cf. https://ec.europa.eu/eurostat/documents/3859598/12889594/KS-GQ-21-011-EN-N.pdf/4ffbf688-0ffa-5223-f7a5-c784d3873750?t=1623747004138 |
We could keep the company_id field on intrastat.transaction and set the company_id field to False by default. |
I'm porting intrastat_product to v16 and integrating the nature of transaction codes in the module intrastat_product : @luc-demeyer do you have a link to an official doc that has the nature of transaction codes in English ? I have them in French, but not in English. |
I eventually found this https://www.nbb.be/doc/dd/onegate/data/new_natures_of_transaction_2022_en.pdf |
Instead 2 fields intrastat_transaction_b2b_id and intrastat_transaction_b2c_id (see earlier comment), I propose to convert the "intrastat" field of fiscal position from a boolean to a selection field with 3 possible values:
Then, we'll be able to set the proper default value by using XMLIDs :
|
@alexis-via |
This migration has been made from the v14 branch akretion/14-brexit-simplification-and-type-on-fp and the changes of v15 has been re-integrated. As discussed on OCA#194 the intrastat transaction codes are now integrated in the module intrastat_product The default value for transaction_id depending on the move_type of the invoice have been dropped on fiscal position and company: Odoo sets 11 when fiscal position is B2B and 12 when fiscal position is B2C. As a consequence: intrastat.transaction: company_id = False by default Use textwrap for name_get() of intrastat.transaction partner_id on computation line is not a related field any more: it allows to auto-fill VAT from partner_id when creating a line manually. computation and declaration line tree view: display transaction code instead of transaction_id to save space
This migration started from the v14 branch akretion/14-emebi-simplify It includes the changes discussed in OCA/intrastat-extrastat#194 in particular the fact that intrastat transaction are now provided by the generic module intrastat_product. This change involve one big change: BEFORE: code regime = transaction_id.code ; nature de transaction = transaction_id.fr_transaction_code AFTER: code regime = fr_regime_id.code ; nature de transaction = transaction_id.code Adapt to changes in intrastat_base with the 'intrastat' field of fiscal position converted from boolean to selection with 3 possible values b2b/b2c/no
I have implemented what has been discussed here for v16. PRs are ready. |
BTW, the merge of v16 modules is blocked because of environment issues. If someone knows how to solve this... see error on #207 |
This migration has been made from the v14 branch akretion/14-brexit-simplification-and-type-on-fp and the changes of v15 has been re-integrated. As discussed on OCA#194 the intrastat transaction codes are now integrated in the module intrastat_product The default value for transaction_id depending on the move_type of the invoice have been dropped on fiscal position and company: Odoo sets 11 when fiscal position is B2B and 12 when fiscal position is B2C. As a consequence: intrastat.transaction: company_id = False by default Use textwrap for name_get() of intrastat.transaction partner_id on computation line is not a related field any more: it allows to auto-fill VAT from partner_id when creating a line manually. computation and declaration line tree view: display transaction code instead of transaction_id to save space
This migration started from the v14 branch akretion/14-emebi-simplify It includes the changes discussed in OCA/intrastat-extrastat#194 in particular the fact that intrastat transaction are now provided by the generic module intrastat_product. This change involve one big change: BEFORE: code regime = transaction_id.code ; nature de transaction = transaction_id.fr_transaction_code AFTER: code regime = fr_regime_id.code ; nature de transaction = transaction_id.code Adapt to changes in intrastat_base with the 'intrastat' field of fiscal position converted from boolean to selection with 3 possible values b2b/b2c/no
This migration started from the v14 branch akretion/14-emebi-simplify It includes the changes discussed in OCA/intrastat-extrastat#194 in particular the fact that intrastat transaction are now provided by the generic module intrastat_product. This change involve one big change: BEFORE: code regime = transaction_id.code ; nature de transaction = transaction_id.fr_transaction_code AFTER: code regime = fr_regime_id.code ; nature de transaction = transaction_id.code Adapt to changes in intrastat_base with the 'intrastat' field of fiscal position converted from boolean to selection with 3 possible values b2b/b2c/no
This migration has been made from the v14 branch akretion/14-brexit-simplification-and-type-on-fp and the changes of v15 has been re-integrated. As discussed on OCA#194 the intrastat transaction codes are now integrated in the module intrastat_product The default value for transaction_id depending on the move_type of the invoice have been dropped on fiscal position and company: Odoo sets 11 when fiscal position is B2B and 12 when fiscal position is B2C. As a consequence: intrastat.transaction: company_id = False by default Use textwrap for name_get() of intrastat.transaction partner_id on computation line is not a related field any more: it allows to auto-fill VAT from partner_id when creating a line manually. computation and declaration line tree view: display transaction code instead of transaction_id to save space
This migration has been made from the v14 branch akretion/14-brexit-simplification-and-type-on-fp and the changes of v15 has been re-integrated. As discussed on OCA#194 the intrastat transaction codes are now integrated in the module intrastat_product The default value for transaction_id depending on the move_type of the invoice have been dropped on fiscal position and company: Odoo sets 11 when fiscal position is B2B and 12 when fiscal position is B2C. As a consequence: intrastat.transaction: company_id = False by default Use textwrap for name_get() of intrastat.transaction partner_id on computation line is not a related field any more: it allows to auto-fill VAT from partner_id when creating a line manually. computation and declaration line tree view: display transaction code instead of transaction_id to save space
This migration has been made from the v14 branch akretion/14-brexit-simplification-and-type-on-fp and the changes of v15 has been re-integrated. As discussed on OCA#194 the intrastat transaction codes are now integrated in the module intrastat_product The default value for transaction_id depending on the move_type of the invoice have been dropped on fiscal position and company: Odoo sets 11 when fiscal position is B2B and 12 when fiscal position is B2C. As a consequence: intrastat.transaction: company_id = False by default Use textwrap for name_get() of intrastat.transaction partner_id on computation line is not a related field any more: it allows to auto-fill VAT from partner_id when creating a line manually. computation and declaration line tree view: display transaction code instead of transaction_id to save space
This migration has been made from the v14 branch akretion/14-brexit-simplification-and-type-on-fp and the changes of v15 has been re-integrated. As discussed on OCA#194 the intrastat transaction codes are now integrated in the module intrastat_product The default value for transaction_id depending on the move_type of the invoice have been dropped on fiscal position and company: Odoo sets 11 when fiscal position is B2B and 12 when fiscal position is B2C. As a consequence: intrastat.transaction: company_id = False by default Use textwrap for name_get() of intrastat.transaction partner_id on computation line is not a related field any more: it allows to auto-fill VAT from partner_id when creating a line manually. computation and declaration line tree view: display transaction code instead of transaction_id to save space
This migration started from the v14 branch akretion/14-emebi-simplify It includes the changes discussed in OCA/intrastat-extrastat#194 in particular the fact that intrastat transaction are now provided by the generic module intrastat_product. This change involve one big change: BEFORE: code regime = transaction_id.code ; nature de transaction = transaction_id.fr_transaction_code AFTER: code regime = fr_regime_id.code ; nature de transaction = transaction_id.code Adapt to changes in intrastat_base with the 'intrastat' field of fiscal position converted from boolean to selection with 3 possible values b2b/b2c/no
This migration has been made from the v14 branch akretion/14-brexit-simplification-and-type-on-fp and the changes of v15 has been re-integrated. As discussed on OCA#194 the intrastat transaction codes are now integrated in the module intrastat_product The default value for transaction_id depending on the move_type of the invoice have been dropped on fiscal position and company: Odoo sets 11 when fiscal position is B2B and 12 when fiscal position is B2C. As a consequence: intrastat.transaction: company_id = False by default Use textwrap for name_get() of intrastat.transaction partner_id on computation line is not a related field any more: it allows to auto-fill VAT from partner_id when creating a line manually. computation and declaration line tree view: display transaction code instead of transaction_id to save space
This migration started from the v14 branch akretion/14-emebi-simplify It includes the changes discussed in OCA/intrastat-extrastat#194 in particular the fact that intrastat transaction are now provided by the generic module intrastat_product. This change involve one big change: BEFORE: code regime = transaction_id.code ; nature de transaction = transaction_id.fr_transaction_code AFTER: code regime = fr_regime_id.code ; nature de transaction = transaction_id.code Adapt to changes in intrastat_base with the 'intrastat' field of fiscal position converted from boolean to selection with 3 possible values b2b/b2c/no
This migration has been made from the v14 branch akretion/14-brexit-simplification-and-type-on-fp and the changes of v15 has been re-integrated. As discussed on OCA#194 the intrastat transaction codes are now integrated in the module intrastat_product The default value for transaction_id depending on the move_type of the invoice have been dropped on fiscal position and company: Odoo sets 11 when fiscal position is B2B and 12 when fiscal position is B2C. As a consequence: intrastat.transaction: company_id = False by default Use textwrap for name_get() of intrastat.transaction partner_id on computation line is not a related field any more: it allows to auto-fill VAT from partner_id when creating a line manually. computation and declaration line tree view: display transaction code instead of transaction_id to save space
This migration started from the v14 branch akretion/14-emebi-simplify It includes the changes discussed in OCA/intrastat-extrastat#194 in particular the fact that intrastat transaction are now provided by the generic module intrastat_product. This change involve one big change: BEFORE: code regime = transaction_id.code ; nature de transaction = transaction_id.fr_transaction_code AFTER: code regime = fr_regime_id.code ; nature de transaction = transaction_id.code Adapt to changes in intrastat_base with the 'intrastat' field of fiscal position converted from boolean to selection with 3 possible values b2b/b2c/no
Todo
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0
Modules to migrate
Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list
The text was updated successfully, but these errors were encountered: