Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to version 16.0 #194

Open
3 tasks
sbidoul opened this issue Oct 3, 2022 · 13 comments
Open
3 tasks

Migration to version 16.0 #194

sbidoul opened this issue Oct 3, 2022 · 13 comments
Labels
help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress
Milestone

Comments

@sbidoul
Copy link
Member

sbidoul commented Oct 3, 2022

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

Modules to migrate

  • intrastat_base
  • intrastat_product
  • product_harmonized_system

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

@sbidoul sbidoul added help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress labels Oct 3, 2022
@sbidoul sbidoul added this to the 16.0 milestone Oct 3, 2022
@alexis-via
Copy link
Contributor

Decided by @luc-demeyer and me:
In v16, the datas of intrastat.transaction with 2 digits must be moved for localisation modules to the module intrastat_product

@alexis-via
Copy link
Contributor

alexis-via commented Oct 11, 2022

Decided by @luc-demeyer and me:

The 4 fields intrastat_transaction_out_invoice, intrastat_transaction_out_refund, intrastat_transaction_in_invoice, intrastat_transaction_in_refund on res.company are replaced by 2 fields intrastat_transaction_b2b_id and intrastat_transaction_b2c_id.

Field nature of transaction (11, 12, ...) is set on the "code" field of intrastat.transaction. Up until v15, l10n_fr_intrastat_product has "code régime" (11, 21, 25, ...) in the code field on intrastat.transaction and the nature of the transaction (11, 12) in the field "fr_transaction_code" defined in l10n_fr_intrastat_product. In v16, the data must be updated to have the nature of transaction in the "code" field of intrastat.transaction. Do I still need a field for "code régime" ? Maybe it can be deducted from the nature of transaction and the arrival/departure ? Maybe I could set the field "code régime" on the intrastat compute line and not on intrastat.transaction ?

@alexis-via
Copy link
Contributor

If it is confirmed that the HS nomenclature is the same between all countries, we should move the HS Code import wizard from l10n_be_intrastat_product to intrastat_product (TODO @luc-demeyer )

@alexis-via
Copy link
Contributor

This PR (for v14) is a sort of "proposal" for v16 #198 I would like it to be the basis for the v16 port.

@alexis-via
Copy link
Contributor

In v16, if we move the datas of intrastat.transaction from the localisation modules to intrastat_product, we should remove the company_id field on this object. I really think this object doesn't need a company_id field.

@luc-demeyer
Copy link
Contributor

@alexis-via
based upon my current understanding of the transaction codes in various EU countries I tend to agree,
But when I look to https://github.com/OCA/l10n-italy/blob/14.0/l10n_it_intrastat (module not based upon intrastat_product) than I see different transaction does in Italy, hence maybe we should keep the field.

An overview of intrastat accross the different countries, cf. https://ec.europa.eu/eurostat/documents/3859598/12889594/KS-GQ-21-011-EN-N.pdf/4ffbf688-0ffa-5223-f7a5-c784d3873750?t=1623747004138

@alexis-via
Copy link
Contributor

We could keep the company_id field on intrastat.transaction and set the company_id field to False by default.

@alexis-via
Copy link
Contributor

I'm porting intrastat_product to v16 and integrating the nature of transaction codes in the module intrastat_product : @luc-demeyer do you have a link to an official doc that has the nature of transaction codes in English ? I have them in French, but not in English.

@alexis-via
Copy link
Contributor

@alexis-via
Copy link
Contributor

alexis-via commented Feb 7, 2023

Instead 2 fields intrastat_transaction_b2b_id and intrastat_transaction_b2c_id (see earlier comment), I propose to convert the "intrastat" field of fiscal position from a boolean to a selection field with 3 possible values:

  • B2B
  • B2C
  • None

Then, we'll be able to set the proper default value by using XMLIDs :

  • intrastat_product.intrastat_transaction_11
  • intrastat_product.intrastat_transaction_12

@luc-demeyer
Copy link
Contributor

alexis-via added a commit to akretion/intrastat-extrastat that referenced this issue Feb 8, 2023
This migration has been made from the v14 branch akretion/14-brexit-simplification-and-type-on-fp and the changes of v15 has been re-integrated.

As discussed on OCA#194
the intrastat transaction codes are now integrated in the module intrastat_product

The default value for transaction_id depending on the move_type of the
invoice have been dropped on fiscal position and company: Odoo sets 11
when fiscal position is B2B and 12 when fiscal position is B2C.
As a consequence: intrastat.transaction: company_id = False by default

Use textwrap for name_get() of intrastat.transaction

partner_id on computation line is not a related field any more: it allows
to auto-fill VAT from partner_id when creating a line manually.

computation and declaration line tree view: display transaction code
instead of transaction_id to save space
alexis-via added a commit to akretion/l10n-france that referenced this issue Feb 8, 2023
This migration started from the v14 branch akretion/14-emebi-simplify
It includes the changes discussed in
OCA/intrastat-extrastat#194 in particular the
fact that intrastat transaction are now provided by the generic module
intrastat_product.
This change involve one big change:
BEFORE: code regime = transaction_id.code ; nature de transaction =
transaction_id.fr_transaction_code
AFTER: code regime = fr_regime_id.code ; nature de transaction =
transaction_id.code

Adapt to changes in intrastat_base with the 'intrastat' field of fiscal
position converted from boolean to selection with 3 possible values
b2b/b2c/no
@alexis-via
Copy link
Contributor

I have implemented what has been discussed here for v16. PRs are ready.

@alexis-via
Copy link
Contributor

BTW, the merge of v16 modules is blocked because of environment issues. If someone knows how to solve this... see error on #207

alexis-via added a commit to akretion/intrastat-extrastat that referenced this issue Mar 6, 2023
This migration has been made from the v14 branch akretion/14-brexit-simplification-and-type-on-fp and the changes of v15 has been re-integrated.

As discussed on OCA#194
the intrastat transaction codes are now integrated in the module intrastat_product

The default value for transaction_id depending on the move_type of the
invoice have been dropped on fiscal position and company: Odoo sets 11
when fiscal position is B2B and 12 when fiscal position is B2C.
As a consequence: intrastat.transaction: company_id = False by default

Use textwrap for name_get() of intrastat.transaction

partner_id on computation line is not a related field any more: it allows
to auto-fill VAT from partner_id when creating a line manually.

computation and declaration line tree view: display transaction code
instead of transaction_id to save space
njeudy pushed a commit to Alusage/l10n-france that referenced this issue May 13, 2023
This migration started from the v14 branch akretion/14-emebi-simplify
It includes the changes discussed in
OCA/intrastat-extrastat#194 in particular the
fact that intrastat transaction are now provided by the generic module
intrastat_product.
This change involve one big change:
BEFORE: code regime = transaction_id.code ; nature de transaction =
transaction_id.fr_transaction_code
AFTER: code regime = fr_regime_id.code ; nature de transaction =
transaction_id.code

Adapt to changes in intrastat_base with the 'intrastat' field of fiscal
position converted from boolean to selection with 3 possible values
b2b/b2c/no
alexis-via added a commit to akretion/l10n-france that referenced this issue Jan 24, 2024
This migration started from the v14 branch akretion/14-emebi-simplify
It includes the changes discussed in
OCA/intrastat-extrastat#194 in particular the
fact that intrastat transaction are now provided by the generic module
intrastat_product.
This change involve one big change:
BEFORE: code regime = transaction_id.code ; nature de transaction =
transaction_id.fr_transaction_code
AFTER: code regime = fr_regime_id.code ; nature de transaction =
transaction_id.code

Adapt to changes in intrastat_base with the 'intrastat' field of fiscal
position converted from boolean to selection with 3 possible values
b2b/b2c/no
alexis-via added a commit to akretion/intrastat-extrastat that referenced this issue Jan 24, 2024
This migration has been made from the v14 branch akretion/14-brexit-simplification-and-type-on-fp and the changes of v15 has been re-integrated.

As discussed on OCA#194
the intrastat transaction codes are now integrated in the module intrastat_product

The default value for transaction_id depending on the move_type of the
invoice have been dropped on fiscal position and company: Odoo sets 11
when fiscal position is B2B and 12 when fiscal position is B2C.
As a consequence: intrastat.transaction: company_id = False by default

Use textwrap for name_get() of intrastat.transaction

partner_id on computation line is not a related field any more: it allows
to auto-fill VAT from partner_id when creating a line manually.

computation and declaration line tree view: display transaction code
instead of transaction_id to save space
alexis-via added a commit to akretion/intrastat-extrastat that referenced this issue Mar 26, 2024
This migration has been made from the v14 branch akretion/14-brexit-simplification-and-type-on-fp and the changes of v15 has been re-integrated.

As discussed on OCA#194
the intrastat transaction codes are now integrated in the module intrastat_product

The default value for transaction_id depending on the move_type of the
invoice have been dropped on fiscal position and company: Odoo sets 11
when fiscal position is B2B and 12 when fiscal position is B2C.
As a consequence: intrastat.transaction: company_id = False by default

Use textwrap for name_get() of intrastat.transaction

partner_id on computation line is not a related field any more: it allows
to auto-fill VAT from partner_id when creating a line manually.

computation and declaration line tree view: display transaction code
instead of transaction_id to save space
dreispt pushed a commit to ursais/intrastat-extrastat that referenced this issue May 25, 2024
This migration has been made from the v14 branch akretion/14-brexit-simplification-and-type-on-fp and the changes of v15 has been re-integrated.

As discussed on OCA#194
the intrastat transaction codes are now integrated in the module intrastat_product

The default value for transaction_id depending on the move_type of the
invoice have been dropped on fiscal position and company: Odoo sets 11
when fiscal position is B2B and 12 when fiscal position is B2C.
As a consequence: intrastat.transaction: company_id = False by default

Use textwrap for name_get() of intrastat.transaction

partner_id on computation line is not a related field any more: it allows
to auto-fill VAT from partner_id when creating a line manually.

computation and declaration line tree view: display transaction code
instead of transaction_id to save space
dreispt pushed a commit to ursais/intrastat-extrastat that referenced this issue Sep 12, 2024
This migration has been made from the v14 branch akretion/14-brexit-simplification-and-type-on-fp and the changes of v15 has been re-integrated.

As discussed on OCA#194
the intrastat transaction codes are now integrated in the module intrastat_product

The default value for transaction_id depending on the move_type of the
invoice have been dropped on fiscal position and company: Odoo sets 11
when fiscal position is B2B and 12 when fiscal position is B2C.
As a consequence: intrastat.transaction: company_id = False by default

Use textwrap for name_get() of intrastat.transaction

partner_id on computation line is not a related field any more: it allows
to auto-fill VAT from partner_id when creating a line manually.

computation and declaration line tree view: display transaction code
instead of transaction_id to save space
alexis-via added a commit to akretion/l10n-france that referenced this issue Sep 28, 2024
This migration started from the v14 branch akretion/14-emebi-simplify
It includes the changes discussed in
OCA/intrastat-extrastat#194 in particular the
fact that intrastat transaction are now provided by the generic module
intrastat_product.
This change involve one big change:
BEFORE: code regime = transaction_id.code ; nature de transaction =
transaction_id.fr_transaction_code
AFTER: code regime = fr_regime_id.code ; nature de transaction =
transaction_id.code

Adapt to changes in intrastat_base with the 'intrastat' field of fiscal
position converted from boolean to selection with 3 possible values
b2b/b2c/no
alexis-via added a commit to akretion/intrastat-extrastat that referenced this issue Feb 1, 2025
This migration has been made from the v14 branch akretion/14-brexit-simplification-and-type-on-fp and the changes of v15 has been re-integrated.

As discussed on OCA#194
the intrastat transaction codes are now integrated in the module intrastat_product

The default value for transaction_id depending on the move_type of the
invoice have been dropped on fiscal position and company: Odoo sets 11
when fiscal position is B2B and 12 when fiscal position is B2C.
As a consequence: intrastat.transaction: company_id = False by default

Use textwrap for name_get() of intrastat.transaction

partner_id on computation line is not a related field any more: it allows
to auto-fill VAT from partner_id when creating a line manually.

computation and declaration line tree view: display transaction code
instead of transaction_id to save space
alexis-via added a commit to akretion/l10n-france that referenced this issue Feb 1, 2025
This migration started from the v14 branch akretion/14-emebi-simplify
It includes the changes discussed in
OCA/intrastat-extrastat#194 in particular the
fact that intrastat transaction are now provided by the generic module
intrastat_product.
This change involve one big change:
BEFORE: code regime = transaction_id.code ; nature de transaction =
transaction_id.fr_transaction_code
AFTER: code regime = fr_regime_id.code ; nature de transaction =
transaction_id.code

Adapt to changes in intrastat_base with the 'intrastat' field of fiscal
position converted from boolean to selection with 3 possible values
b2b/b2c/no
alexis-via added a commit to akretion/intrastat-extrastat that referenced this issue Feb 11, 2025
This migration has been made from the v14 branch akretion/14-brexit-simplification-and-type-on-fp and the changes of v15 has been re-integrated.

As discussed on OCA#194
the intrastat transaction codes are now integrated in the module intrastat_product

The default value for transaction_id depending on the move_type of the
invoice have been dropped on fiscal position and company: Odoo sets 11
when fiscal position is B2B and 12 when fiscal position is B2C.
As a consequence: intrastat.transaction: company_id = False by default

Use textwrap for name_get() of intrastat.transaction

partner_id on computation line is not a related field any more: it allows
to auto-fill VAT from partner_id when creating a line manually.

computation and declaration line tree view: display transaction code
instead of transaction_id to save space
alexis-via added a commit to akretion/l10n-france that referenced this issue Feb 17, 2025
This migration started from the v14 branch akretion/14-emebi-simplify
It includes the changes discussed in
OCA/intrastat-extrastat#194 in particular the
fact that intrastat transaction are now provided by the generic module
intrastat_product.
This change involve one big change:
BEFORE: code regime = transaction_id.code ; nature de transaction =
transaction_id.fr_transaction_code
AFTER: code regime = fr_regime_id.code ; nature de transaction =
transaction_id.code

Adapt to changes in intrastat_base with the 'intrastat' field of fiscal
position converted from boolean to selection with 3 possible values
b2b/b2c/no
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted no stale Use this label to prevent the automated stale action from closing this PR/Issue. work in progress
Projects
None yet
Development

No branches or pull requests

3 participants