[MIG] account_asset_number: Migration to 18.0

Author: Pani-k-folk

account_asset_number/models/account_asset_profile.py

@@ -9,7 +9,6 @@ class AccountAssetProfile(models.Model):
 
     use_sequence = fields.Boolean(
         string="Auto Asset Number by Sequence",
-        default=False,
         help="If check, asset number auto run by sequence.",
     )
     sequence_id = fields.Many2one(

account_asset_number/report/account_asset_report_xls.py

@@ -1,7 +1,7 @@
 # Copyright 2021 Ecosoft Co., Ltd. (http://ecosoft.co.th)
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
-from odoo import _, models
+from odoo import models
 
 
 class AssetReportXlsx(models.AbstractModel):
@@ -12,7 +12,7 @@ def _get_asset_template(self):
         res.update(
             {
                 "number": {
-                    "header": {"type": "string", "value": _("Number")},
+                    "header": {"type": "string", "value": self.env._("Number")},
                     "asset": {
                         "type": "string",
                         "value": self._render("asset.number or ''"),

account_asset_number/tests/test_account_asset_number.py

@@ -14,6 +14,7 @@
 class TestAssetNumber(TestAssetManagement):
     @classmethod
     def setUpClass(cls):
+        """Setup."""
         super().setUpClass()
         cls.sequence_asset = cls.env["ir.sequence"].create(
             {
@@ -26,7 +27,8 @@ def setUpClass(cls):
         )
 
     def test_01_asset_number(self):
-        # use sequence number on profile_id
+        """Test asset creation with a sequence."""
+
         self.car5y.write(
             {
                 "use_sequence": True,
@@ -55,3 +57,85 @@ def test_01_asset_number(self):
         asset.validate()
         self.assertTrue(asset.number)
         self.assertEqual(asset.number[:2], "AC")
+
+    def test_02_asset_number_without_sequence(self):
+        """Test asset creation without a sequence."""
+        self.car5y.write(
+            {
+                "use_sequence": False,
+                "sequence_id": self.sequence_asset.id,
+            }
+        )
+
+        asset = self.asset_model.create(
+            {
+                "name": "test asset without sequence",
+                "profile_id": self.car5y.id,
+                "purchase_value": 1500,
+                "salvage_value": 100,
+                "date_start": time.strftime("%Y-08-01"),
+                "method_time": "year",
+                "method": "degr-linear",
+                "method_number": 5,
+                "method_period": "year",
+                "prorata": False,
+            }
+        )
+
+        asset.validate()
+
+        self.assertFalse(
+            asset.number,
+            "The asset number should not be generated when sequence is disabled.",
+        )
+
+    def test_03_xls_fields(self):
+        """Test XLS fields include the number field."""
+        acquisition_fields = self.env["account.asset"]._xls_acquisition_fields()
+        active_fields = self.env["account.asset"]._xls_active_fields()
+        removal_fields = self.env["account.asset"]._xls_removal_fields()
+
+        self.assertIn(
+            "number",
+            acquisition_fields,
+            "The number field should be included in acquisition fields.",
+        )
+        self.assertIn(
+            "number",
+            active_fields,
+            "The number field should be included in active fields.",
+        )
+        self.assertIn(
+            "number",
+            removal_fields,
+            "The number field should be included in removal fields.",
+        )
+
+    def test_04_profile_barcode_type_onchange(self):
+        """Test the onchange logic for barcode_type."""
+        self.ict3Y.write(
+            {
+                "barcode_width": 350,
+                "barcode_height": 75,
+            }
+        )
+
+        self.ict3Y.barcode_type = "qr"
+        self.ict3Y._onchange_barcode_type()
+        self.assertEqual(
+            self.ict3Y.barcode_width, 150, "QR barcode width should default to 150."
+        )
+        self.assertEqual(
+            self.ict3Y.barcode_height,
+            75,
+            "Barcode height should remain unchanged for QR.",
+        )
+
+        self.ict3Y.barcode_type = "barcode"
+        self.ict3Y._onchange_barcode_type()
+        self.assertEqual(
+            self.ict3Y.barcode_width, 300, "Barcode width should default to 300."
+        )
+        self.assertEqual(
+            self.ict3Y.barcode_height, 75, "Barcode height should default to 75."
+        )

account_asset_number/views/account_asset.xml

@@ -12,11 +12,7 @@
                 <field name="use_sequence" invisible="True" />
                 <label for="number" class="oe_edit_only" />
                 <h2>
-                    <field
-                        name="number"
-                        class="oe_inline"
-                        attrs="{'readonly':[('use_sequence', '=', True)]}"
-                    />
+                    <field name="number" class="oe_inline" readonly="use_sequence" />
                 </h2>
             </h1>
         </field>
@@ -43,9 +39,9 @@
         />
         <field name="arch" type="xml">
             <xpath expr="//field[@name='name']" position="attributes">
-                <attribute
-                    name="filter_domain"
-                >['|', ('name', 'ilike', self), ('number', 'ilike', self)]</attribute>
+                <attribute name="filter_domain">
+                    ['|', ('name', 'ilike', self), ('number', 'ilike', self)]
+                </attribute>
             </xpath>
         </field>
     </record>

account_asset_number/views/account_asset_profile.xml

@@ -10,24 +10,18 @@
         <field name="arch" type="xml">
             <xpath expr="//sheet/group/group[last()]" position="after">
                 <group string="QR/Barcode Configuration">
-                    <field
-                        name="barcode_type"
-                        attrs="{'required': [('use_sequence', '=', True)]}"
-                    />
-                    <field
-                        name="barcode_width"
-                        attrs="{'required': [('use_sequence', '=', True)]}"
-                    />
+                    <field name="barcode_type" required="use_sequence" />
+                    <field name="barcode_width" required="use_sequence" />
                     <field
                         name="barcode_height"
-                        attrs="{'invisible': [('barcode_type', '=', 'qr')],
-                                'required': [('use_sequence', '=', True)]}"
+                        required="use_sequence"
+                        invisible="barcode_type == 'qr'"
                     />
                     <field name="use_sequence" />
                     <field
                         name="sequence_id"
-                        attrs="{'invisible': [('use_sequence', '!=', True)],
-                                'required': [('use_sequence', '=', True)]}"
+                        required="use_sequence"
+                        invisible="not use_sequence"
                     />
                 </group>
             </xpath>