Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why peer dep on @glint/template? #989

Open
simonihmig opened this issue Sep 3, 2023 · 1 comment
Open

Why peer dep on @glint/template? #989

simonihmig opened this issue Sep 3, 2023 · 1 comment

Comments

@simonihmig
Copy link
Contributor

Noticed this in a non-TS pnpm project: ember-resources requires me to install @glint/template to resolve peer deps. But that's not required for non-TS projects, is it? Should it be declared optional?
@NullVoxPopuli
Copy link
Owner

Probably!

I struggled with whether or not to make it optional early on, because for TS, it's not optional. But maybe that's fine, and how it's supposed to work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NullVoxPopuli @simonihmig