Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glimmer support? #598

Open
NullVoxPopuli opened this issue Aug 26, 2022 · 2 comments
Open

Glimmer support? #598

NullVoxPopuli opened this issue Aug 26, 2022 · 2 comments

Comments

@NullVoxPopuli
Copy link
Owner

NullVoxPopuli commented Aug 26, 2022

Since all the framework dependencies in this library are actually re-exports of glimmer packages, it should be fairly straightforward (behaviorally) to support both ember and glimmer.

A tricky part may be (uncertainty) typescript support for all of ember/glimmer/glint simultaneously (maybe). Glint depends on glimmer dependencies as well, so maybe this is a non issue.

Here is a sample glimmer app that could be copied for making a test app: https://github.com/knownasilya/logux-poc

@knownasilya
Copy link

@NullVoxPopuli
Copy link
Owner Author

yeah, I think all the @ember/* imports have glimmer counterparts like that.

The only thing I'm uncertain about is assert from @ember/debug.

I like that consuming apps remove those from production builds -- but idk if glimmer has an equivalent, and then if glimmer projects also remove those from production builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants