Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offsetting ID of MCParticle loses its "primariness" information #3

Open
PetrilloAtWork opened this issue Jun 2, 2022 · 1 comment
Open

Offsetting ID of MCParticle loses its "primariness" information #3

PetrilloAtWork opened this issue Jun 2, 2022 · 1 comment

Comments

@PetrilloAtWork
Copy link

By convention, a "primary" particle is recognised as having a mother particle ID 0.
The constructor applying an offset to another particle does not maintain that information.
PetrilloAtWork added a commit to PetrilloAtWork/nusimdata that referenced this issue Jun 2, 2022
@PetrilloAtWork
Do not apply offset to primary particles
bff504d 
See nusimdata issue NuSoftHEP#3.
@bear-is-asleep bear-is-asleep mentioned this issue Jan 31, 2024
Closed
@bear-is-asleep
Copy link
Contributor

Should we update the constructor such that is doesn't update the mother ID? @PetrilloAtWork . I don't see an obvious reason to keep the constructor as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PetrilloAtWork @bear-is-asleep