Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Relying On LlamaFactory Fork #73

Open
shea-demandbase opened this issue Feb 17, 2025 · 3 comments
Open

Stop Relying On LlamaFactory Fork #73

shea-demandbase opened this issue Feb 17, 2025 · 3 comments

Comments

@shea-demandbase
Copy link

Hey team,

Currently I am working on the skythought repo, and I wanted to begin discussion on why the project is currently relying on the llamafactory fork that it is. I was hoping to learn:

  1. Why a fork of llamafactory must be used.
  2. If there was any plan to merge the changes to the upstream llamafactory.
  3. If I can help with getting any changes into the the upstream.

Let me know on the above. Would love to help if I'm able!

@kouroshHakha
Copy link
Collaborator

cc @DachengLi1

@DachengLi1
Copy link
Collaborator

Thank you @shea-demandbase for your interest!

We made some small changes to the configurations, but technically it does not need to be a complete fork.

We can do monkey patches and simply pip install llama factory, but we didn't have bandwidth to add this feature. We are open to contributors!

@shea-demandbase
Copy link
Author

Very nice! I will try diffing the fork with main, and then work on cleanly implementing the solution (either via monkey patches or by merging a new input config to the upstream). I'll let this team know my progress :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants