Skip to content

Commit eb4114e

Browse files
committed
Addressed some warnings
1 parent 87b54c0 commit eb4114e

File tree

5 files changed

+6
-7
lines changed

5 files changed

+6
-7
lines changed

Noggog.CSharpExt/Extensions/ByteExt.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ public static unsafe bool EqualsFast(this byte[] b1, byte[] b2)
6969
return b1.Length == b2.Length && memcmp(b1, b2, b1.Length) == 0;
7070
}
7171

72-
[ReliabilityContract(Consistency.WillNotCorruptState, Cer.MayFail)]
7372
public static unsafe bool CharBytesEqualsFast(byte[] strA, byte[] strB)
7473
{
7574
if (strA == null && strB == null) return true;

Noggog.CSharpExt/Extensions/ObservableExt.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -604,8 +604,8 @@ public static IObservable<ChangeSet<FilePath, FilePath>> WatchFolderContents(
604604
});
605605
}
606606

607-
/// These snippets were provided by RolandPheasant (author of DynamicData)
608-
/// They'll be going into the official library at some point, but are here for now.
607+
// These snippets were provided by RolandPheasant (author of DynamicData)
608+
// They'll be going into the official library at some point, but are here for now.
609609

610610
#region Dynamic Data EnsureUniqueChanges
611611
/// <summary>

Noggog.CSharpExt/Extensions/SymbolExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ public static class SymbolExtensions
88
/// <summary>
99
/// Given a lambda expression that calls a method, returns the method info.
1010
/// </summary>
11-
/// <typeparam name="T"></typeparam>
1211
/// <param name="expression">The expression.</param>
1312
/// <returns></returns>
1413
public static MethodInfo GetMethodInfo(Expression<Action> expression)
@@ -31,6 +30,7 @@ public static MethodInfo GetMethodInfo<T>(Expression<Action<T>> expression)
3130
/// Given a lambda expression that calls a method, returns the method info.
3231
/// </summary>
3332
/// <typeparam name="T"></typeparam>
33+
/// <typeparam name="TResult"></typeparam>
3434
/// <param name="expression">The expression.</param>
3535
/// <returns></returns>
3636
public static MethodInfo GetMethodInfo<T, TResult>(Expression<Func<T, TResult>> expression)

Noggog.CSharpExt/Streams/Binary/IBinaryMemoryWriteStream.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ namespace Noggog;
22

33
public interface IBinaryMemoryWriteStream : IBinaryWriteStream
44
{
5-
int Position { get; set; }
6-
int Length { get; }
5+
new int Position { get; set; }
6+
new int Length { get; }
77
int Remaining { get; }
88
void Write(ReadOnlySpan<byte> buffer, int offset, int amount);
99
}

Noggog.CSharpExt/Structs/FileSystems/FilePath.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ public override int GetHashCode()
115115

116116
public Stream OpenRead(IFileSystem? fileSystem = null)
117117
{
118-
return fileSystem.GetOrDefault().FileStream.Create(Path, FileMode.Open, FileAccess.Read, FileShare.Read);
118+
return fileSystem.GetOrDefault().FileStream.New(Path, FileMode.Open, FileAccess.Read, FileShare.Read);
119119
}
120120

121121
public FilePath MakeAbsolute()

0 commit comments

Comments
 (0)