Properly fix quit command

NodeRedis · Jan 3, 2016 · 2c091a5 · 2c091a5
1 parent 18da5e5
commit 2c091a5
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 3 deletions.
diff --git a/commands.json b/commands.json
@@ -984,6 +984,17 @@
     "keyStop": 0,
     "step": 0
   },
+  "quit": {
+    "arity": 1,
+    "flags": [
+      "loading",
+      "stale",
+      "readonly"
+    ],
+    "keyStart": 0,
+    "keyStop": 0,
+    "step": 0
+  },
   "randomkey": {
     "arity": 1,
     "flags": [

diff --git a/index.js b/index.js
@@ -10,9 +10,7 @@ var commands = require('./commands');
  * @var {string[]}
  * @public
  */
-var commandsList = Object.keys(commands);
-commandsList.push('quit');
-exports.list = commandsList;
+exports.list = Object.keys(commands);
 
 /**
  * Check if the command has the flag

diff --git a/test/index.js b/test/index.js
@@ -37,6 +37,7 @@ describe('redis-commands', function () {
       expect(commands.hasFlag('set', 'fast')).to.eql(false);
       expect(commands.hasFlag('set', 'readonly')).to.eql(false);
       expect(commands.hasFlag('select', 'denyoom')).to.eql(false);
+      expect(commands.hasFlag('quit', 'denyoom')).to.eql(false);
     });
   });
 

diff --git a/tools/build.js b/tools/build.js
@@ -24,6 +24,21 @@ redis.command(function (err, res) {
     return prev;
   }, {});
 
+  // Future proof. Redis might implement this soon
+  if (!commands.quit) {
+    commands.quit = {
+      arity: 1,
+      flags: [
+        'loading',
+        'stale',
+        'readonly'
+      ],
+      keyStart: 0,
+      keyStop: 0,
+      step: 0
+    }
+  }
+
   // Use json-stable-stringify instead fo JSON.stringify
   // for easier diffing
   var content = stringify(commands, { space: '  ' });