chore: move error creation in handler function

NodeRedis · May 25, 2017 · 4d86647 · 4d86647
1 parent 140e621
commit 4d86647
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/lib/parser.js b/lib/parser.js
@@ -186,9 +186,14 @@ function parseError (parser) {
  * @param {number} type
  * @returns {undefined}
  */
-function handleError (parser, error) {
+function handleError (parser, type) {
+  const err = new ParserError(
+    'Protocol error, got ' + JSON.stringify(String.fromCharCode(type)) + ' as reply type byte',
+    JSON.stringify(parser.buffer),
+    parser.offset
+  )
   parser.buffer = null
-  parser.returnFatalError(error)
+  parser.returnFatalError(err)
 }
 
 /**
@@ -296,11 +301,7 @@ function parseType (parser, type) {
     case 45:
       return parseError(parser)
     default:
-      return handleError(parser, new ParserError(
-        'Protocol error, got ' + JSON.stringify(String.fromCharCode(type)) + ' as reply type byte',
-        JSON.stringify(parser.buffer),
-        parser.offset
-      ))
+      return handleError(parser, type)
   }
 }