Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vagrant: 2.2.19 -> 2.3.4 #219237

Closed
wants to merge 1 commit into from
Closed

Conversation

REPLicated
Copy link

@REPLicated REPLicated commented Mar 2, 2023

Description of changes

Fixes #186606.

This makes it possible to run Vagrant with VirtualBox 7.0 using the virtualbox provider.
Note that I did not attempt to package the new alpha version of "vagrant-go" for now (see hashicorp/vagrant#12819 for details).

Changelog: https://github.com/hashicorp/vagrant/blob/v2.3.4/CHANGELOG.md

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Mar 4, 2023

The grpc gem fails to build for me on macos 10.15:

strip: error: symbols referenced by indirect symbol table entries that can't be stripped in: /nix/store/qhhd273h03yl562ssid1kbhlczjfj6dv-ruby2.7.7-grpc-1.52.0/lib/ruby/gems/2.7.0/gems/grpc-1.52.0/src/ruby/ext/grpc/grpc_c.bundle
_CFBundleGetVersionNumber
_CFRelease
_CFStringGetCString
_CFStringGetLength
_CFStringGetMaximumSizeForEncoding
_CFTimeZoneCopyDefault
_CFTimeZoneGetName
__Unwind_Resume
__ZNKSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEE5rfindEcm
...
...

apparently on ofborg too.

@GabrielDougherty
Copy link
Member

Same issue. Here is the full log from nix log /nix/store/k3k9yxaffh4v0c90sapp7bpb3n6v3xb5-ruby2.7.7-grpc-1.52.0.drv

pr-219237.txt

@risicle risicle mentioned this pull request Apr 7, 2023
12 tasks
@risicle risicle mentioned this pull request Apr 30, 2023
12 tasks
@jerith666
Copy link
Contributor

I suggest closing in favor of #225136, which has a bit of discussion about the darwin breakage.

@wegank wegank closed this May 1, 2023
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkgs.vagrant: Out-of-date 2.2.19 -> 2.3.0.
6 participants