build: add clang-tidy integration #14660
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Needs proper attribution to lix contributors tho |
Member
Author
|
Yeah, I think we need to figure out how to do that (Co-Authored-By vs. notice in files vs. referencing the change-id from gerrit in the commit, etc) |
lovesegfault
force-pushed
the
clang-tidy
branch
from
f4ece81 to
a0d63e1
Compare
- Add meson infrastructure for clang-tidy in nix-meson-build-support/common/clang-tidy/ with compile_commands.json cleaning and parallel runner - Create custom clang-tidy plugin scaffolding in src/clang-tidy-plugin/ - Add enableClangTidyLayer in packaging/components.nix that runs clang-tidy on all C++ components via postBuild hook - Add clangTidy Hydra job in packaging/hydra.nix - Add clang-tidy CI job in .github/workflows/ci.yml to enforce on PRs - Document usage in doc/manual/source/development/static-analysis.md Uses debug build mode and skips tests for faster CI. Warnings are treated as errors to catch issues early.
lovesegfault
force-pushed
the
clang-tidy
branch
from
a0d63e1 to
5d11241
Compare
Member
Co-authored-by is what we tended to do and referencing commit urls in messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Just early days, partially a side-port of how Lix achieved this :)
Context
Fixes: #11839
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.